[{"id":3673846,"web_url":"http://patchwork.ozlabs.org/comment/3673846/","msgid":"<15e26c80-0517-472a-9e9d-8389ccef4e23@linaro.org>","list_archive_url":null,"date":"2026-04-06T18:28:59","subject":"Re: [PATCH v7 00/14] target/arm: single-binary","submitter":{"id":85798,"url":"http://patchwork.ozlabs.org/api/people/85798/","name":"Pierrick Bouvier","email":"pierrick.bouvier@linaro.org"},"content":"On 4/6/26 8:04 AM, Pierrick Bouvier wrote:\n> This series tackles (most of) the rest of target/arm, especially tcg folder.\n> \n> We extract tcg memory operation in a new header, with a new type representing\n> virtual addresses.\n> \n> Initially, I went down the way to have a dynamic definition of TCGv, which\n> required much more boilerplate and runtime checks. After discussing with\n> Richard, I realized it was not needed, and that could simply split 32 and 64 bit\n> properly in different files instead. This approach will not work with other\n> architectures, requiring something else, but it's enough for target/arm.\n> \n> Files left are:\n> - target/arm/tcg/mve_helper.c\n> - target/arm/tcg/m_helper.c\n> - target/arm/tcg/cpu32.c\n> \n> v7\n> --\n> \n> - add parameter to translator_loop to indicate address type for current tb.\n> - remove TCGv from target/arm/tcg/translate.c\n> \n> v6\n> --\n> \n> - meson.build: extract decode files in separate variables and explicitly include\n>    them in user and system code. The duplication is now minimized: one instance\n>    for all system binaries, and one per user binary.\n> \n> v5\n> --\n> \n> - reimplemented what v0 did with new approach defining new tcg-op-mem header\n> - reapply all straightforward patches from v0\n> - only translate.c is left, but first want to validate that changes here are ok\n>    for maintainers before doing more.\n> \n> v0\n> --\n> \n> See original thread:\n> https://lore.kernel.org/qemu-devel/20260109053158.2800705-1-pierrick.bouvier@linaro.org/#t\n> \n> Note about v1 -> v4\n> -------------------\n> \n> - After v0 which was trying to do too many changes, v1 to v4 focused on smaller\n>    things, and all patches have been merged already.\n>    https://patchew.org/QEMU/20260219040150.2098396-1-pierrick.bouvier@linaro.org/\n> \n> Pierrick Bouvier (14):\n>    include/tcg/tcg-op: extract memory operations to tcg-op-mem.h\n>    target/arm/translate.h: remove tcg-op.h include\n>    target/arm/tcg/translate.h: remove tcg-op-gvec.h include\n>    target/arm/tcg/translate.h: remove TARGET_AARCH64\n>    target/arm/tcg/translate-vfp.c: make compilation unit common\n>    target/arm/tcg/translate-neon.c: make compilation unit common\n>    target/arm/tcg/translate-mve.c: make compilation unit common\n>    target/arm/tcg/translate-m-nocp.c: make compilation unit common\n>    target/arm/tcg/op_helper.c: make compilation unit common\n>    target/arm/tcg/gengvec.c: make compilation unit common\n>    target/arm/tcg/translate.c: remove MO_TE usage\n>    target/arm/tcg/translate.c: replace target_ulong with uint32_t\n>    tcg/translator: add parameter to translator_loop for current addr type\n>    target/arm/tcg/translate.c: replace TCGv with TCGv_va\n> \n>   include/exec/translator.h        |   4 +-\n>   include/tcg/tcg-op-mem.h         | 126 +++++++++++++++++++++++++++++++\n>   include/tcg/tcg-op.h             | 100 +-----------------------\n>   include/tcg/tcg.h                |   5 ++\n>   target/arm/tcg/translate.h       |  14 +---\n>   accel/tcg/translator.c           |   4 +-\n>   target/alpha/translate.c         |   3 +-\n>   target/arm/tcg/op_helper.c       |   1 -\n>   target/arm/tcg/stubs32.c         |  17 +++++\n>   target/arm/tcg/translate-a64.c   |   1 +\n>   target/arm/tcg/translate-sme.c   |   1 +\n>   target/arm/tcg/translate-sve.c   |   1 +\n>   target/arm/tcg/translate.c       |  36 ++++-----\n>   target/avr/translate.c           |   3 +-\n>   target/hexagon/translate.c       |   3 +-\n>   target/hppa/translate.c          |   3 +-\n>   target/i386/tcg/translate.c      |   3 +-\n>   target/loongarch/tcg/translate.c |   3 +-\n>   target/m68k/translate.c          |   3 +-\n>   target/microblaze/translate.c    |   3 +-\n>   target/mips/tcg/translate.c      |   3 +-\n>   target/or1k/translate.c          |   3 +-\n>   target/ppc/translate.c           |   3 +-\n>   target/riscv/translate.c         |   3 +-\n>   target/rx/translate.c            |   3 +-\n>   target/s390x/tcg/translate.c     |   3 +-\n>   target/sh4/translate.c           |   3 +-\n>   target/sparc/translate.c         |   3 +-\n>   target/tricore/translate.c       |   3 +-\n>   target/xtensa/translate.c        |   3 +-\n>   target/arm/tcg/meson.build       |  51 +++++++++----\n>   31 files changed, 255 insertions(+), 160 deletions(-)\n>   create mode 100644 include/tcg/tcg-op-mem.h\n>   create mode 100644 target/arm/tcg/stubs32.c\n> \n\nv8 sent:\nhttps://lore.kernel.org/qemu-devel/20260406182609.193886-1-pierrick.bouvier@linaro.org/T/#t\n\nRegards,\nPierrick","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=PWvQhzPX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqHtQ1lvxz1yFt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 07 Apr 2026 04:29:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w9ohT-0004v2-Km; Mon, 06 Apr 2026 14:29:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1w9oh6-0004mP-JU\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 14:29:11 -0400","from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1w9oh4-00033g-LJ\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 14:29:04 -0400","by mail-pj1-x1036.google.com with SMTP id\n 98e67ed59e1d1-35d94f4ee36so2321666a91.3\n for <qemu-devel@nongnu.org>; Mon, 06 Apr 2026 11:29:02 -0700 (PDT)","from [192.168.1.168] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35df82368f6sm7572112a91.12.2026.04.06.11.28.59\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 06 Apr 2026 11:29:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775500141; x=1776104941; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:content-language\n :from:references:cc:to:subject:user-agent:mime-version:date\n :message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=6lHJj1R1/IEJ03VB7HCab/9hYqVCNqWHsnIIYAqzF8o=;\n b=PWvQhzPXfC5xugHXBtQZHrpnMh3CIl9V/r4HUbMeBUUTyyKqKVOGkBzqeEp/ol9DNk\n 8STTI6RWdRjnAkpFyrjDHRjKZwQuP74M+0vwZGErMr88wPMHfC5GkjWK15/zv2lKf7ZZ\n 20DuXbn6bQAIAjPxdfm9E+zWby6tg9Md9Pi/rzlEQGw7OpYF3UBJ71KZqir5B83tWILw\n e/h0mGfogKkyo8HCJUQfxqmhkERXGJIoVqlVslHiAsX+fU+MdJ2OC3QFzkoJA71s8LmN\n STKrKqgYcC7dH35CGfTaf5vvIYEwhNSoa/kDsNcmQ8uegk47z9oluAAgE8MBplgt4gsA\n ahpQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775500141; x=1776104941;\n h=content-transfer-encoding:in-reply-to:autocrypt:content-language\n :from:references:cc:to:subject:user-agent:mime-version:date\n :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6lHJj1R1/IEJ03VB7HCab/9hYqVCNqWHsnIIYAqzF8o=;\n b=ZLPPeUBkf4Jtg4tKw3Yf7DY8aJSA8hdEHtNBN3PzSgt8S36mGZKUmHF0Kb7sja3J9a\n GEg5L3gmJCFtqhZ23dJT8zdrPY5vQ5jxR2pPYAZ2UGocj9UlIXTATeS20ZVd6FLR3OT2\n P6HEczNNB7rbSlUvx5kRpnX47dAXGiQ7Fhod7iXgYk86JL6WPoz94TJMgLASchmH9P3r\n ZsDyK+FMrrb09vg2CYCWqHQJmbBXtaQqU35zMO/5suRE6+W5IVEChuvIwhf1/GwCiid8\n aeGO05d7VukvSTbU/DFNweHRNFGMJJ2IgfQnpQ6zAtO67zXRWYwzoz6n+/S4BohjRJQD\n 8yNw==","X-Gm-Message-State":"AOJu0YwMqCNpxjzM4OEgez4tta6UW+zMzLS97HRfV6nEDH5Ek5g3IkPl\n BfBxsmJygQJGerbXI9/2+wiuRUQXr3XR2+FAMtdZlxw15/qLTNUSMfI4o0tDkvgCJfAQvP4GtU6\n RcsWM4aTL9w==","X-Gm-Gg":"AeBDiesfWQi4tODdL3K7Tq/3XGMZAXvdN4PHCNKhcNJ6AKpt1HBE1DeRcg+QxYFIDUZ\n OCmNS2zO9Ld9vWsXL6oweXKxCHNwakKq7ITED5h3sx9Wew0qNmTIaGF3u7Q5+VxfkDQO5klR25I\n SLD7PmqZBVMnP+czNv8AR+0urDkofanXbz3g99hE+rapajyPD+owp5HbTa6Vo6425k/qQCTvBVt\n WR3tj9UlyIcc/jMNHPTOaD3tDaiyFe/xztwqIkTm9vEPcIxkLfsKYZ1PFI37vUYYdyZDkkt+4pr\n H9DTtM6qd9XC+Kv5xqbptEAFcpG5f5fLt/wfCG1ql5KAwD3yFelQrhVtxMfNxvPzsFMjMUuIWMh\n 46+6BNODonpR2nzHcjYMwRWp2IGLn3cgTeql06H8+n71GYLR0HMspNp4wl1JlKemugHhwEHHBZy\n bV2YgTjoZBb1TnJYqzJ/nLaj0Ugs8SDFmxinTE44kUUQLBPP8RHrgCTNYAakMy4YRPo0jhIQ==","X-Received":"by 2002:a17:90b:4d84:b0:35d:a87b:ef69 with SMTP id\n 98e67ed59e1d1-35de695c375mr12458340a91.28.1775500140965;\n Mon, 06 Apr 2026 11:29:00 -0700 (PDT)","Message-ID":"<15e26c80-0517-472a-9e9d-8389ccef4e23@linaro.org>","Date":"Mon, 6 Apr 2026 11:28:59 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v7 00/14] target/arm: single-binary","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,\n philmd@linaro.org, jim.macarthur@linaro.org,\n Paolo Bonzini <pbonzini@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>","References":"<20260406150434.407201-1-pierrick.bouvier@linaro.org>","From":"Pierrick Bouvier <pierrick.bouvier@linaro.org>","Content-Language":"en-US","Autocrypt":"addr=pierrick.bouvier@linaro.org; keydata=\n xsDNBGK9dgwBDACYuRpR31LD+BnJ0M4b5YnPZKbj+gyu82IDN0MeMf2PGf1sux+1O2ryzmnA\n eOiRCUY9l7IbtPYPHN5YVx+7W3vo6v89I7mL940oYAW8loPZRSMbyCiUeSoiN4gWPXetoNBg\n CJmXbVYQgL5e6rsXoMlwFWuGrBY3Ig8YhEqpuYDkRXj2idO11CiDBT/b8A2aGixnpWV/s+AD\n gUyEVjHU6Z8UervvuNKlRUNE0rUfc502Sa8Azdyda8a7MAyrbA/OI0UnSL1m+pXXCxOxCvtU\n qOlipoCOycBjpLlzjj1xxRci+ssiZeOhxdejILf5LO1gXf6pP+ROdW4ySp9L3dAWnNDcnj6U\n 2voYk7/RpRUTpecvkxnwiOoiIQ7BatjkssFy+0sZOYNbOmoqU/Gq+LeFqFYKDV8gNmAoxBvk\n L6EtXUNfTBjiMHyjA/HMMq27Ja3/Y73xlFpTVp7byQoTwF4p1uZOOXjFzqIyW25GvEekDRF8\n IpYd6/BomxHzvMZ2sQ/VXaMAEQEAAc0uUGllcnJpY2sgQm91dmllciA8cGllcnJpY2suYm91\n dmllckBsaW5hcm8ub3JnPsLBDgQTAQoAOBYhBGa5lOyhT38uWroIH3+QVA0KHNAPBQJivXYM\n AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEH+QVA0KHNAPX58L/1DYzrEO4TU9ZhJE\n tKcw/+mCZrzHxPNlQtENJ5NULAJWVaJ/8kRQ3Et5hQYhYDKK+3I+0Tl/tYuUeKNV74dFE7mv\n PmikCXBGN5hv5povhinZ9T14S2xkMgym2T3DbkeaYFSmu8Z89jm/AQVt3ZDRjV6vrVfvVW0L\n F6wPJSOLIvKjOc8/+NXrKLrV/YTEi2R1ovIPXcK7NP6tvzAEgh76kW34AHtroC7GFQKu/aAn\n HnL7XrvNvByjpa636jIM9ij43LpLXjIQk3bwHeoHebkmgzFef+lZafzD+oSNNLoYkuWfoL2l\n CR1mifjh7eybmVx7hfhj3GCmRu9o1x59nct06E3ri8/eY52l/XaWGGuKz1bbCd3xa6NxuzDM\n UZU+b0PxHyg9tvASaVWKZ5SsQ5Lf9Gw6WKEhnyTR8Msnh8kMkE7+QWNDmjr0xqB+k/xMlVLE\n uI9Pmq/RApQkW0Q96lTa1Z/UKPm69BMVnUvHv6u3n0tRCDOHTUKHXp/9h5CH3xawms7AzQRi\n vXYMAQwAwXUyTS/Vgq3M9F+9r6XGwbak6D7sJB3ZSG/ZQe5ByCnH9ZSIFqjMnxr4GZUzgBAj\n FWMSVlseSninYe7MoH15T4QXi0gMmKsU40ckXLG/EW/mXRlLd8NOTZj8lULPwg/lQNAnc7GN\n I4uZoaXmYSc4eI7+gUWTqAHmESHYFjilweyuxcvXhIKez7EXnwaakHMAOzNHIdcGGs8NFh44\n oPh93uIr65EUDNxf0fDjnvu92ujf0rUKGxXJx9BrcYJzr7FliQvprlHaRKjahuwLYfZK6Ma6\n TCU40GsDxbGjR5w/UeOgjpb4SVU99Nol/W9C2aZ7e//2f9APVuzY8USAGWnu3eBJcJB+o9ck\n y2bSJ5gmGT96r88RtH/E1460QxF0GGWZcDzZ6SEKkvGSCYueUMzAAqJz9JSirc76E/JoHXYI\n /FWKgFcC4HRQpZ5ThvyAoj9nTIPI4DwqoaFOdulyYAxcbNmcGAFAsl0jJYJ5Mcm2qfQwNiiW\n YnqdwQzVfhwaAcPVABEBAAHCwPYEGAEKACAWIQRmuZTsoU9/Llq6CB9/kFQNChzQDwUCYr12\n DAIbDAAKCRB/kFQNChzQD/XaC/9MnvmPi8keFJggOg28v+r42P7UQtQ9D3LJMgj3OTzBN2as\n v20Ju09/rj+gx3u7XofHBUj6BsOLVCWjIX52hcEEg+Bzo3uPZ3apYtIgqfjrn/fPB0bCVIbi\n 0hAw6W7Ygt+T1Wuak/EV0KS/If309W4b/DiI+fkQpZhCiLUK7DrA97xA1OT1bJJYkC3y4seo\n 0VHOnZTpnOyZ+8Ejs6gcMiEboFHEEt9P+3mrlVJL/cHpGRtg0ZKJ4QC8UmCE3arzv7KCAc+2\n dRDWiCoRovqXGE2PdAW8788qH5DEXnwfzDhnCQ9Eot0Eyi41d4PWI8TWZFi9KzGXJO82O9gW\n 5SYuJaKzCAgNeAy3gUVUUPrUsul1oe2PeWMFUhWKrqko0/Qo4HkwTZY6S16drTMncoUahSAl\n X4Z3BbSPXPq0v1JJBYNBL9qmjULEX+NbtRd3v0OfB5L49sSAC2zIO8S9Cufiibqx3mxZTaJ1\n ZtfdHNZotF092MIH0IQC3poExQpV/WBYFAI=","In-Reply-To":"<20260406150434.407201-1-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1036;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x1036.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]