[{"id":3673485,"web_url":"http://patchwork.ozlabs.org/comment/3673485/","msgid":"<omtn42mopdz7igg7jaqwehd67l6xc77zk7zzqwkufgnsycvadg@5kodhpgfesre>","list_archive_url":null,"date":"2026-04-04T17:10:16","subject":"Re: [PATCH V2 0/8] PCI: imx6: Integrate pwrctrl API and update\n device trees","submitter":{"id":78905,"url":"http://patchwork.ozlabs.org/api/people/78905/","name":"Manivannan Sadhasivam","email":"mani@kernel.org"},"content":"On Thu, Apr 02, 2026 at 06:09:59PM +0800, Sherry Sun wrote:\n> Note: This patch set depends on my previous patch set [1] which adds\n> Root Port device tree nodes and support parsing the reset property in\n> new Root Port binding in pci-imx6 driver.\n> \n> This series integrates the PCI pwrctrl framework into the pci-imx6\n> driver and updates i.MX EVK board device trees to support it.\n> \n> Patches 2-8 update device trees for i.MX EVK boards which maintained\n> by NXP to move power supply properties from the PCIe controller node\n> to the Root Port child node, which is required for pwrctrl framework.\n> Affected boards:\n> - i.MX6Q/DL SABRESD\n> - i.MX6SX SDB\n> - i.MX8MM EVK\n> - i.MX8MP EVK\n> - i.MX8MQ EVK\n> - i.MX8DXL/QM/QXP EVK\n> - i.MX95 15x15/19x19 EVK\n> \n> The driver maintains legacy regulator handling for device trees that\n> haven't been updated yet. Both old and new device tree structures are\n> supported.\n> \n\nThanks for the work! Due to some recently merged patches, this series (Patch 1)\ndoesn't apply on top of pci/controller/dwc-imx6 branch. Please rebase and\nresend!\n\n- Mani\n\n> [1] https://lore.kernel.org/all/20260318062916.2747472-1-sherry.sun@nxp.com/\n> \n> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>\n> ---\n> Changes in V2:\n> 1. After commit 2d8c5098b847 (\"PCI/pwrctrl: Do not power off on pwrctrl\n>    device removal\"), the pwrctrl drivers no longer power off devices\n>    during removal. Update pci-imx6 driver's shutdown callback in patch#1\n>    to explicitly call pci_pwrctrl_power_off_devices() before \n>    pci_pwrctrl_destroy_devices() to ensure devices are properly powered\n>    off.\n> ---\n> \n> Sherry Sun (8):\n>   PCI: imx6: Integrate new pwrctrl API for pci-imx6\n>   arm: dts: imx6qdl-sabresd: Move power supply property to Root Port\n>     node\n>   arm: dts: imx6sx-sdb: Move power supply property to Root Port node\n>   arm64: dts: imx8mm-evk: Move power supply property to Root Port node\n>   arm64: dts: imx8mp-evk: Move power supply properties to Root Port node\n>   arm64: dts: imx8mq-evk: Move power supply properties to Root Port node\n>   arm64: dts: imx8dxl/qm/qxp: Move power supply properties to Root Port\n>     node\n>   arm64: dts: imx95: Move power supply properties to Root Port node\n> \n>  .../arm/boot/dts/nxp/imx/imx6qdl-sabresd.dtsi |  2 +-\n>  arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi     |  2 +-\n>  arch/arm64/boot/dts/freescale/imx8dxl-evk.dts |  4 ++--\n>  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi |  2 +-\n>  arch/arm64/boot/dts/freescale/imx8mp-evk.dts  |  4 ++--\n>  arch/arm64/boot/dts/freescale/imx8mq-evk.dts  |  4 ++--\n>  arch/arm64/boot/dts/freescale/imx8qm-mek.dts  |  4 ++--\n>  arch/arm64/boot/dts/freescale/imx8qxp-mek.dts |  4 ++--\n>  .../boot/dts/freescale/imx95-15x15-evk.dts    |  4 ++--\n>  .../boot/dts/freescale/imx95-19x19-evk.dts    |  8 +++----\n>  drivers/pci/controller/dwc/Kconfig            |  1 +\n>  drivers/pci/controller/dwc/pci-imx6.c         | 24 ++++++++++++++++++-\n>  12 files changed, 43 insertions(+), 20 deletions(-)\n> \n> -- \n> 2.37.1\n>","headers":{"Return-Path":"\n <linux-pci+bounces-51893-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=tk25YExv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-51893-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"tk25YExv\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fp2Ct4VnCz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 05 Apr 2026 03:10:34 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id F29BE3007E21\n\tfor <incoming@patchwork.ozlabs.org>; Sat,  4 Apr 2026 17:10:32 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 279E426B75B;\n\tSat,  4 Apr 2026 17:10:32 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0213224293C;\n\tSat,  4 Apr 2026 17:10:31 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 0E377C19421;\n\tSat,  4 Apr 2026 17:10:25 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775322632; cv=none;\n b=IS6z6R6ppqRtMKUqHMWZbnR8QXAUq4LJX7LlLjDvrIY1lj8XD/6V3MQn/vJwjUAaYXZU+qLiVMJYEmoK3V67wqEISC9Py1ezZq1cIZbthFLEaZS2+LgCZB/MiFOo4jRelNSWWRRWIcTsWD4/UzGyAnStWxJLjI+9EpPj0ICdD04=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775322632; c=relaxed/simple;\n\tbh=TL1x8uQHfXMCS5DAHiJFSwR5ZSFg/H+USQuXqbWXElU=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=XLsywL5VyA7KEQCr/ZKyhDxiYsJEfH+Q3GVaMhUzOnSqt77/TDedSiu+DiJvx4SZRD0YwAybv5y78+USrKa1Hc6ElLcZUhqdZj+55pmSTdjKqQyQvO3EIY32XPTveqZ30Uae+e39T2jIrX6dYujVwcRLCK9gVgYisSynFjzIsMo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=tk25YExv; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775322631;\n\tbh=TL1x8uQHfXMCS5DAHiJFSwR5ZSFg/H+USQuXqbWXElU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tk25YExvw8065Vz9EAfitUx04X7OsINDwnPs6q3WubHt+0ULf8lwIg1JMVEudvdY1\n\t BmSqdQ6R2OPSmmg5/w1As6rFSbzwL7616L+hDAAAEBKweXaNot/S+VJPGB6GnorJnD\n\t Bd8MpQZG6tAjvQ4z9MYttsJKHtH038/8IvNIpSCyz7WNNyp455IC5gBhppMDjyjjM1\n\t qIcyfqahtkzGeFE+g0HzQcvNSuQ9W0KVlHD102us0OpbGi/h76rnXQIueU/wEeADku\n\t y90yOdX5yaMPDEshLmomivYRo7OiDXOcEtB21s5xDudi8KygyIC9vDSL8cwXYFTAcG\n\t NZpqOPG4QVFUA==","Date":"Sat, 4 Apr 2026 22:40:16 +0530","From":"Manivannan Sadhasivam <mani@kernel.org>","To":"Sherry Sun <sherry.sun@nxp.com>","Cc":"robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,\n\tFrank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de,\n\tfestevam@gmail.com, lpieralisi@kernel.org, kwilczynski@kernel.org,\n\tbhelgaas@google.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de,\n\timx@lists.linux.dev, linux-pci@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH V2 0/8] PCI: imx6: Integrate pwrctrl API and update\n device trees","Message-ID":"<omtn42mopdz7igg7jaqwehd67l6xc77zk7zzqwkufgnsycvadg@5kodhpgfesre>","References":"<20260402101007.208419-1-sherry.sun@nxp.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260402101007.208419-1-sherry.sun@nxp.com>"}}]