[{"id":3669494,"web_url":"http://patchwork.ozlabs.org/comment/3669494/","msgid":"","list_archive_url":null,"date":"2026-03-26T06:43:53","subject":"Re: [PATCH-for-11.0? 0/6] qom: Restrict compat properties API to\n system emulation","submitter":{"id":183,"url":"http://patchwork.ozlabs.org/api/people/183/","name":"Michael Tokarev","email":"mjt@tls.msk.ru"},"content":"25.03.2026 18:17, Philippe Mathieu-Daudé wrote:\n> Remove QDev uses from QOM to help build the guest-agent\n> binary without pulling in QDev methods.\n> \n> After that only util/qsp.c is left (cond/mutex atomics),\n> see this thread:\n> https://lore.kernel.org/qemu-devel/a547c29b-3ab7-42fe-889a-19668bc9d090@tls.msk.ru/\n> \n> Philippe Mathieu-Daudé (6):\n> MAINTAINERS: Separate QDev section from QOM one\n> hw/core: Move compat_props_add() to 'hw/core/boards.h'\n> qom: Declare GlobalProperty structure in 'qom/compat-properties.h'\n> qom: Declare compat properties API in 'qom/compat-properties.h'\n> qom: Restrict compat properties API to system emulation\n> buildsys: Allow building guest-agent on 32-bit hosts\n\nSeries:\n\nReviewed-by: Michael Tokarev \n\nThis definitely helps with qemu-ga issue (a few steps closer to it,\nanyway), makes things better separated and cleaner, and might even\nbe simple enough for 11.0. Though I'm not sure for the latter.\n\nThank you Philippe for this!\n\n/mjt\n\n> MAINTAINERS | 21 +++---\n> configure | 64 +++++++++++++----\n> meson.build | 2 +-\n> include/hw/core/boards.h | 11 +++\n> include/hw/core/qdev-properties.h | 1 +\n> include/hw/core/qdev.h | 27 -------\n> include/qom/compat-properties.h | 40 +++++++++++\n> include/qom/object.h | 8 ---\n> accel/accel-system.c | 1 +\n> backends/hostmem.c | 1 +\n> hw/core/machine.c | 1 +\n> hw/core/qdev-properties.c | 1 +\n> hw/core/qdev.c | 1 +\n> hw/i386/pc_q35.c | 1 +\n> qom/compat-properties.c | 116 ++++++++++++++++++++++++++++++\n> qom/object.c | 102 +-------------------------\n> system/rtc.c | 1 +\n> system/vl.c | 1 +\n> target/i386/sev.c | 1 +\n> ui/vdagent.c | 1 +\n> qom/meson.build | 3 +\n> 21 files changed, 248 insertions(+), 157 deletions(-)\n> create mode 100644 include/qom/compat-properties.h\n> create mode 100644 qom/compat-properties.c\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=tls.msk.ru header.i=@tls.msk.ru header.a=rsa-sha256\n header.s=202602 header.b=IaHwCFnl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhDlj2lmdz1y1G\n\tfor ; Thu, 26 Mar 2026 17:44:33 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5eRl-0006i3-O8; Thu, 26 Mar 2026 02:44:02 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w5eRj-0006hu-Gp\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 02:43:59 -0400","from isrv.corpit.ru ([212.248.84.144])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w5eRh-0005xH-Gt\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 02:43:59 -0400","from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2])\n by isrv.corpit.ru (Postfix) with ESMTP id 606F0197BFA;\n Thu, 26 Mar 2026 09:43:31 +0300 (MSK)","from [192.168.177.130] (mjt.wg.tls.msk.ru [192.168.177.130])\n by tsrv.corpit.ru (Postfix) with ESMTP id 5B4603874A7;\n Thu, 26 Mar 2026 09:43:53 +0300 (MSK)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602;\n t=1774507411; bh=4jPEZvZ6gctyCCaqfdCH9xKCb5073nIAO9Zviwnovdk=;\n h=Date:Subject:To:Cc:References:From:In-Reply-To;\n b=IaHwCFnlUvYmpPnik8hmUaaAg/v7AWzR/fdqlz8fOJpG2OnvwOVaCQOXqTlUVoPfg\n bl2b1mSlkBh20HH3bKvc5o+i6H6QLd0Y6mkqdSWZJdXM26gZ3olyml/8LyVY6txwHX\n IEPB7uTs3NjIECIhVseVi70N8WrW66Sq8iLDzIl4m+XuyHURIMILjW2/gAiDyifUDn\n bykhPBRmGn84ReKt53NhQQr9En32RHNLz573wGRBCI0hAVOjiRyl6lEbNCUURaMTbd\n JvUKFfx6zGufvuwEaJnICtOU2JVPhS2x3PXy9rJTnAvtYg2a0qyrCV8gInXPSjAq4I\n otvCs6HmXHBMA==","Message-ID":"","Date":"Thu, 26 Mar 2026 09:43:53 +0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH-for-11.0? 0/6] qom: Restrict compat properties API to\n system emulation","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Richard Henderson , =?utf-8?q?Daniel_P=2E_Ber?=\n\t=?utf-8?q?rang=C3=A9?= ,\n Paolo Bonzini ,\n =?utf-8?q?Alex_Benn=C3=A9e?= , kvm@vger.kernel.org","References":"<20260325151728.45378-1-philmd@linaro.org>","Content-Language":"en-US, ru-RU","From":"Michael Tokarev ","Autocrypt":"addr=mjt@tls.msk.ru; keydata=\n xsFNBGYpLkcBEACsajkUXU2lngbm6RyZuCljo19q/XjZTMikctzMoJnBGVSmFV66kylUghxs\n HDQQF2YZJbnhSVt/mP6+V7gG6MKR5gYXYxLmypgu2lJdqelrtGf1XtMrobG6kuKFiD8OqV6l\n 2M5iyOZT3ydIFOUX0WB/B9Lz9WcQ6zYO9Ohm92tiWWORCqhAnwZy4ua/nMZW3RgO7bM6GZKt\n /SFIorK9rVqzv40D6KNnSyeWfqf4WN3EvEOozMfWrXbEqA7kvd6ShjJoe1FzCEQ71Fj9dQHL\n DZG+44QXvN650DqEtQ4RW9ozFk3Du9u8lbrXC5cqaCIO4dx4E3zxIddqf6xFfu4Oa5cotCM6\n /4dgxDoF9udvmC36qYta+zuDsnAXrYSrut5RBb0moez/AR8HD/cs/dS360CLMrl67dpmA+XD\n 7KKF+6g0RH46CD4cbj9c2egfoBOc+N5XYyr+6ejzeZNf40yjMZ9SFLrcWp4yQ7cpLsSz08lk\n a0RBKTpNWJdblviPQaLW5gair3tyJR+J1ER1UWRmKErm+Uq0VgLDBDQoFd9eqfJjCwuWZECp\n z2JUO+zBuGoKDzrDIZH2ErdcPx3oSlVC2VYOk6H4cH1CWr9Ri8i91ClivRAyVTbs67ha295B\n y4XnxIVaZU+jJzNgLvrXrkI1fTg4FJSQfN4W5BLCxT4sq8BDtwARAQABzSBNaWNoYWVsIFRv\n a2FyZXYgPG1qdEB0bHMubXNrLnJ1PsLBlAQTAQoAPhYhBJ2L4U4/Kp3XkZko8WGtPZjs3yyO\n BQJmKS5HAhsDBQkSzAMABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEGGtPZjs3yyOZSAP\n /ibilK1gbHqEI2zR2J59Dc0tjtbByVmQ8IMh0SYU3j1jeUoku2UCgdnGKpwvLXtwZINgdl6Q\n cEaDBRX6drHLJFAi/sdgwVgdnDxaWVJO/ZIN/uJI0Tx7+FSAk8CWSa4IWUOzPNmtrDfb4z6v\n G36rppY8bTNKbX6nWFXuv2LXQr7g6+kKnbwv4QFpD+UFF1CrLm3byMq4ikdBXpZx030qBL61\n b7PrfXcBLao0357kWGH6C2Zu4wBnDUJwGi68pI5rzSRAFyAQsE89sjLdR1yFoBH8NiFnAQXP\n LA8Am9FMsC7D/bi/kwKTJdcZvzdGU1HG6tJvXLWC+nqGpJNBzRdDpjqtxNuL76vVd/JbsFMS\n JchLN+01fNQ5FHglvkd6md7vO+ULq+r9An5hMiDoRbYVUOBN8uiYNk+qKbdgSfbhsgPURqHi\n 1bXkgMeMasqWbGMe7iBW/YH2ePfZ6HuKLNQDCkiWZYPQZvyXHvQHjuJJ5+US81tkqM+Q6Snq\n 0L/O/LD0qLlbinHrcx0abg06VXBoYmGICJpf/3hhWQM4f+B/5w4vpl8q0B6Osz01pBUBfYak\n CiYCNHMWWVZkW9ZnY7FWiiPOu8iE1s5oPYqBljk3FNUk04SDKMF5TxL87I2nMBnVnvp0ZAuY\n k9ojiLqlhaKnZ1+zwmwmPmXzFSwlyMczPUMSzsFNBGYpLkcBEAC0mxV2j5M1x7GiXqxNVyWy\n OnlWqJkbkoyMlWFSErf+RUYlC9qVGwUihgsgEhQMg0nJiSISmU3vsNEx5j0T13pTEyWXWBdS\n XtZpNEW1lZ2DptoGg+6unpvxd2wn+dqzJqlpr4AY3vc95q4Za/NptWtSCsyJebZ7DxCCkzET\n tzbbnCjW1souCETrMy+G916w1gJkz4V1jLlRMEEoJHLrr1XKDdJRk/34AqXPKOzILlWRFK6s\n zOWa80/FNQV5cvjc2eN1HsTMFY5hjG3zOZb60WqwTisJwArjQbWKF49NLHp/6MpiSXIxF/FU\n jcVYrEk9sKHN+pERnLqIjHA8023whDWvJide7f1V9lrVcFt0zRIhZOp0IAE86E3stSJhZRhY\n xyIAx4dpDrw7EURLOhu+IXLeEJbtW89tp2Ydm7TVAt5iqBubpHpGTWV7hwPRQX2w2MBq1hCn\n K5Xx79omukJisbLqG5xUCR1RZBUfBlYnArssIZSOpdJ9wWMK+fl5gn54cs+yziUYU3Tgk0fJ\n t0DzQsgfd2JkxOEzJACjJWti2Gh3szmdgdoPEJH1Og7KeqbOu2mVCJm+2PrNlzCybOZuHOV5\n +vSarkb69qg9nU+4ZGX1m+EFLDqVUt1g0SjY6QmM5yjGBA46G3dwTEV0/u5Wh7idNT0mRg8R\n eP/62iTL55AM6QARAQABwsF8BBgBCgAmFiEEnYvhTj8qndeRmSjxYa09mOzfLI4FAmYpLkcC\n GwwFCRLMAwAACgkQYa09mOzfLI53ag/+ITb3WW9iqvbjDueV1ZHwUXYvebUEyQV7BFofaJbJ\n Sr7ek46iYdV4Jdosvq1FW+mzuzrhT+QzadEfYmLKrQV4EK7oYTyQ5hcch55eX00o+hyBHqM2\n RR/B5HGLYsuyQNv7a08dAUmmi9eAktQ29IfJi+2Y+S1okAEkWFxCUs4EE8YinCrVergB/MG5\n S7lN3XxITIaW00faKbqGtNqij3vNxua7UenN8NHNXTkrCgA+65clqYI3MGwpqkPnXIpTLGl+\n wBI5S540sIjhgrmWB0trjtUNxe9QcTGHoHtLeGX9QV5KgzNKoUNZsyqh++CPXHyvcN3OFJXm\n VUNRs/O3/b1capLdrVu+LPd6Zi7KAyWUqByPkK18+kwNUZvGsAt8WuVQF5telJ6TutfO8xqT\n FUzuTAHE+IaRU8DEnBpqv0LJ4wqqQ2MeEtodT1icXQ/5EDtM7OTH231lJCR5JxXOnWPuG6el\n YPkzzso6HT7rlapB5nulYmplJZSZ4RmE1ATZKf+wUPocDu6N10LtBNbwHWTT5NLtxNJAJAvl\n ojis6H1kRWZE/n5buyPY2NYeyWfjjrerOYt3er55n4C1I88RSCTGeejVmXWuo65QD2epvzE6\n 3GgKngeVm7shlp7+d3D3+fAAHTvulQQqV3jOodz+B4yzuZ7WljkNrmrWrH8aI4uA98c=","In-Reply-To":"<20260325151728.45378-1-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru;\n helo=isrv.corpit.ru","X-Spam_score_int":"-19","X-Spam_score":"-2.0","X-Spam_bar":"--","X-Spam_report":"(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]