[{"id":3669269,"web_url":"http://patchwork.ozlabs.org/comment/3669269/","msgid":"<177444470667.74886.6102317039848964711.b4-ty@b4>","list_archive_url":null,"date":"2026-03-25T13:18:26","subject":"Re: (subset) [PATCH v3 00/14] ASoC: tegra: Add error logging for\n probe and callback failures","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Wed, 25 Mar 2026 10:14:23 +0000, Sheetal wrote:\n> ASoC: tegra: Add error logging for probe and callback failures\n> \n> Log errors in probe and runtime error paths across Tegra audio drivers.\n> Use dev_err_probe() in probe paths and dev_err() in runtime callbacks.\n> Skip redundant logging where the underlying API already reports errors.\n> \n> Changes in v3:\n> - Split single patch into per-driver patch series for easier review\n> and incremental merging.\n> - Drop dev_err() from tegra_ahub_put_value_enum() since the error path\n> is userspace-triggerable and would allow log spamming.\n> - Drop dev_err() from tegra210_mixer_set_audio_cif() since the driver\n> advertises S8 format support but this function doesn't handle it,\n> creating a userspace-triggerable log spam path.\n> \n> [...]\n\nApplied to\n\n https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1\n\nThanks!\n\n[01/14] ASoC: tegra: Use dev_err_probe() in tegra186_asrc probe\n https://git.kernel.org/broonie/sound/c/884f3101d1ed\n[02/14] ASoC: tegra: Use dev_err_probe() in tegra186_dspk probe\n https://git.kernel.org/broonie/sound/c/6205ca05227f\n[04/14] ASoC: tegra: Add error logging in tegra210_adx driver\n https://git.kernel.org/broonie/sound/c/50e51b84a4b3\n[05/14] ASoC: tegra: Use dev_err_probe() in tegra210_ahub probe\n https://git.kernel.org/broonie/sound/c/802d0d6c25b3\n[06/14] ASoC: tegra: Add error logging in tegra210_amx driver\n https://git.kernel.org/broonie/sound/c/d310c08db2d8\n[07/14] ASoC: tegra: Use dev_err_probe() in tegra210_dmic probe\n https://git.kernel.org/broonie/sound/c/ca069c3403ec\n[08/14] ASoC: tegra: Add error logging in tegra210_i2s driver\n https://git.kernel.org/broonie/sound/c/67b7bcdd9798\n[10/14] ASoC: tegra: Use dev_err_probe() in tegra210_mixer probe\n https://git.kernel.org/broonie/sound/c/3d027d4b93b9\n[11/14] ASoC: tegra: Use dev_err_probe() in tegra210_mvc probe\n https://git.kernel.org/broonie/sound/c/f2067c1dba07\n[12/14] ASoC: tegra: Use dev_err_probe() in tegra210_sfc probe\n https://git.kernel.org/broonie/sound/c/856ffd8f4aae\n[13/14] ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe\n https://git.kernel.org/broonie/sound/c/fa11e1cb2b77\n[14/14] ASoC: tegra: Use dev_err_probe() in tegra_audio_graph_card probe\n https://git.kernel.org/broonie/sound/c/f7d9eb0291ef\n\nAll being well this means that it will be integrated into the linux-next\ntree (usually sometime in the next 24 hours) and sent to Linus during\nthe next merge window (or sooner if it is a bug fix), however if\nproblems are discovered then the patch may be dropped or reverted.\n\nYou may get further e-mails resulting from automated or manual testing\nand review of the tree, please engage with people reporting problems and\nsend followup patches addressing any issues that are reported if needed.\n\nIf any updates are required or you are submitting further changes they\nshould be sent as incremental updates against current git, existing\npatches will not be replaced.\n\nPlease add any relevant lists and maintainers to the CCs when replying\nto this mail.\n\nThanks,\nMark","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=mHB06E4o;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13242-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"mHB06E4o\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgwV75JLYz1xy3\n\tfor ; Thu, 26 Mar 2026 05:31:43 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id B173730628CB\n\tfor ; Wed, 25 Mar 2026 18:31:09 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7E63733A711;\n\tWed, 25 Mar 2026 18:31:09 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FAE9334C28;\n\tWed, 25 Mar 2026 18:31:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id CB380C2BCB0;\n\tWed, 25 Mar 2026 18:31:06 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774463469; cv=none;\n b=fp/BuO/GVo54SwLoSDBhgJcT4C3p+705xe3VMDoYPmGi5bHhQ1Kxpn+BkJ6PKy900ghTzExBwffZSyUvpkV78uq4nNKbscUSolPEFZhvaab+wMMz6ukpDxzfoWpHbHSoQIiHyaXjxLuryzeZpvKmJLN9n2KNn6ibsKJb30pATdM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774463469; c=relaxed/simple;\n\tbh=DQbbAOyhxw+23J3KBAlGhHaExbNzeCQDdun5Q8A4fyo=;\n\th=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date:\n\t MIME-Version:Content-Type;\n b=busTOY1p4g5soHawym0hEig8d3hUZM8KJ6qEi2JqFv/cZImugPgiKnWDg3MdE3oK9PuG5kJ+7JW080bzQ6Z4grmySCJBWOYjeIE18FfLWKwztBAZ8DeRHU+bCroxQhm4zc81I+aiWlNs2iKRzWEDqlZ9QhM9TG3inzN3yhBvvAM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=mHB06E4o; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774463468;\n\tbh=DQbbAOyhxw+23J3KBAlGhHaExbNzeCQDdun5Q8A4fyo=;\n\th=From:To:Cc:In-Reply-To:References:Subject:Date:From;\n\tb=mHB06E4oOSK/xs8kR0+aU9mXpI4v4qU5bN9TBZKD8VStKkHDtM/bOorpESsp6L2jw\n\t XJtMFBOQqBCz4eJy83r/VVnnHyY2PS4JubFprmmCZTeZI7sIBVqI+pAqxGoYhanEsR\n\t BbejA/Nw8/d1iU+B65WhSQ7djFC9WFxZEthkTUnNvEmkxDxw+BdX5+6HxrT+MCudwd\n\t MH2AQYebBbJsFfu58W7LOO9osq2w1zwv4GkXa9FyZ/7LCQx0B3HtteD9tgOGg1IoSq\n\t 3ZQh0V94l2t7WyXxFcuK8/9BT2uwCSOrSZjMTll0hoELPZCnFTJ7pldCBZiZuruh6T\n\t k154c3xjstj/g==","From":"Mark Brown ","To":"Liam Girdwood ,\n Thierry Reding ,\n Jonathan Hunter , Sheetal ","Cc":"Jaroslav Kysela , Takashi Iwai ,\n Mohan Kumar ,\n Kuninori Morimoto ,\n linux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,\n linux-kernel@vger.kernel.org","In-Reply-To":"<20260325101437.3059693-1-sheetal@nvidia.com>","References":"<20260325101437.3059693-1-sheetal@nvidia.com>","Subject":"Re: (subset) [PATCH v3 00/14] ASoC: tegra: Add error logging for\n probe and callback failures","Message-Id":"<177444470667.74886.6102317039848964711.b4-ty@b4>","Date":"Wed, 25 Mar 2026 13:18:26 +0000","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Mailer":"b4 0.16-dev-6cc06","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3222; i=broonie@kernel.org;\n h=from:subject:message-id; bh=DQbbAOyhxw+23J3KBAlGhHaExbNzeCQDdun5Q8A4fyo=;\n b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBpxCnphKVscIT0b0Nxf+oCEKeZZnpyb20MhqiiL\n pT5Z6x/02eJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCacQp6QAKCRAk1otyXVSH\n 0NJ1B/9jJ7m4v575HwEEYrieL6J0R8S6E8Xz7L5HDeIwoomDQiJ+KToDrECc+wZhPsNeoUrCtem\n Hq1ye+qlCPH9SXbaX9zfPKY0ihzGPxryuRebb3uIlt51+ZnnonyojoRn7GyY1TehmUXca14P9A8\n I3LuI8o9HlenF3l3/nPJwfT1TSjRIwBIGy9/YzJnA8HfuW2h2ySRNyQdadw2V/OGYaR+wd0RfHe\n N5cINdrjsF8yihO8YcE++xhR5sumHantO5F/wf86Uw5Z5iBmYy//bAL7jJz8PK6eeHUuMXAcO/W\n /Hz1Y7fBsOKjuj0dqI7XsWatwXYm9FaYUgrnMUuIfyKqgWNy","X-Developer-Key":"i=broonie@kernel.org; a=openpgp;\n fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB"}}]