[{"id":3669373,"web_url":"http://patchwork.ozlabs.org/comment/3669373/","msgid":"<acRo180cptltvk9Y@baldur>","list_archive_url":null,"date":"2026-03-25T22:59:48","subject":"Re: [PATCH v3 0/2] Introduce TLMM driver for Qualcomm IPQ5210 SoC","submitter":{"id":84725,"url":"http://patchwork.ozlabs.org/api/people/84725/","name":"Bjorn Andersson","email":"andersson@kernel.org"},"content":"On Wed, Mar 25, 2026 at 01:05:14PM +0530, Kathiravan Thirumoorthy wrote:\n> The IPQ5210 is Qualcomm's SoC for Routers, Gateways and Access Points.\n> Add the pinctrl support for the same.\n> \n> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>\n\nReviewed-by: Bjorn Andersson <andersson@kernel.org>\n\nRegards,\nBjorn\n\n> ---\n> Changes in v3:\n> - Grouped the QUP SE pins instead of mentioning by function wise\n> - Splitted the PWM functions which I messed up in V2\n> - Audio primary and secondary mclk function names are expanded to avoid the\n>   confusion\n> - Dropped the R-b tags due to the above changes\n> - Link to v2: https://lore.kernel.org/r/20260318-ipq5210_tlmm-v2-0-182d47b3d540@oss.qualcomm.com\n> \n> Changes in V2:\n> - Split the TLMM changes into separate series\n> - Picked up the R-b tags\n> - Grouped the led and pwm pins for better readability and usability\n> - Link to v1:\n>   https://lore.kernel.org/linux-arm-msm/20260311-ipq5210_boot_to_shell-v1-0-fe857d68d698@oss.qualcomm.com/\n> \n> ---\n> Kathiravan Thirumoorthy (2):\n>       dt-bindings: pinctrl: qcom: add IPQ5210 pinctrl\n>       pinctrl: qcom: Introduce IPQ5210 TLMM driver\n> \n>  .../bindings/pinctrl/qcom,ipq5210-tlmm.yaml        | 123 +++\n>  drivers/pinctrl/qcom/Kconfig.msm                   |   8 +\n>  drivers/pinctrl/qcom/Makefile                      |   1 +\n>  drivers/pinctrl/qcom/pinctrl-ipq5210.c             | 898 +++++++++++++++++++++\n>  4 files changed, 1030 insertions(+)\n> ---\n> base-commit: 85964cdcad0fac9a0eb7b87a0f9d88cc074b854c\n> change-id: 20260317-ipq5210_tlmm-df221be105b5\n> \n> Best regards,\n> --  \n> Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>\n>","headers":{"Return-Path":"\n <linux-gpio+bounces-34174-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=uEayiGdL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34174-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"uEayiGdL\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fh2Rp28Znz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 10:00:06 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 0F8C2303A5D3\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 22:59:54 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CC7D238F635;\n\tWed, 25 Mar 2026 22:59:52 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D9E87DA66;\n\tWed, 25 Mar 2026 22:59:52 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 6FFA7C2BC9E;\n\tWed, 25 Mar 2026 22:59:51 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774479592; cv=none;\n b=cuBAg39UahuZ0StlnDXiFfJN+AzXr/5twwUk65FvgYBagZJouc1kZ3nDqsg+TMdpZ2UZNvyb23FXevwl+/KK8tPNz6/3Iqt1bIhsq1n4uIrrdrg3hV7RHzj7Wlu0ZBqb6SRH5pO4RZzHw2VHrxxPKWAsInL2YHZbDH9Ck1IgS04=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774479592; c=relaxed/simple;\n\tbh=tg6uS2NQ9KcwGis4vKx40sO+FrPBh1NN362QU07kJyk=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=P8UAxAg0nX6OGoZ9O29f7dvCZqq39gpmT6FLAoEHMrg5YQ67qoOB8fTsPOPOCePZY1uv90mcgDxMc1ESFKQXtm/+48gVAn8GGaN1DMwyCHkpQ08ambQzNX31ugz7WAkA+FVJ3WmJmq/HqwWlRsSaLMNE4mQoO17gWSPx0IZeq+c=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=uEayiGdL; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774479592;\n\tbh=tg6uS2NQ9KcwGis4vKx40sO+FrPBh1NN362QU07kJyk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uEayiGdL5cY00UsjxRrPaNr1vbsLWamrI2WigZ6KifJ+jJEMy2qQCDjMreuYqjGQk\n\t tS9rosklZxxmVIIRfzhZILYoZZZ/AhyY1xWu3R2sXvah959mtUDE3aePA1+cj5r3wB\n\t Vdpnhx6ctMBJ1kt9DqMEVghPz8D9KTyZvRJaK8oQrHot9bDM0FAFMsEuQcfocaFbwj\n\t uTZU9634wBe3dxfGXQ2W9ZOb5oZ6c+MrQM5BJBLT8+d/D9ka4Y9nzN3d1H8x+KpoI4\n\t KNSbYU101qgXyvilhJe/6MGI9as7qHRod/HKcDyaufanwQ2STwC36pGGxuDifX8Z5Q\n\t a04Vtc6xYlleQ==","Date":"Wed, 25 Mar 2026 17:59:48 -0500","From":"Bjorn Andersson <andersson@kernel.org>","To":"Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>","Cc":"Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,\n\tKrzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,\n\tlinux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,\n devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v3 0/2] Introduce TLMM driver for Qualcomm IPQ5210 SoC","Message-ID":"<acRo180cptltvk9Y@baldur>","References":"<20260325-ipq5210_tlmm-v3-0-3a4b9bb6b1fc@oss.qualcomm.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260325-ipq5210_tlmm-v3-0-3a4b9bb6b1fc@oss.qualcomm.com>"}}]