[{"id":3670554,"web_url":"http://patchwork.ozlabs.org/comment/3670554/","msgid":"<20260327204623.GF502704@bill-the-cat>","list_archive_url":null,"date":"2026-03-27T20:46:23","subject":"Re: [PATCH 0/6] test: Refactor FIT test for clarity and extensibility","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Tue, Mar 24, 2026 at 01:43:15PM -0600, Simon Glass wrote:\n\n> This series reworks the FIT test (test_fit.py) to make it easier to\n> maintain and extend. It avoids unnecessary U-Boot restarts, renames the\n> main test for easier selection, adds a missing-kernel check, fixes\n> Python warnings, converts the test to use a class, and splits into\n> separate test functions.\n> \n> \n> Simon Glass (6):\n> test: fit: Avoid restarting U-Boot\n> test: Rename test_fit() to test_fit_base()\n> test: Add a check for a missing kernel\n> test: Update fit test to fix a few Python warnings\n> test: Convert FIT test to use a class\n> test: Add fsetup fixture and prepare helper for FIT test\n> \n> test/py/tests/test_fit.py | 403 ++++++++++++++++++++------------------\n> 1 file changed, 216 insertions(+), 187 deletions(-)\n\nThis overall seems fine. Now that we've fixed the problem with\nreadthedocs and pytest, the next follow-up should include adding\ndoc/develop/pytest/test_fit.rst (which based on all the others should be\nminimal) and any needed changes / corrections to the docstrings / etc so\nthat the output renders well.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=eqvOf0d9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"eqvOf0d9\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjCNv2DMPz1y1P\n\tfor ; Sat, 28 Mar 2026 07:46:39 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C67E583C5E;\n\tFri, 27 Mar 2026 21:46:30 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id B45FC83DA7; Fri, 27 Mar 2026 21:46:29 +0100 (CET)","from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com\n [IPv6:2607:f8b0:4864:20::c33])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8F7688394E\n for ; Fri, 27 Mar 2026 21:46:27 +0100 (CET)","by mail-oo1-xc33.google.com with SMTP id\n 006d021491bc7-67c1b8b1f96so1567041eaf.2\n for ; Fri, 27 Mar 2026 13:46:27 -0700 (PDT)","from bill-the-cat (fixed-189-203-97-235.totalplay.net.\n [189.203.97.235]) by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-67e230a7f7csm248338eaf.7.2026.03.27.13.46.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2026 13:46:25 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1774644386; x=1775249186; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=XKX4LWO6Mh3hHiDt7mj4gEgl5DeR/XNl6vtkKF4r9BQ=;\n b=eqvOf0d9eDqv6n+FFtsUwnm8LMpb8HFvnjaqX1roB1C2d2+1pdtCus4tQLTjJE6sy+\n ASgSKThfJPx3HCGLu8vHtgEleK1fxnwvc/2zwujYlmVaY1FFIgQabkIavWDVu7BLyH4j\n 2vBP+HxI9iBrE2uHJjJswnVrC0UxVgl6n57ok=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774644386; x=1775249186;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=XKX4LWO6Mh3hHiDt7mj4gEgl5DeR/XNl6vtkKF4r9BQ=;\n b=oORBTm4P5k1oM+tApNca/hYXuJkvYt2Ur/XK0RuRKa9rvoQJNPki0g/xK58trxbw1i\n gGv1VrfBtRi3r3Kz2UAkNFZPjKM24dKXQzcbw1DgCP9i3yarrIlxwTBofD2mA7ntustE\n zDCccYfaK9OSgQRwdSFUBta/tm1Ad0hXiG2t/sbO00JZ8uqTCbCwFhf0yOmUvnJEozX+\n pYxll2JLuPKWLJK7UqlxsvCSrFiGKtTLsUd671oyeg5W+AhtzbviJ3kj+MuxaBTG6lMn\n KBs7kpSyFuT9MrLGpiTAz9QEoOOxPvtDNwiuC/GU71RWvOj2K/m4A8N6mhmXxa4zHKWL\n 8PHw==","X-Gm-Message-State":"AOJu0Yz1YtNtDDpOK3S265ed1s5HON1cRb7VxABIKDD8m0gEQ9XHjN90\n M9EjM0EWPpexMe7GCgwCgjVGXLrnqGWEFbnMJTV0USkbcIE+DFpBq5VY53arjessEkw=","X-Gm-Gg":"ATEYQzwFhIR7pWEr371p9wH69z6ojWmu1s88VTGiNRMqTypn6yW4yGRdwrvWLQ5xz3t\n G4+W6TPZ4HTOmNkuL74Noq06eus0M5hWmWpZ3Bk2vKYMnFH8vzZwGmthowD38SGSW/uX4SehEuo\n HeUa/2fg3g+Zb8VJ3w1D1OR9a2fLRUJNQj9DM6CA2Hsi2xePQV04MaFuo4M3LkRWw4ch5Sn/fkU\n H38M5QNhaU7LK5Wv3/LtZUkeBWKFYaVzGXzrH7BaYWj3K82AaJAeolnsERsw1vD1GDY278thwOh\n Aj5byM6c359YJ74rY1vmtrnxGifuCfgTv1hSb+U8RNNcmERjyFFR69jkmoiaRxGMeWMzLpWC652\n UBIgZdxzUC5PMUoNrY53txuV+04itJEOPUrydwbuxKfOGvr8aiXANNRfTV82pEg9RD+SkDjcGHU\n pPPc8GlbzZpfx2BTuN+GJYqAGPWqrIXGqH01tsxewUhQqJ8oqHl3CGyRZ0zPcrKbJdHc0C36lLP\n 4Es7FmRkkInlMxn5F355Eumi3O2jh3DnPZqtzHvVpHRnC3l","X-Received":"by 2002:a05:6820:2082:b0:67d:e552:922e with SMTP id\n 006d021491bc7-67e187059bcmr2205495eaf.35.1774644386264;\n Fri, 27 Mar 2026 13:46:26 -0700 (PDT)","Date":"Fri, 27 Mar 2026 14:46:23 -0600","From":"Tom Rini ","To":"Simon Glass ","Cc":"u-boot@lists.denx.de","Subject":"Re: [PATCH 0/6] test: Refactor FIT test for clarity and extensibility","Message-ID":"<20260327204623.GF502704@bill-the-cat>","References":"<20260324194323.2335679-1-sjg@chromium.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"zqdQVPiwziJShRaY\"","Content-Disposition":"inline","In-Reply-To":"<20260324194323.2335679-1-sjg@chromium.org>","X-Clacks-Overhead":"GNU Terry Pratchett","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]