[{"id":3669462,"web_url":"http://patchwork.ozlabs.org/comment/3669462/","msgid":"<478e7388-f91e-4e26-bc47-eef4ec5b1c1f@roeck-us.net>","list_archive_url":null,"date":"2026-03-26T04:56:55","subject":"Re: [PATCH v4 0/5] Add support for AAEON SRG-IMX8P MCU","submitter":{"id":21889,"url":"http://patchwork.ozlabs.org/api/people/21889/","name":"Guenter Roeck","email":"linux@roeck-us.net"},"content":"Hi,\n\nOn 3/24/26 12:24, Thomas Perrot (Schneider Electric) wrote:\n> This patch series introduces support for the AAEON SRG-IMX8P embedded\n> controller (MCU). The MCU is connected via I2C and provides GPIO and\n> watchdog functionality for the SRG-IMX8P board.\n> \n> The series includes:\n> - Device tree binding for the MFD driver\n> - MFD driver that serves as the core driver for the MCU\n> - GPIO driver implementing the GPIO functionality\n> - Watchdog driver for system monitoring\n> - MAINTAINERS entry for the new drivers\n> \n> The drivers follow the standard Linux kernel subsystem patterns, with\n> the MFD driver registering the sub-devices (GPIO and watchdog) which\n> are then handled by their respective subsystem drivers.\n> \n> Signed-off-by: Thomas Perrot (Schneider Electric) \n\nSashiko reports a number of issues with this series.\n\nhttps://sashiko.dev/#/patchset/20260324-dev-b4-aaeon-mcu-driver-v4-0-afb011df4794%40bootlin.com\n\nI can not comment on the non-watchdog concerns, even though the ones I looked at\nseem to be valid. However, please address the watchdog subsystem related comments.\nIf functionality such as CONFIG_WATCHDOG_NOWAYOUT is explicitly not supported,\nplease add the rationale as comment into the driver.\n\nThanks,\nGuenter","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=hvadGilw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34185-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"hvadGilw\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=74.125.82.179","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=roeck-us.net","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhBMm2fvHz1y1x\n\tfor ; Thu, 26 Mar 2026 15:57:08 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C0295303660B\n\tfor ; Thu, 26 Mar 2026 04:57:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9B46632AAA0;\n\tThu, 26 Mar 2026 04:57:01 +0000 (UTC)","from mail-dy1-f179.google.com (mail-dy1-f179.google.com\n [74.125.82.179])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 37F742D7DEE\n\tfor ; Thu, 26 Mar 2026 04:56:59 +0000 (UTC)","by mail-dy1-f179.google.com with SMTP id\n 5a478bee46e88-2c0ecaae7dfso1010951eec.1\n for ;\n Wed, 25 Mar 2026 21:56:59 -0700 (PDT)","from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5?\n ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2c16edc0458sm1635295eec.21.2026.03.25.21.56.56\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 25 Mar 2026 21:56:57 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774501020; cv=none;\n b=DK95HqTHpVRtVoLCFmqXRxnvt9Tbrtm1yYaQXGhJXGNk0DmeoPNR9SyBI4AXB6Z2fnx/397LgsDDvCpnKZitKFL++iIsg8uGyZOFhij4B899rEXLu+PaVhwIuXQhnmA1jTU3K5lAURrMrg/U6ZNqIo4jygXDPcGULLdGgFxyxk4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774501020; c=relaxed/simple;\n\tbh=3liW3TTczHbCWW6xyzTaD5p7Ee26sA2HpZbUQqz+dhc=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=MOrpQH8hkGqWosrufjkmYcS+bUWi7SUMn5AgZR5OTfIdaiPUH0RqRixRLAYBqW31hzAwaXXPX1vVX9MdaWHMe7fjeH3vi9VsQD7vTFlGC40AmZx63LCD7ENP7DeCymOK79kd31IZ0GHNwu5t3i/ZxEriasnHkOFiek3bb0yYc0o=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=roeck-us.net;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=hvadGilw; arc=none smtp.client-ip=74.125.82.179","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774501018; x=1775105818;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to;\n bh=mdrREemxYfCx5YD4EhfvcYVTWQ7/gTjv0x5FHQxyZYY=;\n b=hvadGilwxeAZ8KncV/Kxc2pAyJEp9aKdsvxL/2LA8/z4olz+Zhl68DZ2DIKf14zWdo\n 1zFJBV5QADndhKRi+3u2eD2ms5MOth2sb+fgWF6LZKtsPKut1U+GB/QyfuS9ap8FIn4u\n 1IOZULtRtfOdYD2sm2TpCleshV1W4lxCjkDrfNvwgQ90AzEKV+EV/kBnpckT4bO+fpA5\n EO/B0O5o+9JwOpo8C6KdOP0/ynlh9Ze0tJXHJ0PKCEvq4AJiEygAXSYICzvt4wnP+Y+n\n fee9WwPcHW1cDLbeaPqLNrbCALkstCJGEkaFrotIGzk6SNPtyHGedsVIk/pqlEwMIUk9\n zcHQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774501018; x=1775105818;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=mdrREemxYfCx5YD4EhfvcYVTWQ7/gTjv0x5FHQxyZYY=;\n b=Mlg3jqg2vRABYxUEWXss+hkuwmbK+6sxJsE/Mk5Ju12OuzovgmIyaRApTuqRyXaTdI\n Vn8QhPxlwX4w8bVo+WU/c17LTkHN4CZJByb5SksVDxkMsSHiGWOL7igj+PcidxhFT9+k\n TmZlnHltFuTdkYL1MNSocEA6V7LCT00usP+ePNVyFZ/cLS02pupId2+9FXTdehukwbiS\n qVQWZzA5m4w8HG2g5oWCfNUaC4SohoITkEtq3owE8j74uvQ0SJMWeTlFw5/m/gHlFNWT\n BfJ4dArtgcW4HMtfGadNumpLlhaIM4w0zjUQv1meQuXSbtKx2kY46erKPrBoesSfgRew\n iwMg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWtlKoFmDbSuLj1G8P2ZSALowrbbiw/ydEmGUHu8mtUzUVFInSmet6Kow6c5SVRmpzBnTLGTA2lmx4A@vger.kernel.org","X-Gm-Message-State":"AOJu0Yy116Q/6VbJOoF9hlN3nO91VyRfHCWuuuSnAJ+4RzxSv6feFVWj\n\tT/cIPOtl+gdoHiYVaLCW5Nu5j0eh+Uxo/if8zTC8R1eWvX0HK6BlEC5t","X-Gm-Gg":"ATEYQzz47YVdGI93AnBYdLHNYskG6PWtm05WDtOpwTFuQiGSAiKKBGEhLiahPnjULXE\n\tlcj8eQ0nsx0iEaCn3dE004DTm7UIb5f6rM4RH5fncVpQEQd9qwW7YlqJoB1vPpmiMAzjWQ6RSDQ\n\tHdW/wXgdc77OG7lWZI8AgYyyLrSDxhYZ07DTjj0tcNokYoGXbnnXSGF2GGreS0T9nz9Pgy5igtH\n\tpFlapGbcvSQxs98/XHxpRMqiHC/q1gmFS8NmIRokGp5KgO4+b4tUOxzVlBRsNSgtUatJDklrxLU\n\th++E+j7a3rJdG2ADTZ9y//D6R+k94khBtVRf7eqTq1Hbo2vwSu9yYbQPJEWR91GRFzmkc08qX2d\n\tTp1BxD2qFCARiW8AFvoz051pWT9MBQwU5I1cqewPK/W90h3rHVGbHfL9kaNEWUDm+b6wIJZp3Br\n\tx+12HtS340rQw9YLnFETXpCoTiskmwcjvLAIjZuYyrqe6QdtfYB6kYIw0rQYB50ZeszRMFtAoY","X-Received":"by 2002:a05:7300:430e:b0:2be:9989:331e with SMTP id\n 5a478bee46e88-2c15d2805admr3224190eec.2.1774501018257;\n Wed, 25 Mar 2026 21:56:58 -0700 (PDT)","Sender":"Guenter Roeck ","Message-ID":"<478e7388-f91e-4e26-bc47-eef4ec5b1c1f@roeck-us.net>","Date":"Wed, 25 Mar 2026 21:56:55 -0700","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 0/5] Add support for AAEON SRG-IMX8P MCU","To":"\"Thomas Perrot (Schneider Electric)\" ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley , Linus Walleij ,\n Bartosz Golaszewski , Shawn Guo ,\n Sascha Hauer ,\n Pengutronix Kernel Team ,\n Fabio Estevam ,\n =?utf-8?b?SsOpcsOpbWllIERhdXRoZXJpYmVz?= ,\n Wim Van Sebroeck , Lee Jones ","Cc":"devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-gpio@vger.kernel.org, imx@lists.linux.dev,\n linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org,\n Thomas Petazzoni ,\n Miquel Raynal ,\n Krzysztof Kozlowski ,\n Conor Dooley ,\n Bartosz Golaszewski ","References":"<20260324-dev-b4-aaeon-mcu-driver-v4-0-afb011df4794@bootlin.com>","Content-Language":"en-US","From":"Guenter Roeck ","Autocrypt":"addr=linux@roeck-us.net; keydata=\n xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN\n RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7\n nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl\n 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh\n gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX\n IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC\n kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0\n VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s\n jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk\n BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv\n ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL\n CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA\n oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg\n VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v\n 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj\n onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7\n DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs\n rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT\n WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65\n qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5\n 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz\n qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq\n 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7\n pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM\n J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi\n pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz\n 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w\n ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF\n I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT\n nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY\n HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX\n JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9\n H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj\n njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u\n dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy\n j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y\n scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw\n zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B\n RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ\n F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn\n FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ\n np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE=","In-Reply-To":"<20260324-dev-b4-aaeon-mcu-driver-v4-0-afb011df4794@bootlin.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit"}}]