[{"id":3669548,"web_url":"http://patchwork.ozlabs.org/comment/3669548/","msgid":"","list_archive_url":null,"date":"2026-03-26T08:54:37","subject":"Re: [PATCH v4 0/2] qcom: EFI PSCI runtime reset handling and config\n update","submitter":{"id":90400,"url":"http://patchwork.ozlabs.org/api/people/90400/","name":"Sumit Garg","email":"sumit.garg@kernel.org"},"content":"On Tue, Mar 24, 2026 at 11:29:11PM +0530, Aswin Murugan wrote:\n> From: Aswin Murugan \n> \n> With CONFIG_PSCI_RESET enabled, EFI runtime resets always use PSCI, but since\n> it cannot pass the arguments needed for special reboot modes, requests like\n> bootloader or EDL fall back to a normal reboot.\n> \n> This version updates the earlier series that introduced configuration control\n> over EFI PSCI-based runtime reset handling.\n> \n> During review [1], it was pointed out that modifying only the Kconfig option\n> was incomplete, as the EFI runtime configuration table in\n> lib/efi_loader/efi_runtime.c also needs to be updated to reflect whether\n> runtime reset support is enabled.\n> \n> Additionally, the reviewer suggested that instead of introducing a new\n> EFI_PSCI_RESET_RUNTIME option, we should reuse the existing\n> EFI_HAVE_RUNTIME_RESET knob, making it user-configurable so platforms can\n> opt out when the kernel must retain full control of specialized reboot\n> modes.\n> \n> This version implements that feedback:\n> \n> 1. EFI_HAVE_RUNTIME_RESET is now a proper Kconfig configurable option\n> This allows individual platforms, such as Qualcomm boards, to \n> explicitly disable U-Boot’s EFI runtime reset callbacks when required.\n> \n> 2. The Qualcomm defconfig disables EFI_HAVE_RUNTIME_RESET so that the\n> kernel can manage advanced reboot flows (EDL, bootloader entry, etc.)\n> without U-Boot overriding those reset modes through EFI runtime\n> services.\n> \n> 3. The EFI runtime table is updated accordingly to conditionally\n> advertise reset support only when EFI_HAVE_RUNTIME_RESET is enabled.\n> \n> These changes maintain existing default behavior for platforms that rely\n> on U-Boot’s EFI reset services, while enabling platforms with more\n> complex reboot semantics to opt out cleanly.\n> \n> [1] https://lore.kernel.org/all/CAC_iWjKZXsE86J_wJ=JTE0TGL=MqGm8YRYsq4BrkU2ba3me6OQ@mail.gmail.com/\n> \n> Signed-off-by: Aswin Murugan \n> ---\n> Changes in v4:\n> - Made EFI_HAVE_RUNTIME_RESET user configurable & used it to disable U-Boot’s EFI runtime reset\n> for qualcomm platforms\n> - Link to v3: https://lore.kernel.org/all/20260213110527.1254098-1-aswin.murugan@oss.qualcomm.com/\n\nFor the series:\n\nReviewed-by: Sumit Garg \n\n-Sumit\n\n> \n> Changes in v3:\n> - Updated the commit message\n> - Changed 'CONFIG_EFI_PSCI_RESET_RUNTIME=n' to '# CONFIG_EFI_PSCI_RESET_RUNTIME is not set'\n> - Link to v2: https://lore.kernel.org/all/20260114111624.2321852-1-aswin.murugan@oss.qualcomm.com/\n> \n> Changes in v2:\n> - As per review comments made default y for EFI_PSCI_RESET_RUNTIME config\n> - Disabled the EFI_PSCI_RESET_RUNTIME config for qualcomm platforms\n> - Link to v1: https://lore.kernel.org/all/20260108105146.1285450-1-aswin.murugan@oss.qualcomm.com/\n> ---\n> Aswin Murugan (2):\n> efi_loader: make EFI_HAVE_RUNTIME_RESET a user-selectable option\n> qcom_defconfig: Disable EFI_HAVE_RUNTIME_RESET in qcom_defconfig\n> \n> configs/qcom_defconfig | 1 +\n> lib/efi_loader/Kconfig | 3 +--\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=f9YgNEKM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"f9YgNEKM\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sumit.garg@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhHf638dnz1y1x\n\tfor ; Thu, 26 Mar 2026 19:54:54 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B0B4883CF5;\n\tThu, 26 Mar 2026 09:54:50 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 9062583DA6; Thu, 26 Mar 2026 09:54:49 +0100 (CET)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D46ED838BB\n for ; Thu, 26 Mar 2026 09:54:46 +0100 (CET)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 9F24360103;\n Thu, 26 Mar 2026 08:54:45 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 99244C116C6;\n Thu, 26 Mar 2026 08:54:40 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1774515285;\n bh=LLqV3qnBBic/TBzV38CcHr+cD5UWFNZlePgfL8ioyF0=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=f9YgNEKM7hh3tbtp4yV96ODTlnYPkzp+uhevntZjecseaFoiUJPAQ8emtjtuTtkyY\n TQf2A20GhIGIf/3csWIKV82j3WT1T1bLfDrUp4PSB0z6p4mZleY3CHGFLkRHLQV5d3\n CfeLvyB+87NrS3/wct4MhNeMXDGTfzjuWs6wqnCnHgI9VY73wQpqIc0O2Gy+Ve/lGN\n 4iZ6PnNe1ySWOOVBD26pH9JwX9m2ScsI4m+I8aftkZZ1KkgBgVk2hvRfmpRzu13yUC\n cXu6U5l16pswwUJbh8EeJXnsjvTVNysFQ6XZCToSWLBx4hcfHbEy1UpD6clzSQbaRm\n EtlT/n16OOFCg==","Date":"Thu, 26 Mar 2026 14:24:37 +0530","From":"Sumit Garg ","To":"Aswin Murugan ","Cc":"casey.connolly@linaro.org, neil.armstrong@linaro.org,\n trini@konsulko.com, xypron.glpk@gmx.de, ilias.apalodimas@linaro.org,\n marek.vasut+renesas@mailbox.org, michal.simek@amd.com,\n sjg@chromium.org, mkorpershoek@kernel.org, jan.kiszka@siemens.com,\n paul.liu@linaro.org, j-humphreys@ti.com, u-boot-qcom@groups.io,\n u-boot@lists.denx.de","Subject":"Re: [PATCH v4 0/2] qcom: EFI PSCI runtime reset handling and config\n update","Message-ID":"","References":"<20260324175913.92858-1-aswinm@qti.qualcomm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260324175913.92858-1-aswinm@qti.qualcomm.com>","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]