[{"id":3668805,"web_url":"http://patchwork.ozlabs.org/comment/3668805/","msgid":"","list_archive_url":null,"date":"2026-03-25T03:58:54","subject":"Re: [PATCH v5 0/7] Add RISC-V big-endian target support","submitter":{"id":92265,"url":"http://patchwork.ozlabs.org/api/people/92265/","name":"Chao Liu","email":"chao.liu.zevorn@gmail.com"},"content":"Hi Djordje,\n\nOn Tue, Mar 24, 2026 at 04:40:14PM +0000, Djordje Todorovic wrote:\n> Adding functional test case for riscv big-endian.\n> \nThanks for the v5 and for adding the functional test\nthat Philippe requested. The runtime big-endian approach\nis the right direction.\n\nHowever, it looks like the series was developed on top\nof Philippe's \"[PATCH-for-11.1] target/riscv: Forbid to\nuse legacy native endianness API\" prep series, which\nhasn't been merged yet. This causes two build-breaking\nissues and apply failures on both master and\nriscv-to-apply.next.\n\nFor v6, I'd suggest either:\na) Explicitly declare \"Based-on:\" Philippe's prep\n series, or\n\nb) Include the prerequisite changes (MSTATUS defines,\n op_helper.c cleanup, MO_TE->MO_LE) in this series.\n\nThanks,\nChao\n> Djordje Todorovic (7):\n> target/riscv: Add big-endian CPU property\n> target/riscv: Set endianness MSTATUS bits at CPU reset\n> target/riscv: Implement runtime data endianness via MSTATUS bits\n> hw/riscv: Make boot code endianness-aware at runtime\n> target/riscv: Fix page table walk endianness for big-endian harts\n> target/riscv: Support runtime endianness in virtio via sysemu callback\n> target/riscv: Add test for RISC-V BE\n> \n> hw/riscv/boot.c | 82 ++++++++++++++++++----\n> include/hw/riscv/boot.h | 2 +\n> target/riscv/cpu.c | 22 ++++--\n> target/riscv/cpu.h | 28 ++++++++\n> target/riscv/cpu_cfg_fields.h.inc | 1 +\n> target/riscv/cpu_helper.c | 28 ++++++--\n> target/riscv/internals.h | 9 +--\n> target/riscv/tcg/tcg-cpu.c | 9 ++-\n> target/riscv/translate.c | 12 ++--\n> tests/functional/riscv64/meson.build | 1 +\n> tests/functional/riscv64/test_bigendian.py | 57 +++++++++++++++\n> 11 files changed, 211 insertions(+), 40 deletions(-)\n> create mode 100644 tests/functional/riscv64/test_bigendian.py\n> \n> -- \n> 2.34.1","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=B74JsX/U;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgY843Dy6z1xy1\n\tfor ; Wed, 25 Mar 2026 14:59:48 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5FOr-0005YV-6s; Tue, 24 Mar 2026 23:59:21 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5FOo-0005Xy-Mt\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 23:59:19 -0400","from mail-dy1-x1343.google.com ([2607:f8b0:4864:20::1343])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w5FOm-0005bu-TP\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 23:59:18 -0400","by mail-dy1-x1343.google.com with SMTP id\n 5a478bee46e88-2c1092cc08cso2375631eec.1\n for ; Tue, 24 Mar 2026 20:59:16 -0700 (PDT)","from ZEVORN-PC.localdomain ([38.95.120.198])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2c10b17d1ddsm16775894eec.11.2026.03.24.20.59.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 20:59:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774411155; x=1775015955; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=JKZ3aR5oG3y+Q1Wf77NOEkfmQBq93FXXnxwyNr0Wy+k=;\n b=B74JsX/UR7/hYatXU/8dfDwzuoeZqVQe+svwe5jd2jcJBAsWwR68vctMLGICYKJSs4\n 95WozFlvVq9L+Hj0XFQPaXvs51fAIbIEluyNEhyqj9IAs+TKLWxk/KDDzDZ1HIGH8LQ2\n nSiqLRetJGV7NCC2euZcLR5htiiCM+p7kFZQdBdwtYmUGFoI23Tp2c0mMPKCitGyf62Z\n 6uKCawc4G5OAZUAzIfwAYS6J+dTJxu/ejsJI8NTgB7gTqJA1x11SFWacfzcK/dV6Ynmb\n r35swW+StH3j2WzfSyUXS3nnHC5932MUdpOexN7k4/nwcTH6K1fe+DQYIoqzdJCZ/TqV\n OPSw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774411155; x=1775015955;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=JKZ3aR5oG3y+Q1Wf77NOEkfmQBq93FXXnxwyNr0Wy+k=;\n b=IToPW7taJWDjho5Q8e8WyR/oOhWWWZvqbwe4N20mAugKOTxukEqVGqzO93vguAob1W\n glsPSHzg7FdwCCRSawnHmQYq5ekelfvZMdwxezXFt0CxMRaIweVvkwdfBlqIEaJRipTO\n 5apw60hYzyYseESJWxHOxBCcAfyTWHVMe+NlDXoLvJzMd+fYF4NwL5Ev35HzW5g7xKkX\n fKzz4tRtQjr/zS1CdXiqaNB3+v/1eyYulC6xfPsyvbGq+vbr9KKFH8K84TRdjl+43foP\n vQWveY0QjygMKzW6Y27KT5eeTnB2Lmp8Ri5Je+bDS0gjOikmaENBQ2hirUWDZgePC7Mm\n nmIw==","X-Gm-Message-State":"AOJu0YwRFKC+4dqhj+cWZO77fZ4No9vtJ5H47nklwDpxWlLAD0YhgHpz\n DxKV437mr7jwJpSZhB7ZCSoDSJat14UKFBEWsgG4nwfUzsugyA/skwL7","X-Gm-Gg":"ATEYQzwIdb/5CgG01Gl7P2OgRHAEHYaUoLBQjHYZTLQSESMfu4/eEOZWc7f5IX1TkjK\n N3ThP1YpqtdYwsK1OXm6X7YF852vm8n00MryvwRVlzhJNAGmtVkpVb25WtUAks7rHnneaMfZGOr\n P55HZ4ihnM8w8j/NTlWJvE1LVyrPpncOC24b33M1VNotwJXQDhmAZU3vSRUm56yKcLWHFZ8n5Ua\n Z6Cw6XhUevG7C5UciAsXhLVGNJWwMK28N1ydC5lzCtHkaixu4ShvB+sS+iCaisOmM9n7ZdOh9sk\n uUbp7uCjkrqCSzdWjROjuAOcfyqZ5XHuLMy6kuL/viybs+MK3kZz44FkppjDpjP7hFTl1yWZpSs\n jCVlT2di964pFO/cPYPfdEeMHBQQTYQQD4sWWns67iDpcmFlUgee8Qd1fCrDTuu5NZcPeyCBowY\n jwSrrb071x8c9e4Cm/bejLKQhM5+qZCuPitB55LlXdA0eTeHojAvQRNbe1JwEnHlMTddryQU1Wl\n 19kLtgoyA7F/YvXhsWph78D6w+Mm9k=","X-Received":"by 2002:a05:7300:148f:b0:2be:2cfe:68b7 with SMTP id\n 5a478bee46e88-2c15d36146dmr911552eec.11.1774411155359;\n Tue, 24 Mar 2026 20:59:15 -0700 (PDT)","Date":"Wed, 25 Mar 2026 11:58:54 +0800","From":"Chao Liu ","To":"Djordje Todorovic ","Cc":"\"qemu-devel@nongnu.org\" ,\n \"qemu-riscv@nongnu.org\" ,\n \"cfu@mips.com\" ,\n \"mst@redhat.com\" ,\n \"marcel.apfelbaum@gmail.com\" ,\n \"dbarboza@ventanamicro.com\" ,\n \"philmd@linaro.org\" ,\n \"alistair23@gmail.com\" ,\n \"thuth@redhat.com\" ","Subject":"Re: [PATCH v5 0/7] Add RISC-V big-endian target support","Message-ID":"","References":"<20260324164007.549397-1-djordje.todorovic@htecgroup.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260324164007.549397-1-djordje.todorovic@htecgroup.com>","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1343;\n envelope-from=chao.liu.zevorn@gmail.com; helo=mail-dy1-x1343.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]