[{"id":3584535,"web_url":"http://patchwork.ozlabs.org/comment/3584535/","msgid":"<175847725338.4354.4145979844570539358@lazor>","list_archive_url":null,"date":"2025-09-21T17:54:13","subject":"Re: [PATCH v3 06/11] clk: tegra: remove EMC to MC clock mux in\n Tegra114","submitter":{"id":73546,"url":"http://patchwork.ozlabs.org/api/people/73546/","name":"Stephen Boyd","email":"sboyd@kernel.org"},"content":"Quoting Svyatoslav Ryhel (2025-09-15 01:01:52)\n> diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c\n> index 8bde72aa5e68..6b3a140772c2 100644\n> --- a/drivers/clk/tegra/clk-tegra114.c\n> +++ b/drivers/clk/tegra/clk-tegra114.c\n> @@ -1321,6 +1309,28 @@ static int tegra114_reset_deassert(unsigned long id)\n> return 0;\n> }\n> \n> +#ifdef CONFIG_TEGRA124_CLK_EMC\n> +static struct clk *tegra114_clk_src_onecell_get(struct of_phandle_args *clkspec,\n> + void *data)\n> +{\n> + struct clk_hw *hw;\n> + struct clk *clk;\n> +\n> + clk = of_clk_src_onecell_get(clkspec, data);\n> + if (IS_ERR(clk))\n> + return clk;\n> +\n> + hw = __clk_get_hw(clk);\n\nCan you just use of_clk_hw_onecell_get() instead? Then we don't need to\nuse __clk_get_hw(). Or is this whole function used to return a clk\npointer to something that isn't the clk framework?\n\n> +\n> + if (clkspec->args[0] == TEGRA114_CLK_EMC) {\n> + if (!tegra124_clk_emc_driver_available(hw))\n> + return ERR_PTR(-EPROBE_DEFER);\n> + }\n> +\n> + return clk;","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dN9EP4k7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=147.75.80.249; helo=am.mirrors.kernel.org;\n envelope-from=devicetree+bounces-219780-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"dN9EP4k7\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from am.mirrors.kernel.org (am.mirrors.kernel.org [147.75.80.249])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4cVDQS39WBz1y1p\n\tfor ;\n Mon, 22 Sep 2025 03:54:24 +1000 (AEST)","from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby am.mirrors.kernel.org (Postfix) with ESMTPS id A461E1896DD7\n\tfor ; Sun, 21 Sep 2025 17:54:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 027D227146B;\n\tSun, 21 Sep 2025 17:54:16 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A30122AE6A;\n\tSun, 21 Sep 2025 17:54:15 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D94BDC4CEE7;\n\tSun, 21 Sep 2025 17:54:14 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1758477255; cv=none;\n b=EVL4u0/U+EDIXd73QteSmZ9ZvL/u/5dcxCglyGWsAlaphSQvulpq2M7ta/KvPar6Q3LBdngVPB9x8bG/A4ysse4QlZyDaRiZFcKqI5ImR01IJa2KOWESOd0oxRHf8/fPlSzsxuAdsFmooSNrqMJh9UmJ3zIlyhhrgs1OEJVFy5U=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1758477255; c=relaxed/simple;\n\tbh=ypzo+3PMu9bLzVVOUbp8LKYZ7ZW06X9TJgzOBqby/8g=;\n\th=Content-Type:MIME-Version:In-Reply-To:References:Subject:From:Cc:\n\t To:Date:Message-ID;\n b=jbbrDtI/o+1ytNXvTKtOGcDjYmJwDycFgYJuvELuybtYAL/l2kV0BRMvQlLGdIUbiSErESe75RtWyKmOMZcywqGYW59/S9vCOq8JQ2GYnjA36GFe5PBH+UqbCXp4nidbYzo9lDe+yJpp9qC7DPNDHwV8ucFA05/s5TMs9rp+GZA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=dN9EP4k7; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1758477255;\n\tbh=ypzo+3PMu9bLzVVOUbp8LKYZ7ZW06X9TJgzOBqby/8g=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=dN9EP4k7trHibwCBzzsM5veaTrH/dC46AzdFdMJxejZ0CV7NFya1PlK9k2f2XyZZJ\n\t fJ4CVcifA1piF6s5izpji5JiuljVxrDNagoAdmgXOo59QMS+xGapjHZytK37J7t7uh\n\t sMdkt5rj5djJhVMEpvwxScYO5KxNxmei4ADIrdHSmc9PbWEme8pnnd0UXLEWJPEHVQ\n\t d+523Yz1Xz0T7YCPct3W/+aDi81G3x/fDAEBZjOB8modZt5DOTy6XvgPDsDjZ8+G/b\n\t nBxd/88YbYKmdMKDPMigyhLfbQBC0EXuRNr6Jn1zNiCqBp5QtXBTpqvIVDtrpkdxDZ\n\t 1xh2xEgAWsxVA==","Content-Type":"text/plain; charset=\"utf-8\"","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250915080157.28195-7-clamor95@gmail.com>","References":"<20250915080157.28195-1-clamor95@gmail.com>\n <20250915080157.28195-7-clamor95@gmail.com>","Subject":"Re: [PATCH v3 06/11] clk: tegra: remove EMC to MC clock mux in\n Tegra114","From":"Stephen Boyd ","Cc":"linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,\n linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org,\n linux-pm@vger.kernel.org","To":"Chanwoo Choi , Conor Dooley ,\n Dmitry Osipenko , Jonathan Hunter ,\n Krzysztof Kozlowski ,\n Kyungmin Park ,\n Michael Turquette ,\n Mikko Perttunen ,\n MyungJoo Ham ,\n Prashant Gaikwad , Rob Herring ,\n Svyatoslav Ryhel ,\n Thierry Reding ,\n Thierry Reding ","Date":"Sun, 21 Sep 2025 10:54:13 -0700","Message-ID":"<175847725338.4354.4145979844570539358@lazor>","User-Agent":"alot/0.11"}}]