[{"id":3188487,"web_url":"http://patchwork.ozlabs.org/comment/3188487/","msgid":"","list_archive_url":null,"date":"2023-09-27T08:06:24","subject":"Re: [PATCH v2 0/8] coverity fixes","submitter":{"id":84724,"url":"http://patchwork.ozlabs.org/api/people/84724/","name":"Maksim Davydov","email":"davydov-max@yandex-team.ru"},"content":"On 9/26/23 23:15, Vladimir Sementsov-Ogievskiy wrote:\n> v2:\n> 01: add explanations, new assert and avoid extra assignment\n> add CIDs [thx to Paolo]\n> 02: add explanation, improve wording\n> 04,07: s/{0}/{}\n> 06,08: improve wording\n>\n> Hi! Here are some improvements to handle issues found by Coverity (not\n> public Coverity site, so there are no CIDs).\n>\n> Vladimir Sementsov-Ogievskiy (8):\n> hw/i386/intel_iommu: vtd_slpte_nonzero_rsvd(): assert no overflow\n> util/filemonitor-inotify: qemu_file_monitor_watch(): assert no\n> overflow\n> libvhost-user.c: add assertion to vu_message_read_default\n> mc146818rtc: rtc_set_time(): initialize tm to zeroes\n> pcie_sriov: unregister_vfs(): fix error path\n> block/nvme: nvme_process_completion() fix bound for cid\n> hw/core/loader: gunzip(): initialize z_stream\n> io/channel-socket: qio_channel_socket_flush(): improve msg validation\n>\n> block/nvme.c | 7 ++++---\n> hw/core/loader.c | 2 +-\n> hw/i386/intel_iommu.c | 23 ++++++++++++++++++---\n> hw/pci/pcie_sriov.c | 9 +++-----\n> hw/rtc/mc146818rtc.c | 2 +-\n> io/channel-socket.c | 5 +++++\n> subprojects/libvhost-user/libvhost-user.c | 1 +\n> util/filemonitor-inotify.c | 25 +++++++++++++++--------\n> 8 files changed, 52 insertions(+), 22 deletions(-)\n>\nall patches:\nReviewed-by: Maksim Davydov ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=uVxkTxdg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-11.iva.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwTkF1hwCz1ypJ\n\tfor ; Wed, 27 Sep 2023 18:07:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlPZ9-0001qo-En; Wed, 27 Sep 2023 04:06:39 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlPZ8-0001qV-Ja\n for qemu-devel@nongnu.org; Wed, 27 Sep 2023 04:06:38 -0400","from forwardcorp1c.mail.yandex.net\n ([2a02:6b8:c03:500:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlPZ2-0004lF-6G\n for qemu-devel@nongnu.org; Wed, 27 Sep 2023 04:06:37 -0400","from mail-nwsmtp-smtp-corp-main-11.iva.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-11.iva.yp-c.yandex.net\n [IPv6:2a02:6b8:c0c:7d8a:0:640:8fc3:0])\n by forwardcorp1c.mail.yandex.net (Yandex) with ESMTP id 89914609F0;\n Wed, 27 Sep 2023 11:06:25 +0300 (MSK)","from [IPV6:2a02:6b8:0:419:3865:3bcf:c96b:f374] (unknown\n [2a02:6b8:0:419:3865:3bcf:c96b:f374])\n by mail-nwsmtp-smtp-corp-main-11.iva.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id O6LcBa05YSw0-8zaZkcAN; Wed, 27 Sep 2023 11:06:24 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1695801984;\n bh=Cdq5NDQdakFTRocdi0paHyjWQ4X6yPnw5/WgsaNTgOg=;\n h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID;\n b=uVxkTxdg9Qy+19CkbIj0ervfk4hQggBU+b0joQoLZPRrEsVi6n/G46vze/mORbv0g\n jeVaBKsJJGVix6ApLSd7685PMTeUG+WQ/aJ0dNhJ1KFQfh4TgNhDiGcbeApwq43/+U\n ePgG7KC19fbYSTtDKjpiOTjIJxRuTFSOxxSZfBNQ=","Message-ID":"","Date":"Wed, 27 Sep 2023 11:06:24 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n Thunderbird/102.15.1","Subject":"Re: [PATCH v2 0/8] coverity fixes","Content-Language":"en-US","To":"Vladimir Sementsov-Ogievskiy ","Cc":"pbonzini@redhat.com, peter.maydell@linaro.org, yc-core@yandex-team.ru,\n qemu-devel@nongnu.org","References":"<20230926201532.221152-1-vsementsov@yandex-team.ru>","From":"Maksim Davydov ","In-Reply-To":"<20230926201532.221152-1-vsementsov@yandex-team.ru>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a02:6b8:c03:500:1:45:d181:df01;\n envelope-from=davydov-max@yandex-team.ru; helo=forwardcorp1c.mail.yandex.net","X-Spam_score_int":"-35","X-Spam_score":"-3.6","X-Spam_bar":"---","X-Spam_report":"(-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.473,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]