[{"id":3062658,"web_url":"http://patchwork.ozlabs.org/comment/3062658/","msgid":"<CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>","list_archive_url":null,"date":"2023-02-21T23:06:16","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":74035,"url":"http://patchwork.ozlabs.org/api/people/74035/","name":"Tony Dinh","email":"mibodhi@gmail.com"},"content":"Hi Pali,\n\nOn Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n>\n> This patch series contains various improvements and fixes for existing\n> logical errors. Boot phase was adjusted to match behavior of Armada 385\n> BootROM by inspecting and disassembling of BootROM binary dump itself.\n> Important information are included in documentation patch for kwboot.\n> Most of the changes are untested, hence this patch series is just RFC.\n> So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> Nevertheless all patches on github passed CI testing in this PR:\n> https://github.com/u-boot/u-boot/pull/275\n>\n> Pali Rohár (59):\n>   tools: kwbimage: Fix generating, verifying and extracting SDIO\n>     kwbimage\n>   tools: kwboot: Fix parsing SDIO kwbimage\n>   arm: mvebu: spl: Fix parsing SDIO kwbimage\n>   cmd: mvebu/bubt: Fix parsing SDIO kwbimage\n>   tools: kwbimage: Fix generating, verifying and extracting SATA\n>     kwbimage\n>   tools: kwboot: Fix parsing SATA kwbimage\n>   arm: mvebu: spl: Fix parsing SATA kwbimage\n>   cmd: mvebu/bubt: Fix parsing SATA kwbimage\n>   arm: mvebu: spl: Remove checks for BOOT_DEVICE_MMC2 and\n>     BOOT_DEVICE_MMC2_2\n>   arm: mvebu: spl: Load proper U-Boot from selected eMMC boot partition\n>   spl: mmc: Allow to disable SYS_MMCSD_FS_BOOT_PARTITION\n>   arm: mvebu: spl: Fix support for loading U-Boot proper from SD card\n>   tools: kwboot: Add more documentation references\n>   tools: kwboot: Add image type documentation\n>   tools: kwboot: Fix parsing UART image without data checksum\n>   tools: kwboot: Validate optional kwbimage v1 headers\n>   tools: kwboot: Add check that kwbimage contains DDR init code\n>   tools: kwboot: Fix patching of SPI/NOR XIP images\n>   tools: kwboot: Show image type and error parsing reasons\n>   cmd: mvebu/bubt: Add support for selecting eMMC HW partition\n>   cmd: mvebu/bubt: Add support for writing image to SATA disk\n>   cmd: mvebu/bubt: Add support for reading image from the SATA disk\n>     partition\n>   cmd: mvebu/bubt: Rename variable image_size to hdr_size\n>   cmd: mvebu/bubt: Mark all local symbols as static\n>   cmd: mvebu/bubt: Do not modify image in A8K check_image_header()\n>   cmd: mvebu/bubt: Check also A8K boot image checksum\n>   cmd: mvebu/bubt: Set correct default image name for 32-bit Armada SoCs\n>   cmd: mvebu/bubt: Better guess default MVEBU_*_BOOT option\n>   cmd: mvebu/bubt: Fix warnings: unused variable 'secure_mode' and\n>     'fuse_read_u64' defined but not used\n>   cmd: mvebu/bubt: Enable command by default\n>   tools: kwbimage: Fix dumping register set / DATA commands\n>   tools: kwbimage: Fix endianity when dumping NAND_PAGE_SIZE\n>   tools: kwbimage: Fix dumping NAND_BADBLK_LOCATION\n>   tools: kwbimage: Fix dumping NAND_BLKSZ\n>   tools: kwbimage: Fix generating of kwbimage v0 header checksum\n>   tools: kwbimage: Fix endianity when printing kwbimage header\n>   tools: kwbimage: Reject mkimage -F option\n>   tools: kwbimage: Add support for dumping NAND_BLKSZ for v0 images\n>   tools: kwbimage: Print binary image offset as size\n>   tools: kwbimage: Print image data offset when printing kwbimage header\n>   tools: kwbimage: Simplify add_secure_header_v1()\n>   tools: kwbimage: Rename imagesz to dataoff\n>   tools: kwbimage: Fix generating secure boot data image signature\n>   tools: kwbimage: Fix invalid secure boot header signature\n>   tools: mkimage: Do not fill legacy_img_hdr for non-legacy XIP images\n>   tools: kwbimage: Add support for XIP SPI/NOR images\n>   tools: mkimage: Print human readable error when -d is not specified\n>   tools: mkimage: Do not try to open datafile when it is skipped\n>   tools: kwbimage: Add support for creating an image with no data\n>   arm: mvebu: Add support for generating NAND kwbimage\n>   arm: mvebu: Add support for generating PEX kwbimage\n>   arm: mvebu: Fix description of MVEBU_SPL_BOOT_DEVICE_(SPI|MMC) options\n>   arm: mvebu: db-88f6820-amc: Add defconfig for NAND booting\n>   arm: mvebu: clearfog: Add defconfig for SATA booting\n>   arm: mvebu: Remove A39x relicts\n>   arm: mvebu: Fix comment about CPU_ATTR_BOOTROM mapping\n>   arm: mvebu: Define env_sf_get_env_addr() also for Proper U-Boot\n>   arm: mvebu: Define SPL memory maps\n>   doc/kwboot.1: Update example description\n>\n>  arch/arm/mach-mvebu/Kconfig                   |  23 +-\n>  arch/arm/mach-mvebu/Makefile                  |  13 +\n>  arch/arm/mach-mvebu/cpu.c                     |  11 +-\n>  arch/arm/mach-mvebu/include/mach/cpu.h        |  21 ++\n>  arch/arm/mach-mvebu/kwbimage.cfg.in           |   5 +\n>  .../serdes/a38x/high_speed_env_spec.c         |   4 +-\n>  .../serdes/a38x/high_speed_env_spec.h         |   4 +-\n>  arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c |  14 +-\n>  arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.h |  30 --\n>  arch/arm/mach-mvebu/spl.c                     |  84 +++--\n>  cmd/mvebu/Kconfig                             |  18 ++\n>  cmd/mvebu/bubt.c                              | 253 ++++++++++++---\n>  common/spl/Kconfig                            |   9 +\n>  common/spl/spl_mmc.c                          |  12 +-\n>  ...rfog_defconfig => clearfog_sata_defconfig} |   2 +-\n>  ...efconfig => db-88f6820-amc_nand_defconfig} |   6 +-\n>  doc/kwboot.1                                  |   3 +-\n>  doc/mvebu/cmd/bubt.txt                        |  25 +-\n>  drivers/mtd/nand/raw/Kconfig                  |   4 +-\n>  tools/kwbimage.c                              | 297 +++++++++++-------\n>  tools/kwboot.c                                | 200 +++++++++++-\n>  tools/mkimage.c                               |  11 +-\n>  22 files changed, 768 insertions(+), 281 deletions(-)\n>  copy configs/{clearfog_defconfig => clearfog_sata_defconfig} (98%)\n>  copy configs/{db-88f6820-amc_defconfig => db-88f6820-amc_nand_defconfig} (92%)\n>\n> --\n> 2.20.1\n>\n\nI went to patchwork and downloaded the series.\nhttps://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n\nWhen I applied the patches set there were some rejections.\n<BEGIN LOG>\n# patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n\npatching file tools/kwbimage.c\npatching file tools/kwboot.c\npatching file arch/arm/mach-mvebu/spl.c\npatching file cmd/mvebu/bubt.c\npatching file tools/kwboot.c\npatching file arch/arm/mach-mvebu/spl.c\npatching file cmd/mvebu/bubt.c\npatching file arch/arm/mach-mvebu/spl.c\npatching file arch/arm/mach-mvebu/Kconfig\nHunk #1 succeeded at 348 (offset 18 lines).\npatching file arch/arm/mach-mvebu/spl.c\npatching file arch/arm/mach-mvebu/Kconfig\nHunk #1 succeeded at 349 (offset 18 lines).\npatching file arch/arm/mach-mvebu/spl.c\npatching file tools/kwboot.c\npatching file tools/kwboot.c\npatching file tools/kwboot.c\npatching file tools/kwboot.c\npatching file tools/kwboot.c\npatching file tools/kwboot.c\npatching file tools/kwboot.c\npatching file cmd/mvebu/bubt.c\npatching file doc/mvebu/cmd/bubt.txt\npatching file cmd/mvebu/bubt.c\nHunk #1 FAILED at 420.\nHunk #2 FAILED at 430.\nHunk #3 FAILED at 656.\nHunk #4 FAILED at 1206.\n4 out of 4 hunks FAILED -- saving rejects to file cmd/mvebu/bubt.c.rej\npatching file doc/mvebu/cmd/bubt.txt\nHunk #1 FAILED at 6.\n1 out of 1 hunk FAILED -- saving rejects to file doc/mvebu/cmd/bubt.txt.rej\npatching file cmd/mvebu/bubt.c\nHunk #1 succeeded at 765 (offset -140 lines).\nHunk #2 succeeded at 804 (offset -140 lines).\nHunk #3 succeeded at 825 (offset -140 lines).\npatching file cmd/mvebu/bubt.c\nHunk #1 succeeded at 548 (offset -139 lines).\nHunk #2 succeeded at 567 (offset -140 lines).\nHunk #3 succeeded at 1000 (offset -140 lines).\nHunk #4 succeeded at 1026 (offset -142 lines).\npatching file cmd/mvebu/bubt.c\nHunk #1 succeeded at 599 (offset -140 lines).\npatching file cmd/mvebu/bubt.c\nHunk #1 succeeded at 585 (offset -140 lines).\nHunk #2 succeeded at 598 (offset -140 lines).\npatching file cmd/mvebu/Kconfig\nHunk #1 succeeded at 15 (offset -3 lines).\npatching file cmd/mvebu/bubt.c\nHunk #1 succeeded at 844 (offset -140 lines).\nHunk #2 succeeded at 873 (offset -140 lines).\npatching file cmd/mvebu/Kconfig\nHunk #1 succeeded at 3 with fuzz 1.\npatching file tools/kwbimage.c\nHunk #1 succeeded at 2156 (offset 8 lines).\nHunk #2 succeeded at 2241 (offset 8 lines).\npatching file tools/kwbimage.c\nHunk #1 succeeded at 2190 (offset 8 lines).\npatching file tools/kwbimage.c\nHunk #1 succeeded at 2192 with fuzz 2 (offset 8 lines).\npatching file tools/kwbimage.c\nHunk #1 succeeded at 1929 (offset 1 line).\npatching file tools/kwbimage.c\nHunk #1 succeeded at 2449 (offset 9 lines).\npatching file tools/kwbimage.c\nHunk #1 succeeded at 2192 (offset 7 lines).\npatching file tools/kwbimage.c\nHunk #1 succeeded at 1915 (offset 1 line).\npatching file tools/kwbimage.c\nHunk #1 succeeded at 1930 (offset 1 line).\npatching file tools/kwbimage.c\nHunk #3 succeeded at 1529 (offset 1 line).\npatching file tools/kwbimage.c\nHunk #2 succeeded at 1050 with fuzz 2.\nHunk #4 succeeded at 1533 (offset 1 line).\nHunk #5 succeeded at 1812 (offset 1 line).\nHunk #6 succeeded at 1863 (offset 1 line).\nHunk #7 succeeded at 1885 (offset 1 line).\npatching file tools/kwbimage.c\npatching file tools/kwbimage.c\nHunk #4 FAILED at 1014.\nHunk #5 succeeded at 1051 with fuzz 2.\nHunk #11 FAILED at 1454.\nHunk #12 succeeded at 1525 (offset 1 line).\nHunk #13 succeeded at 1877 (offset 1 line).\nHunk #14 succeeded at 2103 (offset 7 lines).\n2 out of 14 hunks FAILED -- saving rejects to file tools/kwbimage.c.rej\npatching file tools/mkimage.c\nHunk #1 succeeded at 860 (offset 18 lines).\npatching file tools/mkimage.c\nHunk #1 succeeded at 600 (offset 32 lines).\npatching file tools/mkimage.c\nHunk #1 succeeded at 599 (offset 32 lines).\npatching file tools/kwbimage.c\nHunk #1 succeeded at 1809 (offset -78 lines).\nHunk #2 succeeded at 2031 (offset -77 lines).\nHunk #3 succeeded at 2051 (offset -77 lines).\nHunk #4 succeeded at 2124 (offset -77 lines).\nHunk #5 succeeded at 2460 with fuzz 2 (offset -72 lines).\npatching file arch/arm/mach-mvebu/Kconfig\nHunk #1 succeeded at 339 (offset 18 lines).\nHunk #2 succeeded at 369 (offset 18 lines).\npatching file arch/arm/mach-mvebu/Makefile\npatching file arch/arm/mach-mvebu/kwbimage.cfg.in\npatching file drivers/mtd/nand/raw/Kconfig\nHunk #1 succeeded at 628 (offset 78 lines).\nHunk #2 succeeded at 656 (offset 79 lines).\npatching file arch/arm/mach-mvebu/Kconfig\nHunk #1 succeeded at 363 (offset 18 lines).\npatching file arch/arm/mach-mvebu/Makefile\npatching file arch/arm/mach-mvebu/Kconfig\nHunk #1 succeeded at 331 (offset 18 lines).\nHunk #2 succeeded at 345 (offset 18 lines).\npatching file configs/db-88f6820-amc_nand_defconfig (copied from\nconfigs/db-88f6820-amc_defconfig)\nHunk #1 succeeded at 8 with fuzz 2 (offset 2 lines).\npatching file configs/clearfog_sata_defconfig (copied from\nconfigs/clearfog_defconfig)\nHunk #1 succeeded at 9 with fuzz 2 (offset 2 lines).\npatching file arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c\npatching file arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.h\npatching file arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c\npatching file arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.h\npatching file arch/arm/mach-mvebu/cpu.c\npatching file arch/arm/mach-mvebu/cpu.c\npatching file arch/arm/mach-mvebu/include/mach/cpu.h\npatching file arch/arm/mach-mvebu/spl.c\npatching file arch/arm/mach-mvebu/include/mach/cpu.h\npatching file doc/kwboot.1\n<END LOG>\n\nI'm on the latest master branch (just did a git pull today). Could\nsome patches be out of order?\n\nThanks,\nTony","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=gJZ0AN2X;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"gJZ0AN2X\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=mibodhi@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLw052tQQz23j7\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 10:06:45 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 30BD085A58;\n\tWed, 22 Feb 2023 00:06:40 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 1401985A56; Wed, 22 Feb 2023 00:06:37 +0100 (CET)","from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com\n [IPv6:2607:f8b0:4864:20::e2f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BEC6785917\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 00:06:28 +0100 (CET)","by mail-vs1-xe2f.google.com with SMTP id v3so6154359vse.0\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 15:06:28 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4J4hl1G28R3xJEWSuM5flIGkKyROc67hY2n6hO/NsbM=;\n b=gJZ0AN2XJS6JCLf2ND/WjYQ955jt8cdgB1yeGhPDe96XCtLjPsho32eTfoyVplQOm7\n IhalLS6VqS2aLWShix//1k8YI4pGzZDsvrz2hSNqB6RJGpkKYycg8aCselHgtEkM5hGb\n LBgiVGr9PP8FRCB3p7vOZiVVptb7UlqHHNyqTjW3sn5tcDB176ML7EKooWqncup3xSxh\n Apmt+Jt+VgOajF3+Yso+o3VfkzmpWUemJHssxPaTlCbm2YVwLmuMi3ZPYIqBqCdGOaXM\n M3BpRDZczL4tvlwRqNWfMMt1pTu2vRebxZOI3VsuxWnqyAHcPbL4f/YrE1K2j9nBHNHF\n 09CA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=4J4hl1G28R3xJEWSuM5flIGkKyROc67hY2n6hO/NsbM=;\n b=rgldz0J0OYFStE1DG3v8xiVj4Vcmz7yhNwFuiuzh+3+HibjWS2/Y+mYrKKhqH7trpu\n QMT/cM0zcTDX3GOSTMVY0VBSdhaKqnIjSZjG6znvyffTzetCI2habDRvxkWFc0f2uzpe\n q60JuG8Bd2WSMAs4Ct8m4O9jQg2bXAwrluxwl0PpmzYiHdhWhGwWaZ2/SSZuiI2PO1UN\n MGHhGJp3nZuczKTP2a8mHzo/WoIFlVbwibAWj4oYOsdk8z+mT/e3ZUqfBqVfiLZDM4Nj\n DdRuyZjrXMcRdfAsK5oDKHwrh+io0LFTbarNjfc6HqsqJl+HXEUPYEAgrk1+jPlWYhDe\n ebVQ==","X-Gm-Message-State":"AO0yUKXfLiU6Dr63xm/k6AWxjToI9cFxr8BSuffE7+x4OX7ixd+jzpfu\n l6vMbttUyzV2fTBeaiIQsgZsWPCYHn99iSRpSb8=","X-Google-Smtp-Source":"\n AK7set+iu5C/JnYOqUJqXgqn9DINV/JQ3RDWaXvuzgo6yo0hJuFw62rKQzyuUUWj8gs1RmOXWagi8WfJGIicPaL6mRI=","X-Received":"by 2002:a05:6102:f98:b0:401:1444:817c with SMTP id\n e24-20020a0561020f9800b004011444817cmr2098930vsv.17.1677020787356; Tue, 21\n Feb 2023 15:06:27 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>","In-Reply-To":"<20230221201925.9644-1-pali@kernel.org>","From":"Tony Dinh <mibodhi@gmail.com>","Date":"Tue, 21 Feb 2023 15:06:16 -0800","Message-ID":"\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3062668,"web_url":"http://patchwork.ozlabs.org/comment/3062668/","msgid":"<20230221231405.ln5fvxuvgzmwmbl5@pali>","list_archive_url":null,"date":"2023-02-21T23:14:05","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> Hi Pali,\n> \n> On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> >\n> > This patch series contains various improvements and fixes for existing\n> > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > Important information are included in documentation patch for kwboot.\n> > Most of the changes are untested, hence this patch series is just RFC.\n> > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > Nevertheless all patches on github passed CI testing in this PR:\n> > https://github.com/u-boot/u-boot/pull/275\n...\n> I went to patchwork and downloaded the series.\n> https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> \n> When I applied the patches set there were some rejections.\n> <BEGIN LOG>\n> # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> \n...\nFAILED\n...\n> <END LOG>\n> \n> I'm on the latest master branch (just did a git pull today). Could\n> some patches be out of order?\n> \n> Thanks,\n> Tony\n\nWell, that is because DENX mail server is broken and it crashed during\nprocessing antispam filter on my some of my patches. So some patches are\nmissing in archive and then applying dependent patches failed.\n\nSo ignore patchwork and email patches. Rather fetch changes from the\nmentioned github pull request https://github.com/u-boot/u-boot/pull/275\n\nYou can do it via git command (it fetch it to the new mvebu branch):\n\n  git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=DJJLL09q;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"DJJLL09q\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLw8q2Xf6z23hX\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 10:14:19 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id AB91685A5B;\n\tWed, 22 Feb 2023 00:14:14 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 65D5A85A6E; Wed, 22 Feb 2023 00:14:12 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BF10685A53\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 00:14:09 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 76CD461018;\n Tue, 21 Feb 2023 23:14:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id BDD35C433D2;\n Tue, 21 Feb 2023 23:14:07 +0000 (UTC)","by pali.im (Postfix)\n id 6D57270C; Wed, 22 Feb 2023 00:14:05 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677021247;\n bh=QiQ18l0K2Qpo0LsRA6cHpcd2tkyFdxVIY2gkkJkwxn4=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=DJJLL09q3IsL3Xh5oa9SfqLr+Y7eQPBmSg/MT5v/aFH0CkhGDWgKzmGcntWRebpFn\n IX5wdjcAgPwnWkqPIngW/Kfa/8loNTCDJBSuf/GfqXwBJyTQbfSNQ49DNCUCRQaQIB\n JLoWeYGvW4bQ70YSPB0Nq/K89EtXIc7Lt90TqClhzwu5rKnOA9jdBNtMkZ7f1MYVEJ\n 8iPXJ8OPZUIBxZXYQ47firNi3pACLgM9jq6pTmNsKXFfRQaqheG78JvmJNymXR6i6p\n 1gLdFUsZGPOFe2tCwlATwpSUI05At8m+cZXJfBRFsBo2CgHUd4jKAbA/fxK50FfrMR\n +TX3sP/O4ouUw==","Date":"Wed, 22 Feb 2023 00:14:05 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Tony Dinh <mibodhi@gmail.com>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230221231405.ln5fvxuvgzmwmbl5@pali>","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3062816,"web_url":"http://patchwork.ozlabs.org/comment/3062816/","msgid":"<CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>","list_archive_url":null,"date":"2023-02-22T05:45:07","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":74035,"url":"http://patchwork.ozlabs.org/api/people/74035/","name":"Tony Dinh","email":"mibodhi@gmail.com"},"content":"Hi Pali,\n\nOn Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali@kernel.org> wrote:\n>\n> On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> > Hi Pali,\n> >\n> > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> > >\n> > > This patch series contains various improvements and fixes for existing\n> > > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > > Important information are included in documentation patch for kwboot.\n> > > Most of the changes are untested, hence this patch series is just RFC.\n> > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > > Nevertheless all patches on github passed CI testing in this PR:\n> > > https://github.com/u-boot/u-boot/pull/275\n> ...\n> > I went to patchwork and downloaded the series.\n> > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> >\n> > When I applied the patches set there were some rejections.\n> > <BEGIN LOG>\n> > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> >\n> ...\n> FAILED\n> ...\n> > <END LOG>\n> >\n> > I'm on the latest master branch (just did a git pull today). Could\n> > some patches be out of order?\n> >\n> > Thanks,\n> > Tony\n>\n> Well, that is because DENX mail server is broken and it crashed during\n> processing antispam filter on my some of my patches. So some patches are\n> missing in archive and then applying dependent patches failed.\n>\n> So ignore patchwork and email patches. Rather fetch changes from the\n> mentioned github pull request https://github.com/u-boot/u-boot/pull/275\n>\n> You can do it via git command (it fetch it to the new mvebu branch):\n>\n>   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu\n\nIndeed! That pull request was applied without problem.\n\nSo I did a general regression test running rebuilt kwboot binary, and\nrebuilt u-boot images for these 2 Marvell boards:\n\nThecus N2350 (Armada 385)\nPogo V4 (Kirkwood 88F6192).\n\nSo for that part:\nTested-by: Tony Dinh <mibodhi@gmail.com>\n\nAll the best,\nTony","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=ZiYsJaGe;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"ZiYsJaGe\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=mibodhi@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PM4rB1GMXz23yr\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 16:45:30 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B05718338B;\n\tWed, 22 Feb 2023 06:45:24 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 254B8859DD; Wed, 22 Feb 2023 06:45:23 +0100 (CET)","from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com\n [IPv6:2607:f8b0:4864:20::e2a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 3106B80F72\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 06:45:20 +0100 (CET)","by mail-vs1-xe2a.google.com with SMTP id u14so6918937vsp.8\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 21:45:20 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=47nATovugjLduxGmvNsM1tCvfOcPz/HpQh8La4IGZ3k=;\n b=ZiYsJaGesU7hKxSmYWZIoHWMvkiUMRqXHC5HpxL95mF0Q9wwhaQKpz1E0ATEzlcv3a\n 4kyhvuRLhmviYqSkusNx7qgol3nq3O0KOQ/kd25BJaj1bOWjpUed61RU2P1XHbUJMHn5\n dJckcHfXv0zSfZQhS2gFtTCjl4pPC++FTd/6fz1w4lZu5d5ycr899NiH4Alyr0UbSw/d\n FbS4sUfMDqaq7heemdrKXjAe43vS+yh5XXp9jlnkjZOitXe3aNiOZrm/uv7C2vRKcYZi\n NKY2o2WY4y7ESkRsMP/vTPhdeEHfTO6HqhaD7xbs7Nmjykhp0G4gfkwluvaBqsR56WGK\n Vwmw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=47nATovugjLduxGmvNsM1tCvfOcPz/HpQh8La4IGZ3k=;\n b=cF3gvDlVIyuqzrMc1TFI3gepB53q0m8LwMstdlURnu3GCs/DPOPZSrNj/A/OEoqyyA\n VSgezJTmY07iUla3TDfZFz1WQDUKhUJuF7IlPI4zacEYlC4t1e1BEUt8fJRtrgsbMLIi\n wvO5ispi8inb52FyuF0TQ5IPqkat/XBkOwkRy5sU2etT5A6nu/yQUHoiPLgPIJEebWmH\n 6kT1DFjZM+0iszMFupgdJzk8FFQu5UEfe46xOXXD5ZNlGKSLIzQ0XvY7Qfya0QnF4ThL\n 49hKnpVxSvvl3MHSAoy8ZY7abgNJ6A4/cMx2XSdDwdCq2qRuduvlO7QMflCGJhYyd7yQ\n zE+g==","X-Gm-Message-State":"AO0yUKVExX7bZ6KMElaaVl4bK32p5/Le7ZHtdFc7STkcYUBKnmwgpn/Y\n Kt5mX4Am3J2IIPBdRJ3FUtc/gbwnxm/1hy+lSns=","X-Google-Smtp-Source":"\n AK7set86CMWGzibSEdIsk0XdsCMGaMmJYINCgudyOIh8SHPHZ8Jhqavw8NDSAZh9k3GfDw6LpEmNvg7ekvhcVGZSis8=","X-Received":"by 2002:a05:6102:f98:b0:401:1444:817c with SMTP id\n e24-20020a0561020f9800b004011444817cmr2349324vsv.17.1677044718831; Tue, 21\n Feb 2023 21:45:18 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>","In-Reply-To":"<20230221231405.ln5fvxuvgzmwmbl5@pali>","From":"Tony Dinh <mibodhi@gmail.com>","Date":"Tue, 21 Feb 2023 21:45:07 -0800","Message-ID":"\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3062870,"web_url":"http://patchwork.ozlabs.org/comment/3062870/","msgid":"<20230222075819.6f3vl7nlnpqwpg6e@pali>","list_archive_url":null,"date":"2023-02-22T07:58:19","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote:\n> Hi Pali,\n> \n> On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali@kernel.org> wrote:\n> >\n> > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> > > Hi Pali,\n> > >\n> > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> > > >\n> > > > This patch series contains various improvements and fixes for existing\n> > > > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > > > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > > > Important information are included in documentation patch for kwboot.\n> > > > Most of the changes are untested, hence this patch series is just RFC.\n> > > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > > > Nevertheless all patches on github passed CI testing in this PR:\n> > > > https://github.com/u-boot/u-boot/pull/275\n> > ...\n> > > I went to patchwork and downloaded the series.\n> > > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> > >\n> > > When I applied the patches set there were some rejections.\n> > > <BEGIN LOG>\n> > > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> > >\n> > ...\n> > FAILED\n> > ...\n> > > <END LOG>\n> > >\n> > > I'm on the latest master branch (just did a git pull today). Could\n> > > some patches be out of order?\n> > >\n> > > Thanks,\n> > > Tony\n> >\n> > Well, that is because DENX mail server is broken and it crashed during\n> > processing antispam filter on my some of my patches. So some patches are\n> > missing in archive and then applying dependent patches failed.\n> >\n> > So ignore patchwork and email patches. Rather fetch changes from the\n> > mentioned github pull request https://github.com/u-boot/u-boot/pull/275\n> >\n> > You can do it via git command (it fetch it to the new mvebu branch):\n> >\n> >   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu\n> \n> Indeed! That pull request was applied without problem.\n> \n> So I did a general regression test running rebuilt kwboot binary, and\n> rebuilt u-boot images for these 2 Marvell boards:\n> \n> Thecus N2350 (Armada 385)\n> Pogo V4 (Kirkwood 88F6192).\n> \n> So for that part:\n> Tested-by: Tony Dinh <mibodhi@gmail.com>\n> \n> All the best,\n> Tony\n\nThanks for testing! Anyway do you have some A38x board which can boot\nfrom SD/MMC, SATA or NAND? This is what is needed to test too. I see\nthat Pogo boots from NAND but it does not use SPL.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=JANMO/lP;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"JANMO/lP\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PM7nv2YtMz23yr\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 18:58:43 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E0D1B859B9;\n\tWed, 22 Feb 2023 08:58:37 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id DEBBE85A60; Wed, 22 Feb 2023 08:58:35 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1A40F85A5F\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 08:58:25 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 3F17A611CD;\n Wed, 22 Feb 2023 07:58:23 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 8C4F5C433D2;\n Wed, 22 Feb 2023 07:58:22 +0000 (UTC)","by pali.im (Postfix)\n id 9A82072C; Wed, 22 Feb 2023 08:58:19 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677052702;\n bh=ZZBA50EpIXmXC4dv3Zsumjfxhimryhf43y9Yt4opFLQ=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=JANMO/lPpG6z33Ocl4VYrIN4dQT0Mtr+EUOOZifnnH7eSJBc2ks/my+dV/mGnGKHZ\n atXzWnTE5nKshn0yc78qiVdTD57u9VRX55EHM81JZeu875EAbnw5RpkLyRgVhMWLVJ\n QLvm/8Rx+k4hUtO41U2uU/yuV6+q6Rl/5pozAXLGMAuhAXfRC1SiawT2DzF9q5fVeX\n VZ/8asdZWFmHfaa6EOiCqbje0z6s+q3uYwtYwU1rUQ9IVtRLyQJCAFPj5wAigwgJuV\n 7ErJMRUeVjgP0ugvjweXtJUsNHNJQ2ConhonXxAVu7qJBktyM/c//yS357qROfxyf9\n u5qC8T6WtqGKQ==","Date":"Wed, 22 Feb 2023 08:58:19 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Tony Dinh <mibodhi@gmail.com>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230222075819.6f3vl7nlnpqwpg6e@pali>","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063101,"web_url":"http://patchwork.ozlabs.org/comment/3063101/","msgid":"<CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>","list_archive_url":null,"date":"2023-02-22T11:59:35","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":85861,"url":"http://patchwork.ozlabs.org/api/people/85861/","name":"Martin Rowe","email":"martin.p.rowe@gmail.com"},"content":"Pali,\n\nGood news:\n\nA388 Clearfog Base (SD card model):\n- MMC from SD card works\n- UART works\n- SATA with new defconfig works\n- SPI (if you select MVEBU_SPL_BOOT_DEVICE_SPI yourself) works\nA388 Clearfog Pro (eMMC model):\n- MMC from eMMC works, but still requires the dts to be patched for\neMMC (included at bottom)\n\nI tried eMMC both with and without the dts patched, but only the\npatched version boots. I am not easily able to test the other boot\nmethods on the Pro, but they're the same as the Base. Let me know if\nyou need any extra data/outputs.\n\nAlso, the extra/updated comments with these changes are great! Thanks.\n\nTested-by: Martin Rowe <martin.p.rowe@gmail.com>\n\nMartin\n\ndiff --git a/arch/arm/dts/armada-388-clearfog.dts\nb/arch/arm/dts/armada-388-clearfog.dts\nindex e4164f49b2..29a608abcf 100644\n--- a/arch/arm/dts/armada-388-clearfog.dts\n+++ b/arch/arm/dts/armada-388-clearfog.dts\n@@ -101,7 +101,7 @@\n\n                        sdhci@d8000 {\n                                bus-width = <4>;\n-                               cd-gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;\n+                               non-removable;\n                                no-1-8-v;\n                                pinctrl-0 = <&microsom_sdhci_pins\n                                             &clearfog_sdhci_cd_pins>;\n\nOn Wed, 22 Feb 2023 at 07:58, Pali Rohár <pali@kernel.org> wrote:\n>\n> On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote:\n> > Hi Pali,\n> >\n> > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali@kernel.org> wrote:\n> > >\n> > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> > > > Hi Pali,\n> > > >\n> > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > >\n> > > > > This patch series contains various improvements and fixes for existing\n> > > > > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > > > > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > > > > Important information are included in documentation patch for kwboot.\n> > > > > Most of the changes are untested, hence this patch series is just RFC.\n> > > > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > > > > Nevertheless all patches on github passed CI testing in this PR:\n> > > > > https://github.com/u-boot/u-boot/pull/275\n> > > ...\n> > > > I went to patchwork and downloaded the series.\n> > > > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> > > >\n> > > > When I applied the patches set there were some rejections.\n> > > > <BEGIN LOG>\n> > > > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> > > >\n> > > ...\n> > > FAILED\n> > > ...\n> > > > <END LOG>\n> > > >\n> > > > I'm on the latest master branch (just did a git pull today). Could\n> > > > some patches be out of order?\n> > > >\n> > > > Thanks,\n> > > > Tony\n> > >\n> > > Well, that is because DENX mail server is broken and it crashed during\n> > > processing antispam filter on my some of my patches. So some patches are\n> > > missing in archive and then applying dependent patches failed.\n> > >\n> > > So ignore patchwork and email patches. Rather fetch changes from the\n> > > mentioned github pull request https://github.com/u-boot/u-boot/pull/275\n> > >\n> > > You can do it via git command (it fetch it to the new mvebu branch):\n> > >\n> > >   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu\n> >\n> > Indeed! That pull request was applied without problem.\n> >\n> > So I did a general regression test running rebuilt kwboot binary, and\n> > rebuilt u-boot images for these 2 Marvell boards:\n> >\n> > Thecus N2350 (Armada 385)\n> > Pogo V4 (Kirkwood 88F6192).\n> >\n> > So for that part:\n> > Tested-by: Tony Dinh <mibodhi@gmail.com>\n> >\n> > All the best,\n> > Tony\n>\n> Thanks for testing! Anyway do you have some A38x board which can boot\n> from SD/MMC, SATA or NAND? This is what is needed to test too. I see\n> that Pogo boots from NAND but it does not use SPL.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=SjftHEQg;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"SjftHEQg\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=martin.p.rowe@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMF8Q60dnz23yr\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 23:00:06 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C588F85AAA;\n\tWed, 22 Feb 2023 12:59:52 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 9B5DA85AB8; Wed, 22 Feb 2023 12:59:51 +0100 (CET)","from mail-oa1-x34.google.com (mail-oa1-x34.google.com\n [IPv6:2001:4860:4864:20::34])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 36C9185A63\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 12:59:48 +0100 (CET)","by mail-oa1-x34.google.com with SMTP id\n 586e51a60fabf-17227cba608so6769200fac.3\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 03:59:48 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=exX97gJmhe1KfVyFwAC/YS0hteXiT7jK78fzDhe2x/M=;\n b=SjftHEQgV5X5mRtNzzNaIldl1+k4O5gbdiAFIbNjK7vdt6NbonO0VvUJJCK8GsWfqS\n xS8yF7w+bbo0LDyCVeVVyx6Z8VpBCtgGCU07Q0irrgNTT4mSslDQdnmqCZGJ13TxgmFR\n AOsluXviNe4zgpLLLoCjmkjvb9cw+MwWXULoHvTQj1elzsfYgFaaPQrwBFWe6gsfeQB/\n U/88sK8dcdnNogjUj7tVaUtBTWHSuGHbFuLcPngFFd/nxhnxKRMyaEeKpvEWJOGAIpO3\n EfR7nUV9Gx7cTB4ZyPu8D7NYp+fEgCmi8vftAdlV5HtgtGnap+YXyo6J1ccoeYsVsoKa\n 67kQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=exX97gJmhe1KfVyFwAC/YS0hteXiT7jK78fzDhe2x/M=;\n b=08oF3vpGW1QEu4vo10za0izWf3VASXi0JlsX9ueezKAccSK+rJoFPZ8yoY4LEVrsTb\n anhmQjkoYygMm26a4xZwgBYZBgKyhp+WnO0JvID94GaMb2oiCx+ocWpfgtOlRRLYc1yF\n L9MPNPBWqTGt1QW3FJ9XYIvfrhkncWmunihD++vcxotbrfF3CoGuWa80OEFmUcgpImx1\n ghujCvaqsb88UT406ZNxZXY1Wwan5ogVl/dgfWsbo8AM1tDcfv+IS7JZaD771Ip42wom\n cUzrGE/vVX/6s7MISwLCOAsRHr1g4G/8oSoUY7oYYyRxRvylsfp/O8cYhmpvVO4/ZmnR\n OeYg==","X-Gm-Message-State":"AO0yUKVLCp12cUuBvFulBQ5ED/FCxJw+kaBoMm+csNZSOtKcSzZRL+vh\n d+BTYxDVzPcsJ5nVBNOYA/LUVvzICoRZdJwf1Mw=","X-Google-Smtp-Source":"\n AK7set93NiLbnVVTl96indYiQoxwwz6pTutZ4A4oFumL2FkNtQSL4hV9w6m3NLGKwo5/gpKZKdw8Qw1XgnTgY3a/new=","X-Received":"by 2002:a05:6870:b487:b0:15f:4c38:7df6 with SMTP id\n y7-20020a056870b48700b0015f4c387df6mr980205oap.163.1677067186824; Wed, 22 Feb\n 2023 03:59:46 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>","In-Reply-To":"<20230222075819.6f3vl7nlnpqwpg6e@pali>","From":"Martin Rowe <martin.p.rowe@gmail.com>","Date":"Wed, 22 Feb 2023 11:59:35 +0000","Message-ID":"\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063429,"web_url":"http://patchwork.ozlabs.org/comment/3063429/","msgid":"<20230222180307.7sxot7ivfx3elunx@pali>","list_archive_url":null,"date":"2023-02-22T18:03:07","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"Hello! Thank you for testing.\n\nOn Wednesday 22 February 2023 11:59:35 Martin Rowe wrote:\n> Pali,\n> \n> Good news:\n> \n> A388 Clearfog Base (SD card model):\n> - MMC from SD card works\n> - UART works\n> - SATA with new defconfig works\n> - SPI (if you select MVEBU_SPL_BOOT_DEVICE_SPI yourself) works\n\nCould you send a patch which adds appropriate defconfig file for SPI\nboot? So this configuration would be tested in U-Boot CI automatically.\n\n> A388 Clearfog Pro (eMMC model):\n> - MMC from eMMC works, but still requires the dts to be patched for\n> eMMC (included at bottom)\n\nHave you tried booting from eMMC boot partition or eMMC user data\npartition? Because all 3 options should work, but I'm not fully sure if\nBootROM choose partition from eMMC register or if tries all 3 in some\norder. This is something which needs to be checked and verified.\n\n> I tried eMMC both with and without the dts patched, but only the\n> patched version boots. I am not easily able to test the other boot\n> methods on the Pro, but they're the same as the Base. Let me know if\n> you need any extra data/outputs.\n\nCould you try to use SolidRun eMMC patch which SolidRun has for years in\nits repository?\n\nhttps://github.com/SolidRun/u-boot/commit/19a96f7c40a8fc1d0a6546ac2418d966e5840a99\n\nProbably same functionality is needed to implement also into\nboard_fix_fdt() function enabled by CONFIG_OF_BOARD_FIXUP. Look for\nother boards how they use CONFIG_OF_BOARD_FIXUP.\n\nAnd if ... you can try to put this logic in board_late_init() function.\nFor inspiration look into Espressobin board which deactivates eMMC at\nruntime by checking existence of eMMC:\nhttps://source.denx.de/u-boot/u-boot/-/blob/master/board/Marvell/mvebu_armada-37xx/board.c\n\n> Also, the extra/updated comments with these changes are great! Thanks.\n\nThere is still missing documentation for kwbimage config file format.\nIt should be in \"kwbimage\" section of ./doc/mkimage.1 file but there is\nonly placeholder... It would be nice if somebody can take it and write\nit.\n\n> Tested-by: Martin Rowe <martin.p.rowe@gmail.com>\n> \n> Martin\n> \n> diff --git a/arch/arm/dts/armada-388-clearfog.dts\n> b/arch/arm/dts/armada-388-clearfog.dts\n> index e4164f49b2..29a608abcf 100644\n> --- a/arch/arm/dts/armada-388-clearfog.dts\n> +++ b/arch/arm/dts/armada-388-clearfog.dts\n> @@ -101,7 +101,7 @@\n> \n>                         sdhci@d8000 {\n>                                 bus-width = <4>;\n> -                               cd-gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;\n> +                               non-removable;\n>                                 no-1-8-v;\n>                                 pinctrl-0 = <&microsom_sdhci_pins\n>                                              &clearfog_sdhci_cd_pins>;\n> \n> On Wed, 22 Feb 2023 at 07:58, Pali Rohár <pali@kernel.org> wrote:\n> >\n> > On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote:\n> > > Hi Pali,\n> > >\n> > > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali@kernel.org> wrote:\n> > > >\n> > > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> > > > > Hi Pali,\n> > > > >\n> > > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > > >\n> > > > > > This patch series contains various improvements and fixes for existing\n> > > > > > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > > > > > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > > > > > Important information are included in documentation patch for kwboot.\n> > > > > > Most of the changes are untested, hence this patch series is just RFC.\n> > > > > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > > > > > Nevertheless all patches on github passed CI testing in this PR:\n> > > > > > https://github.com/u-boot/u-boot/pull/275\n> > > > ...\n> > > > > I went to patchwork and downloaded the series.\n> > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> > > > >\n> > > > > When I applied the patches set there were some rejections.\n> > > > > <BEGIN LOG>\n> > > > > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> > > > >\n> > > > ...\n> > > > FAILED\n> > > > ...\n> > > > > <END LOG>\n> > > > >\n> > > > > I'm on the latest master branch (just did a git pull today). Could\n> > > > > some patches be out of order?\n> > > > >\n> > > > > Thanks,\n> > > > > Tony\n> > > >\n> > > > Well, that is because DENX mail server is broken and it crashed during\n> > > > processing antispam filter on my some of my patches. So some patches are\n> > > > missing in archive and then applying dependent patches failed.\n> > > >\n> > > > So ignore patchwork and email patches. Rather fetch changes from the\n> > > > mentioned github pull request https://github.com/u-boot/u-boot/pull/275\n> > > >\n> > > > You can do it via git command (it fetch it to the new mvebu branch):\n> > > >\n> > > >   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu\n> > >\n> > > Indeed! That pull request was applied without problem.\n> > >\n> > > So I did a general regression test running rebuilt kwboot binary, and\n> > > rebuilt u-boot images for these 2 Marvell boards:\n> > >\n> > > Thecus N2350 (Armada 385)\n> > > Pogo V4 (Kirkwood 88F6192).\n> > >\n> > > So for that part:\n> > > Tested-by: Tony Dinh <mibodhi@gmail.com>\n> > >\n> > > All the best,\n> > > Tony\n> >\n> > Thanks for testing! Anyway do you have some A38x board which can boot\n> > from SD/MMC, SATA or NAND? This is what is needed to test too. I see\n> > that Pogo boots from NAND but it does not use SPL.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ees0Laml;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"ees0Laml\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMPDs21QBz245s\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 05:04:29 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 484B685ADC;\n\tWed, 22 Feb 2023 19:04:01 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 3E3CC80BAA; Wed, 22 Feb 2023 19:03:24 +0100 (CET)","from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 3B70C85AF7\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 19:03:17 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id 0BD1AB81603;\n Wed, 22 Feb 2023 18:03:11 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 67EADC433D2;\n Wed, 22 Feb 2023 18:03:10 +0000 (UTC)","by pali.im (Postfix)\n id 90FF072C; Wed, 22 Feb 2023 19:03:07 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677088990;\n bh=aYS7K0Qkxu2azoESXMiWYKrgaUrX9TngDgKVUXnFXyU=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=ees0LamlDEc8i+UgZKC0844iuZLArKU5P/F7OqlUGQjI9FBVi78NUyyo9NAMV9hbP\n 9sCIfBxG23AAPgiZd8mlWIPr2QgUo8XjeB35zqVifc64UJAWgUK4r9b5IISRs/j5gK\n x5NgriLmi9CERq4A7wx4l7XK7mX+0YO3B/KscJicfel87WJnCIOoA5mLKrL2awcobf\n 4R1Wm/VeGV5XkQHJlWZkALhlcNdGTCaME/ZDX4cjPVwJI39rs2JmlpCiv2JlhOvlkc\n HeqdK7P4rEMrOEU0XBT/+j4W4be8YUbEYL02+YXopSFuzSEg6DlKiDRdEMFqqzpKoA\n j/szSNBdIBDPQ==","Date":"Wed, 22 Feb 2023 19:03:07 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Martin Rowe <martin.p.rowe@gmail.com>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230222180307.7sxot7ivfx3elunx@pali>","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063556,"web_url":"http://patchwork.ozlabs.org/comment/3063556/","msgid":"<CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>","list_archive_url":null,"date":"2023-02-22T21:20:58","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":85861,"url":"http://patchwork.ozlabs.org/api/people/85861/","name":"Martin Rowe","email":"martin.p.rowe@gmail.com"},"content":"Hi\n\n> Could you send a patch which adds appropriate defconfig file for SPI\n> boot? So this configuration would be tested in U-Boot CI automatically.\n\nWill do. Does it need to be the same as the other defconfigs\notherwise? I suggest putting the environment in SPI as well if u-boot\nis already there (default is MMC).\n\n> Have you tried booting from eMMC boot partition or eMMC user data\n> partition? Because all 3 options should work, but I'm not fully sure if\n> BootROM choose partition from eMMC register or if tries all 3 in some\n> order. This is something which needs to be checked and verified.\n\nI only tested from boot0, but will test the others as well. I've only\never seen it fallback, but I'll check the new changes and see if they\ncan select the boot device.\n\n> Could you try to use SolidRun eMMC patch which SolidRun has for years in\n> its repository?\n>\n> https://github.com/SolidRun/u-boot/commit/19a96f7c40a8fc1d0a6546ac2418d966e5840a99\n>\n> Probably same functionality is needed to implement also into\n> board_fix_fdt() function enabled by CONFIG_OF_BOARD_FIXUP. Look for\n> other boards how they use CONFIG_OF_BOARD_FIXUP.\n>\n> And if ... you can try to put this logic in board_late_init() function.\n> For inspiration look into Espressobin board which deactivates eMMC at\n> runtime by checking existence of eMMC:\n> https://source.denx.de/u-boot/u-boot/-/blob/master/board/Marvell/mvebu_armada-37xx/board.c\n\nThis is still on my TODO from earlier discussions.\n\n> There is still missing documentation for kwbimage config file format.\n> It should be in \"kwbimage\" section of ./doc/mkimage.1 file but there is\n> only placeholder... It would be nice if somebody can take it and write\n> it.\n\nI'm not sure if I have the expertise for this, but can take a look as well.\n\nMartin","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=YviAkVNb;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"YviAkVNb\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=martin.p.rowe@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMTdq5Z9Xz245s\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 08:22:55 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8F44C85B33;\n\tWed, 22 Feb 2023 22:22:18 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 2F9C885B19; Wed, 22 Feb 2023 22:21:20 +0100 (CET)","from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com\n [IPv6:2607:f8b0:4864:20::c35])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C61A585B2A\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 22:21:10 +0100 (CET)","by mail-oo1-xc35.google.com with SMTP id\n c184-20020a4a4fc1000000b005250b2dc0easo509138oob.2\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 13:21:10 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=jCpqU9lsBAceOBeTA5jyDqA0lMLFDm/ARer6J9QtaeA=;\n b=YviAkVNbJ2U0UyDU6Kd0ng3V1gfeE+FpC566nZ3ws+P75lHNg0fV0ONQwNlAxtAvDp\n F1qCEAVMaO/E+KvXgeio0BU2Q0iLHhNeSb/sdrO7lE0B8JleXKWPaeny8mt+h18hPWh5\n VpnhqdT+jpR9xoZ65hlSpL8qoUIw2K+dJDyIy+IZgBnDV/l3h2ZYsen4boQMMdGRfnJH\n Jm7YxrASbqlpZ1Ozkko0m4BQ3/HxrsaGq3Y6ThR4WveoHKVyc8DzTCVO9//AKaUvtygx\n H7ZH0VJNa/0kd7aan18IPaadM8B76/WAQ/gzn8MIaG7WCtLjmKRSxq8ysSgCVy3Jxsv4\n ejSg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=jCpqU9lsBAceOBeTA5jyDqA0lMLFDm/ARer6J9QtaeA=;\n b=m5LjZMAiK+h/ORvIELJ2g3wCB/lyuamyihzyS6ycD9rSlUFfOzSLkWUvwJY590g1RP\n 84an0UVvGkba7lw0qXFOkWD8eNCW9bW4acfeTMx8SZgS6DgkH4tw8aVPeDeWrVKWgHU8\n SkcwWxLbUO6aSw3ubkyVZAwmYhYdzGlwuTjQgJLyX4v1Z+TNHBZb99T8PO3Tlm+pRQS/\n VMgL6evaoNYRA+1g6/IuQUonQ/XE/nNuGYP4xzyNKoSl80dDtMc0Obl6UY4fspkGCUsD\n wS1BUZ4iiu4uOzeTZIazZSqIcgqJ/c0WfACuVsmTmtJL/ZqO8DL34miKa/QUC2yeXjrr\n lVHQ==","X-Gm-Message-State":"AO0yUKVXwWezOYnAcD8DnuTtkaauf39bP9qEFrcipoR3Yab6M0e5JDNp\n IeKRMkweMRjlQ8S9k79Z2/8L2KHJ0xgc4wi+lrM=","X-Google-Smtp-Source":"\n AK7set+Q3h+9mYaWjh4bN+qfSsftn1o8wFAy6mCqPrYJHq1or7hVLebXeqDEAiYYTW9qGi6ynF3MSFFA8D8yIiW54fE=","X-Received":"by 2002:a4a:625d:0:b0:517:6c7c:631f with SMTP id\n y29-20020a4a625d000000b005176c7c631fmr809569oog.1.1677100869375; Wed, 22 Feb\n 2023 13:21:09 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>","In-Reply-To":"<20230222180307.7sxot7ivfx3elunx@pali>","From":"Martin Rowe <martin.p.rowe@gmail.com>","Date":"Wed, 22 Feb 2023 21:20:58 +0000","Message-ID":"\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063570,"web_url":"http://patchwork.ozlabs.org/comment/3063570/","msgid":"<20230222212356.abfhl7omg35hwizc@pali>","list_archive_url":null,"date":"2023-02-22T21:23:56","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Wednesday 22 February 2023 21:20:58 Martin Rowe wrote:\n> Hi\n> \n> > Could you send a patch which adds appropriate defconfig file for SPI\n> > boot? So this configuration would be tested in U-Boot CI automatically.\n> \n> Will do. Does it need to be the same as the other defconfigs\n> otherwise? I suggest putting the environment in SPI as well if u-boot\n> is already there (default is MMC).\n\nYes, it makes sense.\n\n> > Have you tried booting from eMMC boot partition or eMMC user data\n> > partition? Because all 3 options should work, but I'm not fully sure if\n> > BootROM choose partition from eMMC register or if tries all 3 in some\n> > order. This is something which needs to be checked and verified.\n> \n> I only tested from boot0, but will test the others as well. I've only\n> ever seen it fallback, but I'll check the new changes and see if they\n> can select the boot device.\n\nOk. When testing, ensure that you erase uboots from other partitions or\ncheck that it boots the correct version from the correction partition.\n\n> > Could you try to use SolidRun eMMC patch which SolidRun has for years in\n> > its repository?\n> >\n> > https://github.com/SolidRun/u-boot/commit/19a96f7c40a8fc1d0a6546ac2418d966e5840a99\n> >\n> > Probably same functionality is needed to implement also into\n> > board_fix_fdt() function enabled by CONFIG_OF_BOARD_FIXUP. Look for\n> > other boards how they use CONFIG_OF_BOARD_FIXUP.\n> >\n> > And if ... you can try to put this logic in board_late_init() function.\n> > For inspiration look into Espressobin board which deactivates eMMC at\n> > runtime by checking existence of eMMC:\n> > https://source.denx.de/u-boot/u-boot/-/blob/master/board/Marvell/mvebu_armada-37xx/board.c\n> \n> This is still on my TODO from earlier discussions.\n> \n> > There is still missing documentation for kwbimage config file format.\n> > It should be in \"kwbimage\" section of ./doc/mkimage.1 file but there is\n> > only placeholder... It would be nice if somebody can take it and write\n> > it.\n> \n> I'm not sure if I have the expertise for this, but can take a look as well.\n> \n> Martin\n\nOk.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=JNpQKO1Q;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"JNpQKO1Q\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMTjW6SZCz23yr\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 08:26:07 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0F51585B7D;\n\tWed, 22 Feb 2023 22:25:17 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 00E6685B8C; Wed, 22 Feb 2023 22:24:11 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9EB81809A6\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 22:24:01 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id A2BF2615B1;\n Wed, 22 Feb 2023 21:23:59 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 1853EC433D2;\n Wed, 22 Feb 2023 21:23:59 +0000 (UTC)","by pali.im (Postfix)\n id 5D5BE72C; Wed, 22 Feb 2023 22:23:56 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677101039;\n bh=FLYJH/buXBJAFZCs8yU2lgimOApFsfwc7uiAtqTXpNs=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=JNpQKO1QUR2NveSPAk2KBKcOTCDb1rf/xE7UYagt6A1T8oRv7kkL+1w6O3J1a1LRy\n kLRUEIIHqgc/VjK4bmlqMi8AnBQExhinfijzpVGnMPGFrYY9yqwXLpBRaHFNJZvqvP\n +ktuXIpDk1uSTwd+1igb/XW7aeVx0EXLoBgb0v6aP9zmzlFtVmGnlXAmoncaxwc+8I\n fDL77XZa4XSgh56D5PRDyO3IYtLVuy9FfDWl9Ac+pMdl33aiWiPFFP07yqSmn4dMk9\n g3CLMudVlRamdlVo+kaKmeYyd45JEYSUC3Rzz/WshW7ANUdhELyyl+0dGC4cI7zXH4\n etvJfVK+zW4bQ==","Date":"Wed, 22 Feb 2023 22:23:56 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Martin Rowe <martin.p.rowe@gmail.com>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230222212356.abfhl7omg35hwizc@pali>","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063593,"web_url":"http://patchwork.ozlabs.org/comment/3063593/","msgid":"<CAJaLiFy-MCy97ybv83wx5TBp1iu_VzEWxSPMV_421dYohdn3yg@mail.gmail.com>","list_archive_url":null,"date":"2023-02-22T22:16:36","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":74035,"url":"http://patchwork.ozlabs.org/api/people/74035/","name":"Tony Dinh","email":"mibodhi@gmail.com"},"content":"Hi Pali,\n\nOn Tue, Feb 21, 2023 at 11:58 PM Pali Rohár <pali@kernel.org> wrote:\n>\n> On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote:\n> > Hi Pali,\n> >\n> > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali@kernel.org> wrote:\n> > >\n> > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> > > > Hi Pali,\n> > > >\n> > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > >\n> > > > > This patch series contains various improvements and fixes for existing\n> > > > > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > > > > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > > > > Important information are included in documentation patch for kwboot.\n> > > > > Most of the changes are untested, hence this patch series is just RFC.\n> > > > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > > > > Nevertheless all patches on github passed CI testing in this PR:\n> > > > > https://github.com/u-boot/u-boot/pull/275\n> > > ...\n> > > > I went to patchwork and downloaded the series.\n> > > > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> > > >\n> > > > When I applied the patches set there were some rejections.\n> > > > <BEGIN LOG>\n> > > > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> > > >\n> > > ...\n> > > FAILED\n> > > ...\n> > > > <END LOG>\n> > > >\n> > > > I'm on the latest master branch (just did a git pull today). Could\n> > > > some patches be out of order?\n> > > >\n> > > > Thanks,\n> > > > Tony\n> > >\n> > > Well, that is because DENX mail server is broken and it crashed during\n> > > processing antispam filter on my some of my patches. So some patches are\n> > > missing in archive and then applying dependent patches failed.\n> > >\n> > > So ignore patchwork and email patches. Rather fetch changes from the\n> > > mentioned github pull request https://github.com/u-boot/u-boot/pull/275\n> > >\n> > > You can do it via git command (it fetch it to the new mvebu branch):\n> > >\n> > >   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu\n> >\n> > Indeed! That pull request was applied without problem.\n> >\n> > So I did a general regression test running rebuilt kwboot binary, and\n> > rebuilt u-boot images for these 2 Marvell boards:\n> >\n> > Thecus N2350 (Armada 385)\n> > Pogo V4 (Kirkwood 88F6192).\n> >\n> > So for that part:\n> > Tested-by: Tony Dinh <mibodhi@gmail.com>\n> >\n> > All the best,\n> > Tony\n>\n> Thanks for testing! Anyway do you have some A38x board which can boot\n> from SD/MMC, SATA or NAND? This is what is needed to test too. I see\n> that Pogo boots from NAND but it does not use SPL.\n\nI have only one A38x board with NAND: the Thecus N2350. I am creating\na new defconfig and will see if I can boot it from the NAND flash.\n\nBy the way, I'm having this build error that CFG_SYS_NAND_BASE is not\ndefined. What should it be for A38x? is it the same for Kirkwood?\n\nAll the best,\nTony","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=SNSaEVxL;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"SNSaEVxL\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=mibodhi@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMVrG1dwZz240V\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 09:17:00 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D027685903;\n\tWed, 22 Feb 2023 23:16:53 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 4397985738; Wed, 22 Feb 2023 23:16:52 +0100 (CET)","from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com\n [IPv6:2607:f8b0:4864:20::e2d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0BE3E85738\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 23:16:49 +0100 (CET)","by mail-vs1-xe2d.google.com with SMTP id v3so11457444vse.0\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 14:16:48 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XriQUv0LNPhj/5l0Y+VmdmUrdkv8KzCl5x6v9JDu32M=;\n b=SNSaEVxLOe+sixrQ4bLu6UEAZfNfhRnwIJVKYkX0ZY2RXvvIazDzqwg0nrOcNHx203\n 9R0GQx3x0F87rPrJUwaDelk53xJS9LwpkO+qALCXbZr4TniN9CgoFJE9Fbof7piUIjy+\n xJptNS0RD0Sn4KdC4eUNu9eqLnqBzfplHtPyxOvc5h2u4gsR0HI+I0BCYdiJEoLpoYGp\n GS7NoK/aNEAT9C9JaSbYy3MqOOFTJC9pKRQvo8X23/Z+Sd3JxORe8izXGYHIkNYZpcGy\n GtKifIKtecOmV0XKcHf9LabLg72RtM/tWbSGXfNGqaG2wvr/P3Gu8GeRaRZEl21dzi7Q\n 1vGA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=XriQUv0LNPhj/5l0Y+VmdmUrdkv8KzCl5x6v9JDu32M=;\n b=2uaNNumGww1sNhaEs4Bu9osgW9ldxM4RaPT0uMGfmmxHnOPoxk7kocdi0J369Va4VD\n sPBSjDNyVG2Fa9xaO68Rn5YgC/MFZjiHDk5xHEOJB9tRnTlxTnW5OghJ3l4Jdxkaoc0o\n MmiYk7CPnZGv+sCO7F0cT9zz0JMMRP7Qe7hG6jOBxNZQOHlsL0/5NaIA7h4acXCB8TEg\n vR4ksrSeOhxxVHy0MdCXxwNyACSS/h3YNx4+JJy6am4KF6HtWOGcsx25eUNfMVBLQxT+\n igTEBCwJJCNpmrTTf30YNEMYip9vBUTeQ0Np90U5DzSEsWNPN7c2+I/cQUg9sbwgbWb0\n chZQ==","X-Gm-Message-State":"AO0yUKVTZMDQxctQrFqK3jxqywbv2TWSP6UFiYEPIpcT5MUr2YP2yMWH\n NlRoVle0F1vTySesp82iAJOc0T2Q0xl/qY+CDp0=","X-Google-Smtp-Source":"\n AK7set9jD6VEa05GR7PWXkpbhhqfxMbUbheJS0zWguyFK6cxhrhn9/mIcgXsYwOrF20WZhWQtPxVPzoMoastTjnQezg=","X-Received":"by 2002:a9f:315a:0:b0:68a:6c1e:1aab with SMTP id\n n26-20020a9f315a000000b0068a6c1e1aabmr1900003uab.2.1677104207690; Wed, 22 Feb\n 2023 14:16:47 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>","In-Reply-To":"<20230222075819.6f3vl7nlnpqwpg6e@pali>","From":"Tony Dinh <mibodhi@gmail.com>","Date":"Wed, 22 Feb 2023 14:16:36 -0800","Message-ID":"\n <CAJaLiFy-MCy97ybv83wx5TBp1iu_VzEWxSPMV_421dYohdn3yg@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063621,"web_url":"http://patchwork.ozlabs.org/comment/3063621/","msgid":"<20230222230647.rfn5vkz2zeyqadz5@pali>","list_archive_url":null,"date":"2023-02-22T23:06:47","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Wednesday 22 February 2023 14:16:36 Tony Dinh wrote:\n> Hi Pali,\n> \n> On Tue, Feb 21, 2023 at 11:58 PM Pali Rohár <pali@kernel.org> wrote:\n> >\n> > On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote:\n> > > Hi Pali,\n> > >\n> > > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali@kernel.org> wrote:\n> > > >\n> > > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> > > > > Hi Pali,\n> > > > >\n> > > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > > >\n> > > > > > This patch series contains various improvements and fixes for existing\n> > > > > > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > > > > > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > > > > > Important information are included in documentation patch for kwboot.\n> > > > > > Most of the changes are untested, hence this patch series is just RFC.\n> > > > > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > > > > > Nevertheless all patches on github passed CI testing in this PR:\n> > > > > > https://github.com/u-boot/u-boot/pull/275\n> > > > ...\n> > > > > I went to patchwork and downloaded the series.\n> > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> > > > >\n> > > > > When I applied the patches set there were some rejections.\n> > > > > <BEGIN LOG>\n> > > > > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> > > > >\n> > > > ...\n> > > > FAILED\n> > > > ...\n> > > > > <END LOG>\n> > > > >\n> > > > > I'm on the latest master branch (just did a git pull today). Could\n> > > > > some patches be out of order?\n> > > > >\n> > > > > Thanks,\n> > > > > Tony\n> > > >\n> > > > Well, that is because DENX mail server is broken and it crashed during\n> > > > processing antispam filter on my some of my patches. So some patches are\n> > > > missing in archive and then applying dependent patches failed.\n> > > >\n> > > > So ignore patchwork and email patches. Rather fetch changes from the\n> > > > mentioned github pull request https://github.com/u-boot/u-boot/pull/275\n> > > >\n> > > > You can do it via git command (it fetch it to the new mvebu branch):\n> > > >\n> > > >   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu\n> > >\n> > > Indeed! That pull request was applied without problem.\n> > >\n> > > So I did a general regression test running rebuilt kwboot binary, and\n> > > rebuilt u-boot images for these 2 Marvell boards:\n> > >\n> > > Thecus N2350 (Armada 385)\n> > > Pogo V4 (Kirkwood 88F6192).\n> > >\n> > > So for that part:\n> > > Tested-by: Tony Dinh <mibodhi@gmail.com>\n> > >\n> > > All the best,\n> > > Tony\n> >\n> > Thanks for testing! Anyway do you have some A38x board which can boot\n> > from SD/MMC, SATA or NAND? This is what is needed to test too. I see\n> > that Pogo boots from NAND but it does not use SPL.\n> \n> I have only one A38x board with NAND: the Thecus N2350. I am creating\n> a new defconfig and will see if I can boot it from the NAND flash.\n\nOk. And do you have some switch on this board which instruct BootROM to\nreally boot from NAND?\n\n> By the way, I'm having this build error that CFG_SYS_NAND_BASE is not\n> defined. What should it be for A38x? is it the same for Kirkwood?\n> \n> All the best,\n> Tony\n\nIs SYS_NAND_BASE really needed? If yet then I think it should be macro\nMVEBU_NAND_BASE.\n\nBut on Kirkwood is SYS_NAND_BASE set to the DEFADR_NANDF value which is\nmemory mapping of NAND device via mbus. On Armada devices is not NAND\ndevice mbus mapped at all and MVEBU_NAND_BASE points to internal mvebu\nregisters. So I'm quite not sure if it would work.\n\nSo lets try with MVEBU_NAND_BASE.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=cmCA53Fs;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"cmCA53Fs\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMWxy72Pkz245s\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 10:07:02 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 40494859EE;\n\tThu, 23 Feb 2023 00:06:57 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 07B6285ABB; Thu, 23 Feb 2023 00:06:56 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id F3E1B859EE\n for <u-boot@lists.denx.de>; Thu, 23 Feb 2023 00:06:52 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 371AA615B0;\n Wed, 22 Feb 2023 23:06:51 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 6037FC433D2;\n Wed, 22 Feb 2023 23:06:50 +0000 (UTC)","by pali.im (Postfix)\n id BC7E372C; Thu, 23 Feb 2023 00:06:47 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677107210;\n bh=Sj/I17qY799L6aEzecJonZfILh9PrAyZrkRZfJTunso=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=cmCA53Fs2QmJU+YCldkS5HVWrbdvk4Faspr+Ir0g/N/C+xRUwEefNOYbl084N1aeX\n VDIE7s3c9++QyTlZNjX4ZXMV9sGbYcQSrIzCZtfR/G7VIYu8b8fheM7TGRa6UAkWHz\n ASq/VZTaz7rcdfGQ1EKby7X7ffPgX1nH0SKemREyREP/6ywTBSDVhu1PP6nle4+Rqf\n /Lb3avxewE+hGE/LncGo5nhhF0eoBDe/ewTRco5MJ/Y35SA3+uI39Xy6s5a9MxPX73\n UUkQ+w3RQvd32zam867z4rQ26izyFU2XkXbe8l+7FGJARToCNBlhuxqGRFSAw4Hd4S\n xLXIL6if50pCA==","Date":"Thu, 23 Feb 2023 00:06:47 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Tony Dinh <mibodhi@gmail.com>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230222230647.rfn5vkz2zeyqadz5@pali>","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAJaLiFy-MCy97ybv83wx5TBp1iu_VzEWxSPMV_421dYohdn3yg@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"\n <CAJaLiFy-MCy97ybv83wx5TBp1iu_VzEWxSPMV_421dYohdn3yg@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063622,"web_url":"http://patchwork.ozlabs.org/comment/3063622/","msgid":"<CAJaLiFwmTTqGL0ZGeGfcmAKns+fAyUfJC060RWe+vEqR-4Fq6g@mail.gmail.com>","list_archive_url":null,"date":"2023-02-22T23:16:06","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":74035,"url":"http://patchwork.ozlabs.org/api/people/74035/","name":"Tony Dinh","email":"mibodhi@gmail.com"},"content":"Hi Pali,\n\nOn Wed, Feb 22, 2023 at 3:06 PM Pali Rohár <pali@kernel.org> wrote:\n>\n> On Wednesday 22 February 2023 14:16:36 Tony Dinh wrote:\n> > Hi Pali,\n> >\n> > On Tue, Feb 21, 2023 at 11:58 PM Pali Rohár <pali@kernel.org> wrote:\n> > >\n> > > On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote:\n> > > > Hi Pali,\n> > > >\n> > > > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > >\n> > > > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> > > > > > Hi Pali,\n> > > > > >\n> > > > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > > > >\n> > > > > > > This patch series contains various improvements and fixes for existing\n> > > > > > > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > > > > > > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > > > > > > Important information are included in documentation patch for kwboot.\n> > > > > > > Most of the changes are untested, hence this patch series is just RFC.\n> > > > > > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > > > > > > Nevertheless all patches on github passed CI testing in this PR:\n> > > > > > > https://github.com/u-boot/u-boot/pull/275\n> > > > > ...\n> > > > > > I went to patchwork and downloaded the series.\n> > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> > > > > >\n> > > > > > When I applied the patches set there were some rejections.\n> > > > > > <BEGIN LOG>\n> > > > > > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> > > > > >\n> > > > > ...\n> > > > > FAILED\n> > > > > ...\n> > > > > > <END LOG>\n> > > > > >\n> > > > > > I'm on the latest master branch (just did a git pull today). Could\n> > > > > > some patches be out of order?\n> > > > > >\n> > > > > > Thanks,\n> > > > > > Tony\n> > > > >\n> > > > > Well, that is because DENX mail server is broken and it crashed during\n> > > > > processing antispam filter on my some of my patches. So some patches are\n> > > > > missing in archive and then applying dependent patches failed.\n> > > > >\n> > > > > So ignore patchwork and email patches. Rather fetch changes from the\n> > > > > mentioned github pull request https://github.com/u-boot/u-boot/pull/275\n> > > > >\n> > > > > You can do it via git command (it fetch it to the new mvebu branch):\n> > > > >\n> > > > >   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu\n> > > >\n> > > > Indeed! That pull request was applied without problem.\n> > > >\n> > > > So I did a general regression test running rebuilt kwboot binary, and\n> > > > rebuilt u-boot images for these 2 Marvell boards:\n> > > >\n> > > > Thecus N2350 (Armada 385)\n> > > > Pogo V4 (Kirkwood 88F6192).\n> > > >\n> > > > So for that part:\n> > > > Tested-by: Tony Dinh <mibodhi@gmail.com>\n> > > >\n> > > > All the best,\n> > > > Tony\n> > >\n> > > Thanks for testing! Anyway do you have some A38x board which can boot\n> > > from SD/MMC, SATA or NAND? This is what is needed to test too. I see\n> > > that Pogo boots from NAND but it does not use SPL.\n> >\n> > I have only one A38x board with NAND: the Thecus N2350. I am creating\n> > a new defconfig and will see if I can boot it from the NAND flash.\n>\n> Ok. And do you have some switch on this board which instruct BootROM to\n> really boot from NAND?\n\nNo switch that I can see. So I'm going to erase the u-boot image in\nSPI to let the BootROM try booting from NAND.\n\n>\n> > By the way, I'm having this build error that CFG_SYS_NAND_BASE is not\n> > defined. What should it be for A38x? is it the same for Kirkwood?\n> >\n> > All the best,\n> > Tony\n>\n> Is SYS_NAND_BASE really needed? If yet then I think it should be macro\n> MVEBU_NAND_BASE.\n\nThe build error looks like this:\ndrivers/mtd/nand/raw/nand.c:15:34: error: ‘CFG_SYS_NAND_BASE’\nundeclared here (not in a function); did you mean\n‘CFG_SYS_PL310_BASE’?\n   15 | #define CFG_SYS_NAND_BASE_LIST { CFG_SYS_NAND_BASE }\n\n>\n> But on Kirkwood is SYS_NAND_BASE set to the DEFADR_NANDF value which is\n> memory mapping of NAND device via mbus. On Armada devices is not NAND\n> device mbus mapped at all and MVEBU_NAND_BASE points to internal mvebu\n> registers. So I'm quite not sure if it would work.\n>\n> So lets try with MVEBU_NAND_BASE.\n\nOK.\n\nThanks,\nTony","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=qTOd9cIU;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"qTOd9cIU\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=mibodhi@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMX8s6HvKz240V\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 10:16:29 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3974E85AFC;\n\tThu, 23 Feb 2023 00:16:24 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 14AB085988; Thu, 23 Feb 2023 00:16:22 +0100 (CET)","from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com\n [IPv6:2607:f8b0:4864:20::e36])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id CCCD885A08\n for <u-boot@lists.denx.de>; Thu, 23 Feb 2023 00:16:18 +0100 (CET)","by mail-vs1-xe36.google.com with SMTP id f23so11697788vsa.13\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 15:16:18 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=uSNYn+5Fnc4LC04laV+xe4RPvVlSxvQ7vFDFJ7e/aCY=;\n b=qTOd9cIUwa7XzpCyJ/Kui+OLgLJu6ZIJ0ylv6Tfvgy1A86kBkWQWma9J4ZuTnbTgr7\n Ta07lUcYQdlRpbi/AngUkubtPcVf5u/nQQA6qrvSZducwzEmcvJSIGF5tvSrdXcHr0h/\n UWiqCIzWngPWzdCIMqDs3lev8sgJQpJANHL7lmz+4WN8fbqikzZ1YX0vjADfLzcfNVr4\n iOFrmi8gSfxS10gmPgFFSjio5fLVUvTbU33avLGDrfONBeYF5AlBC+vGdQUVDlqUWCGg\n M6OxYAeVvOQhlJaCUSKV5c9ayOEvMS4c1pxykSTL5qaJFZX3WB0uxpckXQdH0o9rW8dh\n p8rw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=uSNYn+5Fnc4LC04laV+xe4RPvVlSxvQ7vFDFJ7e/aCY=;\n b=dHPg4mUrbXfxgbSqFfls7pBYBUrJaHxRvWtgt3eUVP+tgeGVGy3xmomqHFbW8HNRde\n Ws03r8mBSj83oFE9w47GyimKUM11lajWsJpC5sA7Fggy2LzfjoR8grfIXRY9GSOyRgV3\n MAcyVV1YrC3YkHLDgCU5DTCCaEDbtabtm/wGxYTfBnjqlwireA2lfd6Ipylsla/kXfi2\n 30zAAIH+c7cTiTKFOFLmTyabquCWkzaJ/fh4RXI9zCu2jy/+ce/FMdvSuIKovYXb3pvA\n nr714ws8qU6Zh4Z+PoOw2g478vguIurwfKmbCN9+EDAlIWg1RkS/Lr1FxVvf84i1ADcV\n sNAA==","X-Gm-Message-State":"AO0yUKXOkBUmVBx4Yn7Xj4Ku7Hfbzczn+LwyasxhDO+WLmWsuv+nL8cR\n QtsgKL6bDWANRM/7gLm7mc2EOj+jScFyxiYPfTA=","X-Google-Smtp-Source":"\n AK7set9UQaYg0R0AFLtBUSwY5PUVZ7iGMpp6O2/+gVJH4O/vfIARkLenavs/KSvDkLPGUcCtsZmVT45q25UC4Yv8si8=","X-Received":"by 2002:a05:6102:f98:b0:401:1444:817c with SMTP id\n e24-20020a0561020f9800b004011444817cmr3144826vsv.17.1677107777297; Wed, 22\n Feb 2023 15:16:17 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAJaLiFy-MCy97ybv83wx5TBp1iu_VzEWxSPMV_421dYohdn3yg@mail.gmail.com>\n <20230222230647.rfn5vkz2zeyqadz5@pali>","In-Reply-To":"<20230222230647.rfn5vkz2zeyqadz5@pali>","From":"Tony Dinh <mibodhi@gmail.com>","Date":"Wed, 22 Feb 2023 15:16:06 -0800","Message-ID":"\n <CAJaLiFwmTTqGL0ZGeGfcmAKns+fAyUfJC060RWe+vEqR-4Fq6g@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063633,"web_url":"http://patchwork.ozlabs.org/comment/3063633/","msgid":"<20230222233957.lb6jrsdqkffw3yn5@pali>","list_archive_url":null,"date":"2023-02-22T23:39:57","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Wednesday 22 February 2023 15:16:06 Tony Dinh wrote:\n> Hi Pali,\n> \n> On Wed, Feb 22, 2023 at 3:06 PM Pali Rohár <pali@kernel.org> wrote:\n> >\n> > On Wednesday 22 February 2023 14:16:36 Tony Dinh wrote:\n> > > Hi Pali,\n> > >\n> > > On Tue, Feb 21, 2023 at 11:58 PM Pali Rohár <pali@kernel.org> wrote:\n> > > >\n> > > > On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote:\n> > > > > Hi Pali,\n> > > > >\n> > > > > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > > >\n> > > > > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> > > > > > > Hi Pali,\n> > > > > > >\n> > > > > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > > > > >\n> > > > > > > > This patch series contains various improvements and fixes for existing\n> > > > > > > > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > > > > > > > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > > > > > > > Important information are included in documentation patch for kwboot.\n> > > > > > > > Most of the changes are untested, hence this patch series is just RFC.\n> > > > > > > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > > > > > > > Nevertheless all patches on github passed CI testing in this PR:\n> > > > > > > > https://github.com/u-boot/u-boot/pull/275\n> > > > > > ...\n> > > > > > > I went to patchwork and downloaded the series.\n> > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> > > > > > >\n> > > > > > > When I applied the patches set there were some rejections.\n> > > > > > > <BEGIN LOG>\n> > > > > > > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> > > > > > >\n> > > > > > ...\n> > > > > > FAILED\n> > > > > > ...\n> > > > > > > <END LOG>\n> > > > > > >\n> > > > > > > I'm on the latest master branch (just did a git pull today). Could\n> > > > > > > some patches be out of order?\n> > > > > > >\n> > > > > > > Thanks,\n> > > > > > > Tony\n> > > > > >\n> > > > > > Well, that is because DENX mail server is broken and it crashed during\n> > > > > > processing antispam filter on my some of my patches. So some patches are\n> > > > > > missing in archive and then applying dependent patches failed.\n> > > > > >\n> > > > > > So ignore patchwork and email patches. Rather fetch changes from the\n> > > > > > mentioned github pull request https://github.com/u-boot/u-boot/pull/275\n> > > > > >\n> > > > > > You can do it via git command (it fetch it to the new mvebu branch):\n> > > > > >\n> > > > > >   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu\n> > > > >\n> > > > > Indeed! That pull request was applied without problem.\n> > > > >\n> > > > > So I did a general regression test running rebuilt kwboot binary, and\n> > > > > rebuilt u-boot images for these 2 Marvell boards:\n> > > > >\n> > > > > Thecus N2350 (Armada 385)\n> > > > > Pogo V4 (Kirkwood 88F6192).\n> > > > >\n> > > > > So for that part:\n> > > > > Tested-by: Tony Dinh <mibodhi@gmail.com>\n> > > > >\n> > > > > All the best,\n> > > > > Tony\n> > > >\n> > > > Thanks for testing! Anyway do you have some A38x board which can boot\n> > > > from SD/MMC, SATA or NAND? This is what is needed to test too. I see\n> > > > that Pogo boots from NAND but it does not use SPL.\n> > >\n> > > I have only one A38x board with NAND: the Thecus N2350. I am creating\n> > > a new defconfig and will see if I can boot it from the NAND flash.\n> >\n> > Ok. And do you have some switch on this board which instruct BootROM to\n> > really boot from NAND?\n> \n> No switch that I can see. So I'm going to erase the u-boot image in\n> SPI to let the BootROM try booting from NAND.\n\nBootROM on 32-bit mvebu SoCs always boots from the location configured\nby strapping pins. So if you do not have any switch (or possible\nsoldered zero-ohm resistors) on the board then I doubt that BootROM will\ntry to boot from NAND.\n\n> >\n> > > By the way, I'm having this build error that CFG_SYS_NAND_BASE is not\n> > > defined. What should it be for A38x? is it the same for Kirkwood?\n> > >\n> > > All the best,\n> > > Tony\n> >\n> > Is SYS_NAND_BASE really needed? If yet then I think it should be macro\n> > MVEBU_NAND_BASE.\n> \n> The build error looks like this:\n> drivers/mtd/nand/raw/nand.c:15:34: error: ‘CFG_SYS_NAND_BASE’\n> undeclared here (not in a function); did you mean\n> ‘CFG_SYS_PL310_BASE’?\n>    15 | #define CFG_SYS_NAND_BASE_LIST { CFG_SYS_NAND_BASE }\n> \n\nI see... Maybe you can try to enable SYS_NAND_SELF_INIT.\n\n> >\n> > But on Kirkwood is SYS_NAND_BASE set to the DEFADR_NANDF value which is\n> > memory mapping of NAND device via mbus. On Armada devices is not NAND\n> > device mbus mapped at all and MVEBU_NAND_BASE points to internal mvebu\n> > registers. So I'm quite not sure if it would work.\n> >\n> > So lets try with MVEBU_NAND_BASE.\n> \n> OK.\n> \n> Thanks,\n> Tony","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Cp9HXRy3;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"Cp9HXRy3\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMXhS2xZKz23yr\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 10:40:22 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 621CF85988;\n\tThu, 23 Feb 2023 00:40:10 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 5C9F080AE2; Thu, 23 Feb 2023 00:40:07 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2944085988\n for <u-boot@lists.denx.de>; Thu, 23 Feb 2023 00:40:03 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id CFCC6615A1;\n Wed, 22 Feb 2023 23:40:00 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 046CCC433EF;\n Wed, 22 Feb 2023 23:40:00 +0000 (UTC)","by pali.im (Postfix)\n id 202C472C; Thu, 23 Feb 2023 00:39:57 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677109200;\n bh=C4Uo6XTrrdIFu5UHBfmuWoW9np/0Gd0bTzEdTDkFE1g=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=Cp9HXRy3w9FXjxo9de62HUYkb79b/Up/yvSnCSz7gTLJvLEbR1LZEM5gtdNnQcRCW\n WZ3RwfxuSUR/zKM3aT4xAYHUPU1zq4ZiQxkoblcCnV5iu6dSLJpTgG2tLKq9DDj1N7\n 8mjCIjrzjIda/ucTUt5OvEgBKNdHgou5bCMSG/E+Ypv++Xe8FA4dVBYgjAAmgwyMDV\n 1ryTJkbUOuun4pmKGAESC2tJX2dL10rbScdlKHwW8U5Fym4eKz0tsUACibl71ZTKMP\n 7gjX4sTQHXQcYfO5UGgzIpsa3GlsHYzrb54mJvY3iKUNqdQsYC0Zas6rQTxUJGt+Nk\n 5eMl7GfAlo4og==","Date":"Thu, 23 Feb 2023 00:39:57 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Tony Dinh <mibodhi@gmail.com>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230222233957.lb6jrsdqkffw3yn5@pali>","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAJaLiFy-MCy97ybv83wx5TBp1iu_VzEWxSPMV_421dYohdn3yg@mail.gmail.com>\n <20230222230647.rfn5vkz2zeyqadz5@pali>\n <CAJaLiFwmTTqGL0ZGeGfcmAKns+fAyUfJC060RWe+vEqR-4Fq6g@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"\n <CAJaLiFwmTTqGL0ZGeGfcmAKns+fAyUfJC060RWe+vEqR-4Fq6g@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063637,"web_url":"http://patchwork.ozlabs.org/comment/3063637/","msgid":"<CAJaLiFxshNa1izFfFRVS1LiFS_osbBf6yhhdMpji1E=dt44S5g@mail.gmail.com>","list_archive_url":null,"date":"2023-02-23T00:17:32","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":74035,"url":"http://patchwork.ozlabs.org/api/people/74035/","name":"Tony Dinh","email":"mibodhi@gmail.com"},"content":"Hi Pali,\n\nOn Wed, Feb 22, 2023 at 3:40 PM Pali Rohár <pali@kernel.org> wrote:\n>\n> On Wednesday 22 February 2023 15:16:06 Tony Dinh wrote:\n> > Hi Pali,\n> >\n> > On Wed, Feb 22, 2023 at 3:06 PM Pali Rohár <pali@kernel.org> wrote:\n> > >\n> > > On Wednesday 22 February 2023 14:16:36 Tony Dinh wrote:\n> > > > Hi Pali,\n> > > >\n> > > > On Tue, Feb 21, 2023 at 11:58 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > >\n> > > > > On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote:\n> > > > > > Hi Pali,\n> > > > > >\n> > > > > > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > > > >\n> > > > > > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> > > > > > > > Hi Pali,\n> > > > > > > >\n> > > > > > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > > > > > >\n> > > > > > > > > This patch series contains various improvements and fixes for existing\n> > > > > > > > > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > > > > > > > > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > > > > > > > > Important information are included in documentation patch for kwboot.\n> > > > > > > > > Most of the changes are untested, hence this patch series is just RFC.\n> > > > > > > > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > > > > > > > > Nevertheless all patches on github passed CI testing in this PR:\n> > > > > > > > > https://github.com/u-boot/u-boot/pull/275\n> > > > > > > ...\n> > > > > > > > I went to patchwork and downloaded the series.\n> > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> > > > > > > >\n> > > > > > > > When I applied the patches set there were some rejections.\n> > > > > > > > <BEGIN LOG>\n> > > > > > > > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> > > > > > > >\n> > > > > > > ...\n> > > > > > > FAILED\n> > > > > > > ...\n> > > > > > > > <END LOG>\n> > > > > > > >\n> > > > > > > > I'm on the latest master branch (just did a git pull today). Could\n> > > > > > > > some patches be out of order?\n> > > > > > > >\n> > > > > > > > Thanks,\n> > > > > > > > Tony\n> > > > > > >\n> > > > > > > Well, that is because DENX mail server is broken and it crashed during\n> > > > > > > processing antispam filter on my some of my patches. So some patches are\n> > > > > > > missing in archive and then applying dependent patches failed.\n> > > > > > >\n> > > > > > > So ignore patchwork and email patches. Rather fetch changes from the\n> > > > > > > mentioned github pull request https://github.com/u-boot/u-boot/pull/275\n> > > > > > >\n> > > > > > > You can do it via git command (it fetch it to the new mvebu branch):\n> > > > > > >\n> > > > > > >   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu\n> > > > > >\n> > > > > > Indeed! That pull request was applied without problem.\n> > > > > >\n> > > > > > So I did a general regression test running rebuilt kwboot binary, and\n> > > > > > rebuilt u-boot images for these 2 Marvell boards:\n> > > > > >\n> > > > > > Thecus N2350 (Armada 385)\n> > > > > > Pogo V4 (Kirkwood 88F6192).\n> > > > > >\n> > > > > > So for that part:\n> > > > > > Tested-by: Tony Dinh <mibodhi@gmail.com>\n> > > > > >\n> > > > > > All the best,\n> > > > > > Tony\n> > > > >\n> > > > > Thanks for testing! Anyway do you have some A38x board which can boot\n> > > > > from SD/MMC, SATA or NAND? This is what is needed to test too. I see\n> > > > > that Pogo boots from NAND but it does not use SPL.\n> > > >\n> > > > I have only one A38x board with NAND: the Thecus N2350. I am creating\n> > > > a new defconfig and will see if I can boot it from the NAND flash.\n> > >\n> > > Ok. And do you have some switch on this board which instruct BootROM to\n> > > really boot from NAND?\n> >\n> > No switch that I can see. So I'm going to erase the u-boot image in\n> > SPI to let the BootROM try booting from NAND.\n>\n> BootROM on 32-bit mvebu SoCs always boots from the location configured\n> by strapping pins. So if you do not have any switch (or possible\n> soldered zero-ohm resistors) on the board then I doubt that BootROM will\n> try to boot from NAND.\n>\nArgh! I misremember that boot flow, it must have been for another SoC.\nThen I guess I have to look at the board again to see if there is any\njumper/switch... Perhaps the other way is to run in the BootROM\ndebugging prompt and set the boot device to NAND?\n\n> > >\n> > > > By the way, I'm having this build error that CFG_SYS_NAND_BASE is not\n> > > > defined. What should it be for A38x? is it the same for Kirkwood?\n> > > >\n> > > > All the best,\n> > > > Tony\n> > >\n> > > Is SYS_NAND_BASE really needed? If yet then I think it should be macro\n> > > MVEBU_NAND_BASE.\n> >\n> > The build error looks like this:\n> > drivers/mtd/nand/raw/nand.c:15:34: error: ‘CFG_SYS_NAND_BASE’\n> > undeclared here (not in a function); did you mean\n> > ‘CFG_SYS_PL310_BASE’?\n> >    15 | #define CFG_SYS_NAND_BASE_LIST { CFG_SYS_NAND_BASE }\n> >\n>\n> I see... Maybe you can try to enable SYS_NAND_SELF_INIT.\n\nThanks, that was it. I did configure the board incorrectly :) I need\nCONFIG_NAND_PXA3XX which selects SYS_NAND_SELF_INIT.\n\nThanks,\nTony\n\n> > >\n> > > But on Kirkwood is SYS_NAND_BASE set to the DEFADR_NANDF value which is\n> > > memory mapping of NAND device via mbus. On Armada devices is not NAND\n> > > device mbus mapped at all and MVEBU_NAND_BASE points to internal mvebu\n> > > registers. So I'm quite not sure if it would work.\n> > >\n> > > So lets try with MVEBU_NAND_BASE.\n> >\n> > OK.\n> >\n> > Thanks,\n> > Tony","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=l7IPpEv6;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"l7IPpEv6\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=mibodhi@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMYWq5Gdbz245s\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 11:17:59 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 9F81A85932;\n\tThu, 23 Feb 2023 01:17:50 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 6BF0B85ACE; Thu, 23 Feb 2023 01:17:48 +0100 (CET)","from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com\n [IPv6:2607:f8b0:4864:20::e33])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BEFD785932\n for <u-boot@lists.denx.de>; Thu, 23 Feb 2023 01:17:44 +0100 (CET)","by mail-vs1-xe33.google.com with SMTP id o6so12512818vsq.10\n for <u-boot@lists.denx.de>; Wed, 22 Feb 2023 16:17:44 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20210112; t=1677111463;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FO+p4tR7UF21nYoDFXSVXirNroZAK5INv9CP5ZrbBho=;\n b=l7IPpEv6AeE2XxogqH7Zm0gFq0//Y2NxbMJF/7QA9cV7jahGrW5u83EKTgEpe6O2TN\n HQmVUVI3bzjdZgmWXY7DIHg8mC2WHGc0IMwrDAwNczIQNANoK6NCeK5rMbYffsMlC7XR\n 9pCuxpys7TgKoNSXisDsH/Cxhwkn8N4FLxgtc3fSwxUFC9sYacegiD7FIT+RfAiftDI8\n z52D23f/4IR3vM8j0pXs0COy/akC5vzrPoAKerbvNhCmC5DQGnFBVOtLYx7vKE1fty0j\n y//97xNeFHTclb1cvvHEvY1gp9cbk369YqScejUEGpgTJBLdXypYfMDtUGbb1EpGNvy4\n J2dA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112; t=1677111463;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=FO+p4tR7UF21nYoDFXSVXirNroZAK5INv9CP5ZrbBho=;\n b=zzndnQpwIP9+WO3xksn/1UK5/6aG9FwWEOdEzAu3ZoWjPHLU7BjVICCWsmUZLUzLqC\n iJxJ211dnfR9SQp7DchLZpXzxc/1rJfzE/xOp4dqtUdvB55HykkYTkn/LZhiFZ2TiI05\n 2Dn4h5O5ptJvHCo8l1LUhx4i9N4c+NKd+Chzv5dI7ReBXMKUcMQ/qK6vsepz5a+mmUQk\n 8YJn2W3Oru3H47uaCMA+cd8VI97KZd35WjWxrOoYMpXteOYP0YHC2wgYolytWBEhqmJP\n TbmpqzpAeyI6cKtRIcJsSV6W1Wwjy8v1/Gf0+PLguaHyLq3odfOqGhrlKqt5QdjZMWzq\n LlqA==","X-Gm-Message-State":"AO0yUKXe8X9cUlTa3K/Y4Ovuf5b4R+WCKOWZR/omO55Eiup1TzpKLGV1\n Y0u6Hf2KzDkBt6RTbgpr6qBhYlIxZwmT2u3VIfE=","X-Google-Smtp-Source":"\n AK7set8VuxpBkL4b3Im8VvQkAKBlXn41OkWGAg6dOM283a9GWP+4pswZNWfeNTjwQV5SRkR/Z/naOSdyqIKsB34U3Yo=","X-Received":"by 2002:a1f:2246:0:b0:3e9:ff52:d343 with SMTP id\n i67-20020a1f2246000000b003e9ff52d343mr1895281vki.17.1677111463345; Wed, 22\n Feb 2023 16:17:43 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAJaLiFy-MCy97ybv83wx5TBp1iu_VzEWxSPMV_421dYohdn3yg@mail.gmail.com>\n <20230222230647.rfn5vkz2zeyqadz5@pali>\n <CAJaLiFwmTTqGL0ZGeGfcmAKns+fAyUfJC060RWe+vEqR-4Fq6g@mail.gmail.com>\n <20230222233957.lb6jrsdqkffw3yn5@pali>","In-Reply-To":"<20230222233957.lb6jrsdqkffw3yn5@pali>","From":"Tony Dinh <mibodhi@gmail.com>","Date":"Wed, 22 Feb 2023 16:17:32 -0800","Message-ID":"\n <CAJaLiFxshNa1izFfFRVS1LiFS_osbBf6yhhdMpji1E=dt44S5g@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063755,"web_url":"http://patchwork.ozlabs.org/comment/3063755/","msgid":"<20230223074603.tkmxxatufd4rnb2t@pali>","list_archive_url":null,"date":"2023-02-23T07:46:03","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Wednesday 22 February 2023 16:17:32 Tony Dinh wrote:\n> Hi Pali,\n> \n> On Wed, Feb 22, 2023 at 3:40 PM Pali Rohár <pali@kernel.org> wrote:\n> >\n> > On Wednesday 22 February 2023 15:16:06 Tony Dinh wrote:\n> > > Hi Pali,\n> > >\n> > > On Wed, Feb 22, 2023 at 3:06 PM Pali Rohár <pali@kernel.org> wrote:\n> > > >\n> > > > On Wednesday 22 February 2023 14:16:36 Tony Dinh wrote:\n> > > > > Hi Pali,\n> > > > >\n> > > > > On Tue, Feb 21, 2023 at 11:58 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > > >\n> > > > > > On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote:\n> > > > > > > Hi Pali,\n> > > > > > >\n> > > > > > > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > > > > >\n> > > > > > > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:\n> > > > > > > > > Hi Pali,\n> > > > > > > > >\n> > > > > > > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali@kernel.org> wrote:\n> > > > > > > > > >\n> > > > > > > > > > This patch series contains various improvements and fixes for existing\n> > > > > > > > > > logical errors. Boot phase was adjusted to match behavior of Armada 385\n> > > > > > > > > > BootROM by inspecting and disassembling of BootROM binary dump itself.\n> > > > > > > > > > Important information are included in documentation patch for kwboot.\n> > > > > > > > > > Most of the changes are untested, hence this patch series is just RFC.\n> > > > > > > > > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> > > > > > > > > > Nevertheless all patches on github passed CI testing in this PR:\n> > > > > > > > > > https://github.com/u-boot/u-boot/pull/275\n> > > > > > > > ...\n> > > > > > > > > I went to patchwork and downloaded the series.\n> > > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org\n> > > > > > > > >\n> > > > > > > > > When I applied the patches set there were some rejections.\n> > > > > > > > > <BEGIN LOG>\n> > > > > > > > > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch\n> > > > > > > > >\n> > > > > > > > ...\n> > > > > > > > FAILED\n> > > > > > > > ...\n> > > > > > > > > <END LOG>\n> > > > > > > > >\n> > > > > > > > > I'm on the latest master branch (just did a git pull today). Could\n> > > > > > > > > some patches be out of order?\n> > > > > > > > >\n> > > > > > > > > Thanks,\n> > > > > > > > > Tony\n> > > > > > > >\n> > > > > > > > Well, that is because DENX mail server is broken and it crashed during\n> > > > > > > > processing antispam filter on my some of my patches. So some patches are\n> > > > > > > > missing in archive and then applying dependent patches failed.\n> > > > > > > >\n> > > > > > > > So ignore patchwork and email patches. Rather fetch changes from the\n> > > > > > > > mentioned github pull request https://github.com/u-boot/u-boot/pull/275\n> > > > > > > >\n> > > > > > > > You can do it via git command (it fetch it to the new mvebu branch):\n> > > > > > > >\n> > > > > > > >   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu\n> > > > > > >\n> > > > > > > Indeed! That pull request was applied without problem.\n> > > > > > >\n> > > > > > > So I did a general regression test running rebuilt kwboot binary, and\n> > > > > > > rebuilt u-boot images for these 2 Marvell boards:\n> > > > > > >\n> > > > > > > Thecus N2350 (Armada 385)\n> > > > > > > Pogo V4 (Kirkwood 88F6192).\n> > > > > > >\n> > > > > > > So for that part:\n> > > > > > > Tested-by: Tony Dinh <mibodhi@gmail.com>\n> > > > > > >\n> > > > > > > All the best,\n> > > > > > > Tony\n> > > > > >\n> > > > > > Thanks for testing! Anyway do you have some A38x board which can boot\n> > > > > > from SD/MMC, SATA or NAND? This is what is needed to test too. I see\n> > > > > > that Pogo boots from NAND but it does not use SPL.\n> > > > >\n> > > > > I have only one A38x board with NAND: the Thecus N2350. I am creating\n> > > > > a new defconfig and will see if I can boot it from the NAND flash.\n> > > >\n> > > > Ok. And do you have some switch on this board which instruct BootROM to\n> > > > really boot from NAND?\n> > >\n> > > No switch that I can see. So I'm going to erase the u-boot image in\n> > > SPI to let the BootROM try booting from NAND.\n> >\n> > BootROM on 32-bit mvebu SoCs always boots from the location configured\n> > by strapping pins. So if you do not have any switch (or possible\n> > soldered zero-ohm resistors) on the board then I doubt that BootROM will\n> > try to boot from NAND.\n> >\n> Argh! I misremember that boot flow, it must have been for another SoC.\n> Then I guess I have to look at the board again to see if there is any\n> jumper/switch... Perhaps the other way is to run in the BootROM\n> debugging prompt and set the boot device to NAND?\n\nHm... You can try it. But when I tried on A385 to set boot device to\nSPI-NOR from debugging prompt it did not work and I suspect bug in\nBootROM. But maybe setting boot device to NAND would work. Who knows.\n\n> > > >\n> > > > > By the way, I'm having this build error that CFG_SYS_NAND_BASE is not\n> > > > > defined. What should it be for A38x? is it the same for Kirkwood?\n> > > > >\n> > > > > All the best,\n> > > > > Tony\n> > > >\n> > > > Is SYS_NAND_BASE really needed? If yet then I think it should be macro\n> > > > MVEBU_NAND_BASE.\n> > >\n> > > The build error looks like this:\n> > > drivers/mtd/nand/raw/nand.c:15:34: error: ‘CFG_SYS_NAND_BASE’\n> > > undeclared here (not in a function); did you mean\n> > > ‘CFG_SYS_PL310_BASE’?\n> > >    15 | #define CFG_SYS_NAND_BASE_LIST { CFG_SYS_NAND_BASE }\n> > >\n> >\n> > I see... Maybe you can try to enable SYS_NAND_SELF_INIT.\n> \n> Thanks, that was it. I did configure the board incorrectly :) I need\n> CONFIG_NAND_PXA3XX which selects SYS_NAND_SELF_INIT.\n\nPerfect! Anyway for booting from NAND you do not have CONFIG_NAND_PXA3XX\nsupport. You need CONFIG_NAND_PXA3XX if you want to access NAND from\nu-boot (e.g. for writing bootloder there; so you need it at least once).\n\n> Thanks,\n> Tony\n> \n> > > >\n> > > > But on Kirkwood is SYS_NAND_BASE set to the DEFADR_NANDF value which is\n> > > > memory mapping of NAND device via mbus. On Armada devices is not NAND\n> > > > device mbus mapped at all and MVEBU_NAND_BASE points to internal mvebu\n> > > > registers. So I'm quite not sure if it would work.\n> > > >\n> > > > So lets try with MVEBU_NAND_BASE.\n> > >\n> > > OK.\n> > >\n> > > Thanks,\n> > > Tony","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ra6qtLLH;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"ra6qtLLH\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMlTG0zLlz240V\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 18:46:24 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 671CF8574F;\n\tThu, 23 Feb 2023 08:46:17 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 4311685738; Thu, 23 Feb 2023 08:46:15 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 5075885ACE\n for <u-boot@lists.denx.de>; Thu, 23 Feb 2023 08:46:09 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 2EC1E61486;\n Thu, 23 Feb 2023 07:46:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A0C85C433D2;\n Thu, 23 Feb 2023 07:46:06 +0000 (UTC)","by pali.im (Postfix)\n id 9996C3AD; Thu, 23 Feb 2023 08:46:03 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677138367;\n bh=Dn6IbbDmbQOSPduZj7PR2NeU/HdK03AN0ZqFvrEpw6U=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=ra6qtLLHAPvDO6ArgO999u4iSq79OveDVNqonGirFvQE2tEl/kaLERkav0OgtYjVg\n lppsBczm42wkCJFr8+XonbKs53vg8e8whAkdtVQkkZZ9iZZQLHHMOWlx2LYM9wedjn\n m9ezEBxhah/oj6VI9WF7hcpBEaEe5F2ZEKDGt45IK0kJZNpS5uksjYrWlU8MvKOgFa\n r35nCcfVyZ6s6EXk5fnlXgNoxUqZ2fer+g8eMUJAK2zys6NZoKVAn4JppUnUuOO7Jz\n ZpRwT+JoVcCiAjtJzbJD5TChxP57Dy21zL6kSKVm0SMm6r4xZW57Geit93UfkSJjv5\n 5tKfZVhUY5dYw==","Date":"Thu, 23 Feb 2023 08:46:03 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Tony Dinh <mibodhi@gmail.com>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230223074603.tkmxxatufd4rnb2t@pali>","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAJaLiFy-MCy97ybv83wx5TBp1iu_VzEWxSPMV_421dYohdn3yg@mail.gmail.com>\n <20230222230647.rfn5vkz2zeyqadz5@pali>\n <CAJaLiFwmTTqGL0ZGeGfcmAKns+fAyUfJC060RWe+vEqR-4Fq6g@mail.gmail.com>\n <20230222233957.lb6jrsdqkffw3yn5@pali>\n <CAJaLiFxshNa1izFfFRVS1LiFS_osbBf6yhhdMpji1E=dt44S5g@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"\n <CAJaLiFxshNa1izFfFRVS1LiFS_osbBf6yhhdMpji1E=dt44S5g@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063758,"web_url":"http://patchwork.ozlabs.org/comment/3063758/","msgid":"<20230223075658.xw5amjx7lgoxzi4p@pali>","list_archive_url":null,"date":"2023-02-23T07:56:58","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Wednesday 22 February 2023 11:59:35 Martin Rowe wrote:\n> A388 Clearfog Base (SD card model):\n> - MMC from SD card works\n> - UART works\n> - SATA with new defconfig works\n> - SPI (if you select MVEBU_SPL_BOOT_DEVICE_SPI yourself) works\n> A388 Clearfog Pro (eMMC model):\n> - MMC from eMMC works, but still requires the dts to be patched for\n> eMMC (included at bottom)\n\nCould you test also bubt command for upgrading u-boot on all those\nvariants? So to ensure that upgrading u-boot would work correctly.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=DxCoUjO0;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"DxCoUjO0\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMljd6zBWz2461\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 18:57:09 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 016568574F;\n\tThu, 23 Feb 2023 08:57:06 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 45AB78574F; Thu, 23 Feb 2023 08:57:05 +0100 (CET)","from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6E5C785738\n for <u-boot@lists.denx.de>; Thu, 23 Feb 2023 08:57:02 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id 159ABB81699;\n Thu, 23 Feb 2023 07:57:02 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A4D1CC433D2;\n Thu, 23 Feb 2023 07:57:00 +0000 (UTC)","by pali.im (Postfix)\n id 2A9C93AD; Thu, 23 Feb 2023 08:56:58 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677139020;\n bh=QePsy4FIrFDHVxbwQprtbvujQiOELgYIP7DqQNlyZYg=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=DxCoUjO0e4bbRh7/jfCTf1u6a8vkeno+jJOrBqsjqGvvbyVhAQRGHZ1sJh+PPscw4\n +ZUJjdVYt4KIn7GHR1ySbv1hBxYyqiT6hKzvQXL4tjHXuOwNcme7svsPFNwUOUu1Sn\n VqRuqWlAGlBqirXIgz41XNNG6GE33X0swWw0XjNd73kcu74LWZ7KcXtzRHq9DujMns\n Kn08UBu/tIipRUK/54EH+ZGIDTduP38gIFa70WK+TGGjZ8lmMErCYcae0vsAnlPvQv\n 7EG4RBjHrgsH42HDA4UzJYez0sDo4vV3+3p1LC+y6qmoKxyJ1Ne8xMm0y68NNzHevg\n oZheQyyRfGfkw==","Date":"Thu, 23 Feb 2023 08:56:58 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Martin Rowe <martin.p.rowe@gmail.com>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230223075658.xw5amjx7lgoxzi4p@pali>","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3063960,"web_url":"http://patchwork.ozlabs.org/comment/3063960/","msgid":"<CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>","list_archive_url":null,"date":"2023-02-23T12:11:46","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":85861,"url":"http://patchwork.ozlabs.org/api/people/85861/","name":"Martin Rowe","email":"martin.p.rowe@gmail.com"},"content":"> > > Have you tried booting from eMMC boot partition or eMMC user data\n> > > partition? Because all 3 options should work, but I'm not fully sure if\n> > > BootROM choose partition from eMMC register or if tries all 3 in some\n> > > order. This is something which needs to be checked and verified.\n> >\n> > I only tested from boot0, but will test the others as well. I've only\n> > ever seen it fallback, but I'll check the new changes and see if they\n> > can select the boot device.\n>\n> Ok. When testing, ensure that you erase uboots from other partitions or\n> check that it boots the correct version from the correction partition.\n\nBootROM always tries boot0, boot1, then user, regardless of partconf\nsetting. SPL does use the partconf setting, though. So when I\nconfigure:\nboot0 - zeroed\nboot1 - u-boot (with local version 'boot1')\nuser - u-boot (with local version 'user')\nmmc partconf 0 0 7 0\nI see the output below. Note that BootROM tries boot0 first with two\naddresses, switches to boot1 (see 'boot1' following 2023.04-rc2),\nloads SPL, which then loads u-boot from user (see 'user' following\n2023.04-rc2)\n=================================================\nBootROM - 1.73\n\nBooting from MMC\nBootROM: Bad header at offset 00000000\nBootROM: Bad header at offset 00200000\nSwitching BootPartitions.\n\nU-Boot SPL 2023.04-rc2boot1-00098-g93408c61cd-dirty (Feb 23 2023 -\n19:43:59 +1000)\nHigh speed PHY - Version: 2.0\nEEPROM TLV detection failed: Using static config for Clearfog Pro.\nDetected Device ID 6828\nboard SerDes lanes topology details:\n | Lane # | Speed |  Type       |\n --------------------------------\n |   0    |   3   | SATA0    |\n |   1    |   0   | SGMII1    |\n |   2    |   5   | PCIe1    |\n |   3    |   5   | USB3 HOST1    |\n |   4    |   5   | PCIe2    |\n |   5    |   0   | SGMII2    |\n --------------------------------\nHigh speed PHY - Ended Successfully\nmv_ddr: 14.0.0\nDDR3 Training Sequence - Switching XBAR Window to FastPath Window\nmv_ddr: completed successfully\nTrying to boot from MMC1\n\n\nU-Boot 2023.04-rc2user-00098-g93408c61cd-dirty (Feb 23 2023 - 19:44:54 +1000)\n\nSoC:   MV88F6828-A0 at 1600 MHz\nDRAM:  1 GiB (800 MHz, 32-bit, ECC not enabled)\nCore:  38 devices, 22 uclasses, devicetree: separate\nMMC:   mv_sdh: 0\nLoading Environment from MMC... *** Warning - bad CRC, using default environment\n\nModel: SolidRun Clearfog A1\nBoard: SolidRun Clearfog Pro\nNet:\nWarning: ethernet@70000 (eth1) using random MAC address - ae:50:98:34:2e:3e\neth1: ethernet@70000\nWarning: ethernet@30000 (eth2) using random MAC address - 0a:66:2b:f7:45:09\n, eth2: ethernet@30000\nWarning: ethernet@34000 (eth3) using random MAC address - d2:8e:11:7e:64:c0\n, eth3: ethernet@34000\nHit any key to stop autoboot:  0\n=>\n=================================================\n\n> > > Could you try to use SolidRun eMMC patch which SolidRun has for years in\n> > > its repository?\n> > >\n> > > https://github.com/SolidRun/u-boot/commit/19a96f7c40a8fc1d0a6546ac2418d966e5840a99\n> > >\n> > > Probably same functionality is needed to implement also into\n> > > board_fix_fdt() function enabled by CONFIG_OF_BOARD_FIXUP. Look for\n> > > other boards how they use CONFIG_OF_BOARD_FIXUP.\n> > >\n> > > And if ... you can try to put this logic in board_late_init() function.\n> > > For inspiration look into Espressobin board which deactivates eMMC at\n> > > runtime by checking existence of eMMC:\n> > > https://source.denx.de/u-boot/u-boot/-/blob/master/board/Marvell/mvebu_armada-37xx/board.c\n\nI've not been able to get this to work. I enable CONFIG_OF_BOARD_FIXUP\nin my config and add the following to\nboard/solidrun/clearfog/clearfog.c:\n+int board_fix_fdt(void *blob)\n+       {\n+       int offset;\n+       offset = fdt_path_offset(blob, \"/soc/internal-regs/sdhci@d8000\");\n+       if (offset >= 0) {\n+               printf(\"offset\");\n+               fdt_delprop(blob, offset, \"cd-gpios\");\n+               fdt_setprop_empty(blob, offset, \"non-removable\");\n+       }\n+       return 0;\n+}\nThen I boot from MMC and get the following:\n=================================================\nBootROM - 1.73\n\nBooting from MMC\n\nU-Boot SPL 2023.04-rc2-00098-g93408c61cd-dirty (Feb 23 2023 - 21:32:01 +1000)\nHigh speed PHY - Version: 2.0\nEEPROM TLV detection failed: Using static config for Clearfog Pro.\nDetected Device ID 6828\nboard SerDes lanes topology details:\n | Lane # | Speed |  Type       |\n --------------------------------\n |   0    |   3   | SATA0       |\n |   1    |   0   | SGMII1      |\n |   2    |   5   | PCIe1       |\n |   3    |   5   | USB3 HOST1  |\n |   4    |   5   | PCIe2       |\n |   5    |   0   | SGMII2      |\n --------------------------------\nHigh speed PHY - Ended Successfully\nmv_ddr: 14.0.0\nDDR3 Training Sequence - Switching XBAR Window to FastPath Window\nmv_ddr: completed successfully\nTrying to boot from MMC1\nMMC: no card present\nspl: mmc init failed with error: -123\nTrying to boot from BOOTROM\nReturning to BootROM (return address 0xffff05c4)...\nsdioSdhciSendCmd: Timeout for status update!\nsdioSdhciSendCmd: Timeout for status update!\nBootROM: Image checksum verification FAILED\nsdioSdhciSendCmd: Timeout for status update!\nsdioSdhciSendCmd: Timeout for status update!\nsdioSdhciSendCmd: Timeout for status update!\nsdioSdhciSendCmd: Timeout for status update!\nBootROM: Invalid header checksum\nSwitching BootPartitions.\nsdioSdhciSendCmd: Timeout for status update!\nsdioSdhciSendCmd: Timeout for status update!\nsdioSdhciSendCmd: Timeout for status update!\nsdioSdhciSendCmd: Timeout for status update!\nBootROM: Invalid header checksum\nsdioSdhciSendCmd: Timeout for status update!\nsdioSdhciSendCmd: Timeout for status update!\nsdioSdhciSendCmd: Timeout for status update!\nsdioSdhciSendCmd: Timeout for status update!\nBootROM: Invalid header checksum\nSwitching BootPartitions.\n=================================================\nThis is exactly the same error as I get without the board_fix_fdt\nchange. I tried adding some printfs and returning 1 from the function,\nbut I can't see any evidence that it is getting called in the SPL at\nall. I also see that SolidRun has dropped the patch you linked to in\nnewer a38x branches, but can't see how else they're handling the eMMC\ndetection.\n\nI could wrap the dts change with a kconfig, but anyone enabling that\nkconfig would also need to patch the kernel dtb, unless u-boot has a\nhook to patch the file before passing it to the kernel.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=UBBXFOaq;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"UBBXFOaq\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=martin.p.rowe@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PMsN12NVWz245y\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Feb 2023 23:12:15 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 03F5985AB5;\n\tThu, 23 Feb 2023 13:12:06 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 64289855D9; Thu, 23 Feb 2023 13:12:03 +0100 (CET)","from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com\n [IPv6:2607:f8b0:4864:20::32b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9085685AB5\n for <u-boot@lists.denx.de>; Thu, 23 Feb 2023 13:11:59 +0100 (CET)","by mail-ot1-x32b.google.com with SMTP id\n g6-20020a056830308600b0068d4b30536aso2173416ots.9\n for <u-boot@lists.denx.de>; Thu, 23 Feb 2023 04:11:59 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=YEEj3kgkrn31haT4XY80z1er9dEk99Eu4eTggiGHbcE=;\n b=UBBXFOaqitGLD00NPAOlrWG7OfxsRFEZEdTiLlRrA8dk4wwpAhzmbfgqHtzRAQKpi4\n Jk1/9h5cqh0aoFRJXfJNLY03WzmfEpJbthJdosmDuOL5rNcPUQCr8INWp8Wjn7+BAa4n\n b7mZOq3Wwl0Hx6ze0AzWnojprscfKTHam0r2tL9KHfCEfpX0PZ0W2dRR7C+a+Vf6ODqO\n E0dSbNVfW7Ft8uGxZa2cfv1kwBc4Iz4Uy+/64sTvu9EJrV4Wl+L9ySaXD8FlRb7i8lOR\n IH9VHm4xtiCG18mDIPTQoWvbGtY67yLVJA2gEXesoLeAswv7Qj+pPxzQpgA34KoSp2wv\n yIQQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=YEEj3kgkrn31haT4XY80z1er9dEk99Eu4eTggiGHbcE=;\n b=QP7nQDj8p298bvhOyC4kkjKfFVFPkJ7krcssb3GIzN6zuJ0+AOJR0nmwgrqMpeHZmX\n R3lCqMizJ/Xh1SzLEYrnvGWuE4nD/PWw7Q8DMk/zKuppyD8xXoGVwbJyQlyXLEm5yQga\n tyq7Uk9N/7UQKQP8jl4mVinqonVt6Ua8etcGbaaXA3ppfsxsvgEMk2KJtBmx4aoNODat\n pO5tNuIQW5GvU+meHEMgItnfiQGjuR7XcXkibYn05WKw0Lybcl5452ozw5DLlFSjgrut\n errkh89c3NfjXrx0Hp01N/tnK9E90gI9YTlT6B/Za19ClDmGBD7w0q5+cf+d8P+c7mmy\n 9lvw==","X-Gm-Message-State":"AO0yUKVUHbjUW77PDRiaayA90m8TFvHy5nOCel0XqY8GLrqiDVybIFqu\n k2+7FPlB9U+1XYIwDz1kEFfyT/O2G2YcJg+3AAQ=","X-Google-Smtp-Source":"\n AK7set9r1MzCUyJ8QU4M2lEqd5msMS6BPhsCpBiLGaUfqXLc2k8DXp09cgUhk4/H6SrS2HjNq0NHqjDYZKpXntmND/s=","X-Received":"by 2002:a05:6830:33d1:b0:68d:4b7f:e993 with SMTP id\n q17-20020a05683033d100b0068d4b7fe993mr642168ott.3.1677154318122; Thu, 23 Feb\n 2023 04:11:58 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>","In-Reply-To":"<20230222212356.abfhl7omg35hwizc@pali>","From":"Martin Rowe <martin.p.rowe@gmail.com>","Date":"Thu, 23 Feb 2023 12:11:46 +0000","Message-ID":"\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3064224,"web_url":"http://patchwork.ozlabs.org/comment/3064224/","msgid":"<20230223180223.g6fy72hjttgbhdmb@pali>","list_archive_url":null,"date":"2023-02-23T18:02:23","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Thursday 23 February 2023 12:11:46 Martin Rowe wrote:\n> > > > Have you tried booting from eMMC boot partition or eMMC user data\n> > > > partition? Because all 3 options should work, but I'm not fully sure if\n> > > > BootROM choose partition from eMMC register or if tries all 3 in some\n> > > > order. This is something which needs to be checked and verified.\n> > >\n> > > I only tested from boot0, but will test the others as well. I've only\n> > > ever seen it fallback, but I'll check the new changes and see if they\n> > > can select the boot device.\n> >\n> > Ok. When testing, ensure that you erase uboots from other partitions or\n> > check that it boots the correct version from the correction partition.\n> \n> BootROM always tries boot0, boot1, then user, regardless of partconf\n> setting. SPL does use the partconf setting, though. So when I\n> configure:\n> boot0 - zeroed\n> boot1 - u-boot (with local version 'boot1')\n> user - u-boot (with local version 'user')\n> mmc partconf 0 0 7 0\n> I see the output below. Note that BootROM tries boot0 first with two\n> addresses, switches to boot1 (see 'boot1' following 2023.04-rc2),\n> loads SPL, which then loads u-boot from user (see 'user' following\n> 2023.04-rc2)\n\nOk, I was not sure how that bootrom is choosing initial partition as I\nhave not fully understood bootrom mmc code. So from this it looks like\nthat bootrom ignores MMC EXT_CSD[179] register, try booting from BOOT0\nand then it really switch to the next partition. (My understanding of\nthat bootrom binary was that \"Switching BootPartitions.\" does nothing.)\n\nCan you check if boot_ack argument has some effect on the initial\nchoice? Or if completely disabling boot partitions (boot_enable to 0)\nhave some effect?\n\nIf really EXT_CSD[179] register is completely ignored we may change SPL\nto always boot from BOOT0 (when eMMC with boot partitions is used) and\nif it fails then fallback to BootROM booting.\n\n> =================================================\n> BootROM - 1.73\n> \n> Booting from MMC\n> BootROM: Bad header at offset 00000000\n> BootROM: Bad header at offset 00200000\n> Switching BootPartitions.\n> \n> U-Boot SPL 2023.04-rc2boot1-00098-g93408c61cd-dirty (Feb 23 2023 -\n> 19:43:59 +1000)\n> High speed PHY - Version: 2.0\n> EEPROM TLV detection failed: Using static config for Clearfog Pro.\n> Detected Device ID 6828\n> board SerDes lanes topology details:\n>  | Lane # | Speed |  Type       |\n>  --------------------------------\n>  |   0    |   3   | SATA0    |\n>  |   1    |   0   | SGMII1    |\n>  |   2    |   5   | PCIe1    |\n>  |   3    |   5   | USB3 HOST1    |\n>  |   4    |   5   | PCIe2    |\n>  |   5    |   0   | SGMII2    |\n>  --------------------------------\n> High speed PHY - Ended Successfully\n> mv_ddr: 14.0.0\n> DDR3 Training Sequence - Switching XBAR Window to FastPath Window\n> mv_ddr: completed successfully\n> Trying to boot from MMC1\n> \n> \n> U-Boot 2023.04-rc2user-00098-g93408c61cd-dirty (Feb 23 2023 - 19:44:54 +1000)\n> \n> SoC:   MV88F6828-A0 at 1600 MHz\n> DRAM:  1 GiB (800 MHz, 32-bit, ECC not enabled)\n> Core:  38 devices, 22 uclasses, devicetree: separate\n> MMC:   mv_sdh: 0\n> Loading Environment from MMC... *** Warning - bad CRC, using default environment\n> \n> Model: SolidRun Clearfog A1\n> Board: SolidRun Clearfog Pro\n> Net:\n> Warning: ethernet@70000 (eth1) using random MAC address - ae:50:98:34:2e:3e\n> eth1: ethernet@70000\n> Warning: ethernet@30000 (eth2) using random MAC address - 0a:66:2b:f7:45:09\n> , eth2: ethernet@30000\n> Warning: ethernet@34000 (eth3) using random MAC address - d2:8e:11:7e:64:c0\n> , eth3: ethernet@34000\n> Hit any key to stop autoboot:  0\n> =>\n> =================================================\n> \n> > > > Could you try to use SolidRun eMMC patch which SolidRun has for years in\n> > > > its repository?\n> > > >\n> > > > https://github.com/SolidRun/u-boot/commit/19a96f7c40a8fc1d0a6546ac2418d966e5840a99\n> > > >\n> > > > Probably same functionality is needed to implement also into\n> > > > board_fix_fdt() function enabled by CONFIG_OF_BOARD_FIXUP. Look for\n> > > > other boards how they use CONFIG_OF_BOARD_FIXUP.\n> > > >\n> > > > And if ... you can try to put this logic in board_late_init() function.\n> > > > For inspiration look into Espressobin board which deactivates eMMC at\n> > > > runtime by checking existence of eMMC:\n> > > > https://source.denx.de/u-boot/u-boot/-/blob/master/board/Marvell/mvebu_armada-37xx/board.c\n> \n> I've not been able to get this to work. I enable CONFIG_OF_BOARD_FIXUP\n> in my config and add the following to\n> board/solidrun/clearfog/clearfog.c:\n> +int board_fix_fdt(void *blob)\n> +       {\n> +       int offset;\n> +       offset = fdt_path_offset(blob, \"/soc/internal-regs/sdhci@d8000\");\n> +       if (offset >= 0) {\n> +               printf(\"offset\");\n> +               fdt_delprop(blob, offset, \"cd-gpios\");\n> +               fdt_setprop_empty(blob, offset, \"non-removable\");\n> +       }\n> +       return 0;\n> +}\n> Then I boot from MMC and get the following:\n> =================================================\n> BootROM - 1.73\n> \n> Booting from MMC\n> \n> U-Boot SPL 2023.04-rc2-00098-g93408c61cd-dirty (Feb 23 2023 - 21:32:01 +1000)\n> High speed PHY - Version: 2.0\n> EEPROM TLV detection failed: Using static config for Clearfog Pro.\n> Detected Device ID 6828\n> board SerDes lanes topology details:\n>  | Lane # | Speed |  Type       |\n>  --------------------------------\n>  |   0    |   3   | SATA0       |\n>  |   1    |   0   | SGMII1      |\n>  |   2    |   5   | PCIe1       |\n>  |   3    |   5   | USB3 HOST1  |\n>  |   4    |   5   | PCIe2       |\n>  |   5    |   0   | SGMII2      |\n>  --------------------------------\n> High speed PHY - Ended Successfully\n> mv_ddr: 14.0.0\n> DDR3 Training Sequence - Switching XBAR Window to FastPath Window\n> mv_ddr: completed successfully\n> Trying to boot from MMC1\n> MMC: no card present\n> spl: mmc init failed with error: -123\n> Trying to boot from BOOTROM\n> Returning to BootROM (return address 0xffff05c4)...\n\nAfter this line, SPL give control to the BootROM...\n\n> sdioSdhciSendCmd: Timeout for status update!\n> sdioSdhciSendCmd: Timeout for status update!\n> BootROM: Image checksum verification FAILED\n> sdioSdhciSendCmd: Timeout for status update!\n> sdioSdhciSendCmd: Timeout for status update!\n> sdioSdhciSendCmd: Timeout for status update!\n> sdioSdhciSendCmd: Timeout for status update!\n> BootROM: Invalid header checksum\n> Switching BootPartitions.\n> sdioSdhciSendCmd: Timeout for status update!\n> sdioSdhciSendCmd: Timeout for status update!\n> sdioSdhciSendCmd: Timeout for status update!\n> sdioSdhciSendCmd: Timeout for status update!\n> BootROM: Invalid header checksum\n> sdioSdhciSendCmd: Timeout for status update!\n> sdioSdhciSendCmd: Timeout for status update!\n> sdioSdhciSendCmd: Timeout for status update!\n> sdioSdhciSendCmd: Timeout for status update!\n> BootROM: Invalid header checksum\n> Switching BootPartitions.\n\n...and bootrom tried to load main U-Boot. But apparently SPL\nreconfigured MMC controller in such way that it cannot access eMMC\nanymore.\n\nSeems that something in mmc initialization code is buggy. You can try to\ndebug it by starting disabling parts of initialization code until you\nfind the line/function which makes those BootROM messages \"Timeout for\nstatus update!\".\n\n> =================================================\n> This is exactly the same error as I get without the board_fix_fdt\n> change. I tried adding some printfs and returning 1 from the function,\n> but I can't see any evidence that it is getting called in the SPL at\n> all.\n\nHm... Yes, \"offset\" string is not in your output, so that function is\nnot called in SPL. Only in main U-Boot.\n\nWhat is in SPL called is board_early_init_f() function or\nfdtdec_board_setup() function or also board_late_init() function.\nPointer to blob is in global variable gd->fdt_blob.\n\nNote that adding new properties/nodes into fdt blob may fail. So always\ncheck for return values of fdt_*() function! You would probably need to\ncall fdt_increase_size() first to make a place for new properties.\n\n> I also see that SolidRun has dropped the patch you linked to in\n> newer a38x branches, but can't see how else they're handling the eMMC\n> detection.\n> \n> I could wrap the dts change with a kconfig, but anyone enabling that\n> kconfig would also need to patch the kernel dtb, unless u-boot has a\n> hook to patch the file before passing it to the kernel.\n\nYes, it has a hook. It is called ft_board_setup() and is called\nimmediately before booting linux kernel. Basically in this hook you\nshould check if u-boot's blob was patched for eMMC and if yes then patch\nalso blob passed as argument in that function, as this blob would be\nused for linux. See Turris Omnia hook for inspiration which fixups\nethernet node for linux blob based on what is in u-boot blob:\nhttps://source.denx.de/u-boot/u-boot/-/blob/master/board/CZ.NIC/turris_omnia/turris_omnia.c","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fZNKE5lr;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"fZNKE5lr\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PN18Q5C3Dz23yr\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Feb 2023 05:02:46 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B7224843B5;\n\tThu, 23 Feb 2023 19:02:39 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 9C90380BAA; Thu, 23 Feb 2023 19:02:34 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 407DD843B5\n for <u-boot@lists.denx.de>; Thu, 23 Feb 2023 19:02:29 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 5A2F461642;\n Thu, 23 Feb 2023 18:02:29 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 955B9C433EF;\n Thu, 23 Feb 2023 18:02:26 +0000 (UTC)","by pali.im (Postfix)\n id 8D09760F; Thu, 23 Feb 2023 19:02:23 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677175346;\n bh=aZ0Q0aE/GFackoTFsOsdOSnzDuIFvrOiNhiLkfuupiY=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=fZNKE5lr8AAq70JVbnhBH+RyXXRr5kcZlYEcSQ4M1Xsam/0MaxmEQKCsNps11BVX1\n 0JPeuxLXcpnq26HwxxGqDah+PlL8imKjekAJ3cH8th+lS29Ur9y/Hck13A3Ty2jhSY\n sMcGPCaP9NnpiBwUABasC9p5Er+UNYa63ZRKnhqywmJaqilLV260z9XFyeWmzq6fiA\n OFBKiUhDBydEt711xmawSwpNVyvHKk1iGCjCqtx+4DrW7H9cHop9457qO2rHQFXaT+\n 9JLFSQibUL49b/FM4wkxr8cod1M0DHt1SnS0VN5p2tgfe1w59rjsqVJAUPx3NIVMbC\n 3E6Yhr7dKuh2Q==","Date":"Thu, 23 Feb 2023 19:02:23 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Martin Rowe <martin.p.rowe@gmail.com>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230223180223.g6fy72hjttgbhdmb@pali>","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3064560,"web_url":"http://patchwork.ozlabs.org/comment/3064560/","msgid":"<CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>","list_archive_url":null,"date":"2023-02-24T06:27:49","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":85861,"url":"http://patchwork.ozlabs.org/api/people/85861/","name":"Martin Rowe","email":"martin.p.rowe@gmail.com"},"content":"> > boot0 - zeroed\n> > boot1 - u-boot (with local version 'boot1')\n> > user - u-boot (with local version 'user')\n> Can you check if boot_ack argument has some effect on the initial\n> choice? Or if completely disabling boot partitions (boot_enable to 0)\n> have some effect?\n\nboot_ack doesn't appear to do anything. I can only set 0 or 1 and\nthere's no noticeable change to the boot process.\n\nSetting `mmc partconf 0 0 0 0` with the same setup as described above\nresults in the same BootROM fallback from BOOT0 to BOOT1, then SPL in\nBOOT1 loads u-boot from the user area, which is identical to the `mmc\npartconf 0 0 7 0` flow.\n\n> If really EXT_CSD[179] register is completely ignored we may change SPL\n> to always boot from BOOT0 (when eMMC with boot partitions is used) and\n> if it fails then fallback to BootROM booting.\n\nIs there a way of knowing where the SPL was loaded from? Because it\nwould make sense to me that if SPL was loaded from BOOT1 to try and\nload u-boot from BOOT1 as well, or from BOOT0 if SPL was loaded from\nBOOT0, etc. Having u-boot loaded from a different location is not what\nI expected and seems like it would cause a lot of confusion,\nespecially in a failed A/B rollout. BootROM seems to completely ignore\nthe setting, so I agree that SPL should ignore it as well, but\nhardcoding BOOT0 (or even setting the partition as a compile-time\noption) is probably not a great outcome.\n\nTwo observations that might help here:\n1. After reset, running `mmc partconf 0` always shows PARTITION_ACCESS\nis set to 0x0, even it it was set to something else prior to reset\n2. With the same setup as described above and `mmc partconf 0 0 1 1`\nthe SPL eventually times out trying to load from the zeroed BOOT0 and\nreturns to BootROM, which results in u-boot being loaded from BOOT1:\n=================================================\nBootROM - 1.73\n\nBooting from MMC\nBootROM: Bad header at offset 00000000\nBootROM: Bad header at offset 00200000\nSwitching BootPartitions.\n\nU-Boot SPL 2023.04-rc2boot1-00098-g93408c61cd-dirty (Feb 23 2023 -\n19:43:59 +1000)\nHigh speed PHY - Version: 2.0\nEEPROM TLV detection failed: Using static config for Clearfog Pro.\nDetected Device ID 6828\nboard SerDes lanes topology details:\n | Lane # | Speed |  Type       |\n --------------------------------\n |   0    |   3   | SATA0       |\n |   1    |   0   | SGMII1      |\n |   2    |   5   | PCIe1       |\n |   3    |   5   | USB3 HOST1  |\n |   4    |   5   | PCIe2       |\n |   5    |   0   | SGMII2      |\n --------------------------------\nHigh speed PHY - Ended Successfully\nmv_ddr: 14.0.0\nDDR3 Training Sequence - Switching XBAR Window to FastPath Window\nmv_ddr: completed successfully\nTrying to boot from MMC1\nERROR: Invalid kwbimage v1\nmmc_load_image_raw_sector: mmc block read error\nspl: mmc: wrong boot mode\nTrying to boot from BOOTROM\nReturning to BootROM (return address 0xffff05c4)...\nTimeout waiting card ready\nBootROM: Image checksum verification PASSED\n\n\nU-Boot 2023.04-rc2boot1-00098-g93408c61cd-dirty (Feb 23 2023 - 19:43:59 +1000)\n\nSoC:   MV88F6828-A0 at 1600 MHz\nDRAM:  1 GiB (800 MHz, 32-bit, ECC not enabled)\nCore:  38 devices, 22 uclasses, devicetree: separate\nMMC:   mv_sdh: 0\nLoading Environment from MMC... *** Warning - bad CRC, using default environment\n\nModel: SolidRun Clearfog A1\nBoard: SolidRun Clearfog Pro\nNet:\nWarning: ethernet@70000 (eth1) using random MAC address - be:13:3f:c3:c2:19\neth1: ethernet@70000\nWarning: ethernet@30000 (eth2) using random MAC address - be:4c:72:3e:eb:bc\n, eth2: ethernet@30000\nWarning: ethernet@34000 (eth3) using random MAC address - 86:e7:dd:8d:c5:c1\n, eth3: ethernet@34000\nHit any key to stop autoboot:  0\n=>\n=================================================\n\n> Seems that something in mmc initialization code is buggy. You can try to\n> debug it by starting disabling parts of initialization code until you\n> find the line/function which makes those BootROM messages \"Timeout for\n> status update!\".\n\n> Hm... Yes, \"offset\" string is not in your output, so that function is\n> not called in SPL. Only in main U-Boot.\n>\n> What is in SPL called is board_early_init_f() function or\n> fdtdec_board_setup() function or also board_late_init() function.\n> Pointer to blob is in global variable gd->fdt_blob.\n>\n> Note that adding new properties/nodes into fdt blob may fail. So always\n> check for return values of fdt_*() function! You would probably need to\n> call fdt_increase_size() first to make a place for new properties.\n\n> Yes, it has a hook. It is called ft_board_setup() and is called\n> immediately before booting linux kernel. Basically in this hook you\n> should check if u-boot's blob was patched for eMMC and if yes then patch\n> also blob passed as argument in that function, as this blob would be\n> used for linux. See Turris Omnia hook for inspiration which fixups\n> ethernet node for linux blob based on what is in u-boot blob:\n> https://source.denx.de/u-boot/u-boot/-/blob/master/board/CZ.NIC/turris_omnia/turris_omnia.c\n\nLots of great ideas to look into, plus the bubt and defconfig stuff.\nI'll let you know how I go or if I get stuck again.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=k3xN+zmm;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"k3xN+zmm\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=martin.p.rowe@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PNKhk11Pcz2463\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Feb 2023 17:28:20 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A464B85707;\n\tFri, 24 Feb 2023 07:28:09 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 89ADD85626; Fri, 24 Feb 2023 07:28:07 +0100 (CET)","from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com\n [IPv6:2607:f8b0:4864:20::22d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A51AC857C3\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 07:28:02 +0100 (CET)","by mail-oi1-x22d.google.com with SMTP id t22so15163509oiw.12\n for <u-boot@lists.denx.de>; Thu, 23 Feb 2023 22:28:02 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=FT9aVMtOzKnUvWHytvxb0xGUUgGjrgIrsG6NlC1PN88=;\n b=k3xN+zmmrpdqdolmQFHL/EHl+LlAbeb6B/S8akYRNj3+m/fpdGD5nK91IzvnkUp0yr\n te02h3fqdjyR7DwRKgG6h1WKViAfUcHRA24hAH1rEwJG+4SMZYy5KR2Kt0C+OYObO8PV\n 3roQzqrdmifTC9z+b+wSIaztJwbZ1ZzkCb9qNk90kgZbNHMEkZgmR6FimTqSfGsI5F0g\n CNxJgofHKTmmAiGC5jVDshYF6mCoDk+1Kru2BCPGOuC0JoO/Q/+KO/BOBI6ylX/iXFCM\n Y8+NnYwwJYwNCd/3NLPoP4GGB0BfwUsMopzwo706kSLQk18DErIzpauzg2U5fqj7Ie4q\n dupA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=FT9aVMtOzKnUvWHytvxb0xGUUgGjrgIrsG6NlC1PN88=;\n b=eLft7MKloZW8DElZGLN+1tZHiHjt0AkOM6Z+0RzNYXheIttsJiJdY/AkUoMvQ5W3kJ\n 6dm8gENf9rriWDu8pjM3BpW/lTJ/i+AYdjr3AGM+7rsmoaHMa3lW4Ds2HszJHfxwM0bz\n t4Trhi7Q6RLsApgyIB/4LlYcmFO9NP8eJUdytwXkrhPSyiFBim0Al20QTjoh7IJH5hzK\n DSBpODSPsOCOiJ+sBoLKGkKpRSZpfoT4Zk8fZ46VQJCRvsvRaAg9ey+ThJMnrV4DSznj\n OwemMbtdxnI5kTufZZ8SqiU4CEkL0wj/DLvzwad2EGrBRcxhEGpN50U5ozWSIg5R8p7w\n 4Ytw==","X-Gm-Message-State":"AO0yUKV8fMmma1iWRXyVmIa+ewLOnGhUJZ1M7Of4PoufPDpWkr0aAoYP\n Ez3qW/X99kU6eH4K1s+mGM6BdIsVDqpNlzBV76g=","X-Google-Smtp-Source":"\n AK7set/WifC4b1somUu9Sgjx13O2J4GC7IIugRYWD+ubOl0Ww96CXz1BwsTX8BGrG8u/xXCIGqccAjhN0hBDLDQiMoU=","X-Received":"by 2002:aca:1a0c:0:b0:37f:b1b8:4a19 with SMTP id\n a12-20020aca1a0c000000b0037fb1b84a19mr715052oia.3.1677220080824; Thu, 23 Feb\n 2023 22:28:00 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>\n <20230223180223.g6fy72hjttgbhdmb@pali>","In-Reply-To":"<20230223180223.g6fy72hjttgbhdmb@pali>","From":"Martin Rowe <martin.p.rowe@gmail.com>","Date":"Fri, 24 Feb 2023 06:27:49 +0000","Message-ID":"\n <CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3064974,"web_url":"http://patchwork.ozlabs.org/comment/3064974/","msgid":"<CAOAjy5SVFN6Uf1_gooTRbxUE2znNSP79GgUPJfhGZEnmZATbsg@mail.gmail.com>","list_archive_url":null,"date":"2023-02-24T15:07:03","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":85861,"url":"http://patchwork.ozlabs.org/api/people/85861/","name":"Martin Rowe","email":"martin.p.rowe@gmail.com"},"content":"[PATCH 1/2] arm: mvebu: clearfog: Fix MMC detection\n\nA388 Clearfog MMC is either SD Card or eMMC with different behaviour for\nboth. Setting MMC_BROKEN_CD allows both to correctly detect MMC.\n\nSigned-off-by: Martin Rowe <martin.p.rowe@gmail.com>\n---\n configs/clearfog_defconfig      | 3 +--\n configs/clearfog_sata_defconfig | 8 ++++----\n 2 files changed, 5 insertions(+), 6 deletions(-)\n\ndiff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig\nindex 8cd35f9f1a..24e7c16ac7 100644\n--- a/configs/clearfog_defconfig\n+++ b/configs/clearfog_defconfig\n@@ -46,7 +46,6 @@ CONFIG_CMD_USB=y\n CONFIG_CMD_TFTPPUT=y\n CONFIG_CMD_CACHE=y\n CONFIG_CMD_TIME=y\n-CONFIG_CMD_MVEBU_BUBT=y\n CONFIG_ENV_OVERWRITE=y\n CONFIG_ENV_MIN_ENTRIES=128\n CONFIG_ARP_TIMEOUT=200\n@@ -59,7 +58,7 @@ CONFIG_DM_I2C=y\n CONFIG_SYS_I2C_MVTWSI=y\n CONFIG_I2C_EEPROM=y\n CONFIG_SPL_I2C_EEPROM=y\n-CONFIG_SUPPORT_EMMC_BOOT=y\n+CONFIG_MMC_BROKEN_CD=y\n CONFIG_MMC_SDHCI=y\n CONFIG_MMC_SDHCI_SDMA=y\n CONFIG_MMC_SDHCI_MV=y\ndiff --git a/configs/clearfog_sata_defconfig b/configs/clearfog_sata_defconfig\nindex e9b36150ea..84f900bf50 100644\n--- a/configs/clearfog_sata_defconfig\n+++ b/configs/clearfog_sata_defconfig\n@@ -6,11 +6,14 @@ CONFIG_TEXT_BASE=0x00800000\n CONFIG_SPL_LIBCOMMON_SUPPORT=y\n CONFIG_SPL_LIBGENERIC_SUPPORT=y\n CONFIG_NR_DRAM_BANKS=2\n+CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y\n+CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xff0000\n CONFIG_TARGET_CLEARFOG=y\n CONFIG_MVEBU_SPL_BOOT_DEVICE_SATA=y\n CONFIG_DEFAULT_DEVICE_TREE=\"armada-388-clearfog\"\n CONFIG_SPL_TEXT_BASE=0x40000030\n CONFIG_SPL_SERIAL=y\n+CONFIG_SPL_STACK=0x4002c000\n CONFIG_SPL=y\n CONFIG_DEBUG_UART_BASE=0xf1012000\n CONFIG_DEBUG_UART_CLOCK=250000000\n@@ -18,8 +21,6 @@ CONFIG_SYS_LOAD_ADDR=0x800000\n CONFIG_DEBUG_UART=y\n CONFIG_AHCI=y\n CONFIG_DISTRO_DEFAULTS=y\n-CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y\n-CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xff0000\n CONFIG_BOOTDELAY=3\n CONFIG_USE_PREBOOT=y\n CONFIG_SYS_CONSOLE_INFO_QUIET=y\n@@ -31,7 +32,6 @@ CONFIG_SPL_BSS_START_ADDR=0x40023000\n CONFIG_SPL_BSS_MAX_SIZE=0x4000\n CONFIG_SPL_SYS_MALLOC_SIMPLE=y\n # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set\n-CONFIG_SPL_STACK=0x4002c000\n CONFIG_SPL_I2C=y\n CONFIG_SYS_MAXARGS=32\n CONFIG_CMD_TLV_EEPROM=y\n@@ -46,7 +46,6 @@ CONFIG_CMD_USB=y\n CONFIG_CMD_TFTPPUT=y\n CONFIG_CMD_CACHE=y\n CONFIG_CMD_TIME=y\n-CONFIG_CMD_MVEBU_BUBT=y\n CONFIG_ENV_OVERWRITE=y\n CONFIG_ENV_MIN_ENTRIES=128\n CONFIG_ARP_TIMEOUT=200\n@@ -59,6 +58,7 @@ CONFIG_DM_I2C=y\n CONFIG_SYS_I2C_MVTWSI=y\n CONFIG_I2C_EEPROM=y\n CONFIG_SPL_I2C_EEPROM=y\n+CONFIG_MMC_BROKEN_CD=y\n CONFIG_SUPPORT_EMMC_BOOT=y\n CONFIG_MMC_SDHCI=y\n CONFIG_MMC_SDHCI_SDMA=y","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=m8zVqEzQ;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"m8zVqEzQ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=martin.p.rowe@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PNYCn5xLQz240f\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Feb 2023 02:07:32 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A286585B5A;\n\tFri, 24 Feb 2023 16:07:20 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 4313B85B5E; Fri, 24 Feb 2023 16:07:19 +0100 (CET)","from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com\n [IPv6:2607:f8b0:4864:20::22d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0FBB185B55\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 16:07:16 +0100 (CET)","by mail-oi1-x22d.google.com with SMTP id o12so9054243oik.6\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 07:07:15 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FFxxUKVkhdnKKGz0nX6Lukb3f3pyCUTA6G3Ut4XgxUI=;\n b=m8zVqEzQeocc3EuxNSPvgXX9X2mIoRdlRAKrZ7P9iMM0yLJ+rzx+RhBEzhRcpA5ym9\n jOBw24KiI1X1hHS88MPl3s2KG1o43b97XVG+4wK1b1F5gLb5SVWrX1yE72SqO0Rf8PDR\n HK4HxvMQtSX8mpueAmY5Bfs+FfqaKLptzRlejUar5Tskh6Ab70ICYR4p+t2Y8q/f7pR4\n TMX33WJvq4DoBLXAKdgDUzMXz3a/W7oUCgtmK5aQqFYKSWa5EZVpxtY3ykcC6Kkx/HTy\n qtJFDAutg4YA6hgZmzZHcWSjnp/c1wai0WPCPQ0BKcYhJmQImo/npG1QGZMeMomKP8NW\n 7Bag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=FFxxUKVkhdnKKGz0nX6Lukb3f3pyCUTA6G3Ut4XgxUI=;\n b=DxcJzi9MuP5cmctoZzGBiDPdja5IHlJ73wKlghUvRRN/zWdjxicJzmY4n/xd8PD1vi\n eoVjjnbLeTplSSdpl3MX3stTPMITOu5NLUO5ayDKidj7a2LnHjf34/eRrIEBhW+COb6K\n ojy0FMy12TW7JHsLQBLJ1UoPtiwGxQHw5eM1kaW1BwzcT2If4XrErADgMoObgM7CJ1Z2\n XCZMKTK4z81s+GZMERSj7w0XnDhK4I1BU5yopB/zInYB3v+Td2rBtDfpYHVpRll8ttZN\n ogkaDhIzXLFmw3JIk1wJmOePvwZ9t5tqSB1Orh3v85dHaBmheCjJRZOhqL7Bmd9FHcel\n alig==","X-Gm-Message-State":"AO0yUKWBV8IM3y4bmp+kgYHmw+M6qevm+iLa/aOz5mGQwg975bRPneqQ\n 2mi8CzgvEX66GOYiJsLhjavEeQH4EadzjItFxwI=","X-Google-Smtp-Source":"\n AK7set9UhhwgoAQsCPhJJHmDF4E3pCEV7jcQuCygTDozWnvmiswFTFGZKiIG9/SRkqhIOZ6lNwLJPjNGQoDNTzNnIRI=","X-Received":"by 2002:a54:480c:0:b0:37d:b58a:6192 with SMTP id\n j12-20020a54480c000000b0037db58a6192mr1285558oij.3.1677251234486; Fri, 24 Feb\n 2023 07:07:14 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>","In-Reply-To":"<20230222212356.abfhl7omg35hwizc@pali>","From":"Martin Rowe <martin.p.rowe@gmail.com>","Date":"Fri, 24 Feb 2023 15:07:03 +0000","Message-ID":"\n <CAOAjy5SVFN6Uf1_gooTRbxUE2znNSP79GgUPJfhGZEnmZATbsg@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3064976,"web_url":"http://patchwork.ozlabs.org/comment/3064976/","msgid":"<CAOAjy5QU-Jao+k3Ada+YAn74HvMbtTNBkh+uanSfqpUT_dMLkg@mail.gmail.com>","list_archive_url":null,"date":"2023-02-24T15:07:43","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":85861,"url":"http://patchwork.ozlabs.org/api/people/85861/","name":"Martin Rowe","email":"martin.p.rowe@gmail.com"},"content":"[PATCH 2/2] arm: mvebu: clearfog: Add defconfig for SPI booting\n\nThis new clearfog_spi_defconfig file is copy of existing\nclearfog_defconfig file and changed to instruct build system to\ngenerate final kwbimage for SPI booting and to store the\nenvironment in SPI as well.\n\nSigned-off-by: Martin Rowe <martin.p.rowe@gmail.com>\n---\n configs/clearfog_spi_defconfig | 88 ++++++++++++++++++++++++++++++++++\n 1 file changed, 88 insertions(+)\n create mode 100644 configs/clearfog_spi_defconfig\n\ndiff --git a/configs/clearfog_spi_defconfig b/configs/clearfog_spi_defconfig\nnew file mode 100644\nindex 0000000000..31b1e9fce8\n--- /dev/null\n+++ b/configs/clearfog_spi_defconfig\n@@ -0,0 +1,88 @@\n+CONFIG_ARM=y\n+CONFIG_ARCH_CPU_INIT=y\n+CONFIG_SYS_THUMB_BUILD=y\n+CONFIG_ARCH_MVEBU=y\n+CONFIG_TEXT_BASE=0x00800000\n+CONFIG_SPL_GPIO=y\n+CONFIG_SPL_LIBCOMMON_SUPPORT=y\n+CONFIG_SPL_LIBGENERIC_SUPPORT=y\n+CONFIG_NR_DRAM_BANKS=2\n+CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y\n+CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xff0000\n+CONFIG_TARGET_CLEARFOG=y\n+CONFIG_ENV_SECT_SIZE=0x10000\n+CONFIG_DEFAULT_DEVICE_TREE=\"armada-388-clearfog\"\n+CONFIG_SPL_TEXT_BASE=0x40000030\n+CONFIG_SPL_MMC=y\n+CONFIG_SPL_SERIAL=y\n+CONFIG_SPL_STACK=0x4002c000\n+CONFIG_SPL=y\n+CONFIG_DEBUG_UART_BASE=0xf1012000\n+CONFIG_DEBUG_UART_CLOCK=250000000\n+CONFIG_SPL_LIBDISK_SUPPORT=y\n+# CONFIG_SPL_SPI is not set\n+CONFIG_SYS_LOAD_ADDR=0x800000\n+CONFIG_DEBUG_UART=y\n+CONFIG_AHCI=y\n+CONFIG_DISTRO_DEFAULTS=y\n+CONFIG_BOOTDELAY=3\n+CONFIG_USE_PREBOOT=y\n+CONFIG_SYS_CONSOLE_INFO_QUIET=y\n+# CONFIG_DISPLAY_BOARDINFO is not set\n+CONFIG_DISPLAY_BOARDINFO_LATE=y\n+CONFIG_SPL_MAX_SIZE=0x22fd0\n+CONFIG_SPL_HAS_BSS_LINKER_SECTION=y\n+CONFIG_SPL_BSS_START_ADDR=0x40023000\n+CONFIG_SPL_BSS_MAX_SIZE=0x4000\n+CONFIG_SPL_SYS_MALLOC_SIMPLE=y\n+# CONFIG_SPL_SHARES_INIT_SP_ADDR is not set\n+CONFIG_SPL_I2C=y\n+CONFIG_SYS_MAXARGS=32\n+CONFIG_CMD_TLV_EEPROM=y\n+CONFIG_SPL_CMD_TLV_EEPROM=y\n+# CONFIG_CMD_FLASH is not set\n+CONFIG_CMD_GPIO=y\n+CONFIG_CMD_I2C=y\n+CONFIG_CMD_MMC=y\n+CONFIG_CMD_PCI=y\n+CONFIG_CMD_SPI=y\n+CONFIG_CMD_USB=y\n+CONFIG_CMD_TFTPPUT=y\n+CONFIG_CMD_CACHE=y\n+CONFIG_CMD_TIME=y\n+CONFIG_ENV_OVERWRITE=y\n+CONFIG_ENV_MIN_ENTRIES=128\n+CONFIG_ARP_TIMEOUT=200\n+CONFIG_NET_RETRY_COUNT=50\n+CONFIG_NET_RANDOM_ETHADDR=y\n+CONFIG_SPL_OF_TRANSLATE=y\n+CONFIG_AHCI_MVEBU=y\n+CONFIG_DM_PCA953X=y\n+CONFIG_DM_I2C=y\n+CONFIG_SYS_I2C_MVTWSI=y\n+CONFIG_I2C_EEPROM=y\n+CONFIG_SPL_I2C_EEPROM=y\n+CONFIG_MMC_BROKEN_CD=y\n+CONFIG_SPL_DM_MMC=y\n+CONFIG_SUPPORT_EMMC_BOOT=y\n+CONFIG_MMC_SDHCI=y\n+CONFIG_MMC_SDHCI_SDMA=y\n+CONFIG_MMC_SDHCI_MV=y\n+CONFIG_MTD=y\n+CONFIG_SF_DEFAULT_BUS=1\n+CONFIG_SPI_FLASH_WINBOND=y\n+CONFIG_SPI_FLASH_MTD=y\n+CONFIG_PHY_MARVELL=y\n+CONFIG_PHY_GIGE=y\n+CONFIG_MVNETA=y\n+CONFIG_MII=y\n+CONFIG_MVMDIO=y\n+CONFIG_PCI=y\n+CONFIG_PCI_MVEBU=y\n+CONFIG_SCSI=y\n+CONFIG_SPL_DEBUG_UART_BASE=0xd0012000\n+CONFIG_DEBUG_UART_SHIFT=2\n+CONFIG_SYS_NS16550=y\n+CONFIG_KIRKWOOD_SPI=y\n+CONFIG_USB=y\n+CONFIG_USB_XHCI_HCD=y","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=VyoZ0qXA;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"VyoZ0qXA\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=martin.p.rowe@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PNYDn72zCz240f\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Feb 2023 02:08:25 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C0E0085B58;\n\tFri, 24 Feb 2023 16:08:22 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id A365085B58; Fri, 24 Feb 2023 16:08:19 +0100 (CET)","from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com\n [IPv6:2607:f8b0:4864:20::32c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A4A7285B58\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 16:07:56 +0100 (CET)","by mail-ot1-x32c.google.com with SMTP id\n g6-20020a056830308600b0068d4b30536aso3953727ots.9\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 07:07:56 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=ow2QtYCi0X3J+FyVpFre7hpt1BquLhw0fD6uIkkoIr8=;\n b=VyoZ0qXAokbzpDVxDcweNzKmkU+yfgGHWlbsIshGVYh0eUjpFyC8PkfkRNKYahLRy8\n 9tVJ/6dbT/g6mIZ2zZa3vELwRaG/1LQXCHPm00A68U8XNorW08oy/8Vdtdewfc/hGrFT\n HZmii2cawOEVW9a3w6QuNVjvbWI770SXjEywanXuNOpQTP4Uj09zYivAgYTzP7Hpw3V6\n x666DJyxk+l0dTJU0IjAQ/kpiyCFbm5oXSaQ6VWzwjm0aN5uZhArU9ppCsw6iOYOee9M\n IhapK8FYhp7HZFzayKTiJdULizXpSlT83BMlQE5Xp38qdGeReaRI9vY+oPgICbUQm6fl\n q3VA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=ow2QtYCi0X3J+FyVpFre7hpt1BquLhw0fD6uIkkoIr8=;\n b=JN9ajU+Uqk/rsD+Y6jR5Ji1eHIUrTjpRTtT9jA6WLFlhaSnmatVvCIZJ1wvAPY2mz1\n +ZPMkn94nspD7n8BDcTkQhFHF53hTg31ku4d1lhnYudBG/+6JoMX9cEpESPdoDKLyWj/\n SKf9MFWnerki6GAAZlQDmvRaG7rNX07o0NPi3XShMvGIylf56JMWbJJOM1B2DkDJbHsR\n FbUjD+sQCUtVeALnNc61QouAmIFREsyTdLDKYbQ+/sriMld7qfXchgiwgcMx8gn9F/2q\n AfRxiksdHOS34nYFqC39uABzXXT2Dm9BixEIy47y+KBUN64sf5Sgo6ESn4fplnCmfYQ5\n V3Vg==","X-Gm-Message-State":"AO0yUKXyxOFRDx2jlJFNM7Y7Vt2z1nPz2Vlpu+4526OrvlEeaLL+4YTb\n xZiiPjBOcmGrFKdsIRyA2+Qm8gBJ0izNFeTOqvGcb7tUP7LiZQ==","X-Google-Smtp-Source":"\n AK7set8j2TgA2sxEzi9Fjtu6x30YVCj7Sd+/j66DRRdWZq7+PK5F1uJZt/BlYejuCBBMQn/craHaYI542FaDXHzWHns=","X-Received":"by 2002:a05:6830:33d1:b0:68b:8067:b5d4 with SMTP id\n q17-20020a05683033d100b0068b8067b5d4mr1764563ott.3.1677251274875; Fri, 24 Feb\n 2023 07:07:54 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>\n <20230223180223.g6fy72hjttgbhdmb@pali>\n <CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>","In-Reply-To":"\n <CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>","From":"Martin Rowe <martin.p.rowe@gmail.com>","Date":"Fri, 24 Feb 2023 15:07:43 +0000","Message-ID":"\n <CAOAjy5QU-Jao+k3Ada+YAn74HvMbtTNBkh+uanSfqpUT_dMLkg@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3064995,"web_url":"http://patchwork.ozlabs.org/comment/3064995/","msgid":"<42ef3ce1-485a-63c6-d39b-ad8b4ae08565@denx.de>","list_archive_url":null,"date":"2023-02-24T15:22:32","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"Hi Martin,\n\nOn 2/24/23 16:07, Martin Rowe wrote:\n> [PATCH 1/2] arm: mvebu: clearfog: Fix MMC detection\n> \n> A388 Clearfog MMC is either SD Card or eMMC with different behaviour for\n> both. Setting MMC_BROKEN_CD allows both to correctly detect MMC.\n> \n> Signed-off-by: Martin Rowe <martin.p.rowe@gmail.com>\n\nPlease note that this patch is sent to the list a s reply to the\nRFC patchset from Pali. Something went wrong here, so that the\ncommit subject was not used. Also for the 2nd patch.\n\nAnother comment below.\n\n> ---\n>   configs/clearfog_defconfig      | 3 +--\n>   configs/clearfog_sata_defconfig | 8 ++++----\n>   2 files changed, 5 insertions(+), 6 deletions(-)\n> \n> diff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig\n> index 8cd35f9f1a..24e7c16ac7 100644\n> --- a/configs/clearfog_defconfig\n> +++ b/configs/clearfog_defconfig\n> @@ -46,7 +46,6 @@ CONFIG_CMD_USB=y\n>   CONFIG_CMD_TFTPPUT=y\n>   CONFIG_CMD_CACHE=y\n>   CONFIG_CMD_TIME=y\n> -CONFIG_CMD_MVEBU_BUBT=y\n\nYou are removing the bubt cmd here. This is most likely a mistake.\n\nSo please re-send the patches with a correct subject and also without\nremoving the bubt cmd support.\n\nThanks,\nStefan\n\n>   CONFIG_ENV_OVERWRITE=y\n>   CONFIG_ENV_MIN_ENTRIES=128\n>   CONFIG_ARP_TIMEOUT=200\n> @@ -59,7 +58,7 @@ CONFIG_DM_I2C=y\n>   CONFIG_SYS_I2C_MVTWSI=y\n>   CONFIG_I2C_EEPROM=y\n>   CONFIG_SPL_I2C_EEPROM=y\n> -CONFIG_SUPPORT_EMMC_BOOT=y\n> +CONFIG_MMC_BROKEN_CD=y\n>   CONFIG_MMC_SDHCI=y\n>   CONFIG_MMC_SDHCI_SDMA=y\n>   CONFIG_MMC_SDHCI_MV=y\n> diff --git a/configs/clearfog_sata_defconfig b/configs/clearfog_sata_defconfig\n> index e9b36150ea..84f900bf50 100644\n> --- a/configs/clearfog_sata_defconfig\n> +++ b/configs/clearfog_sata_defconfig\n> @@ -6,11 +6,14 @@ CONFIG_TEXT_BASE=0x00800000\n>   CONFIG_SPL_LIBCOMMON_SUPPORT=y\n>   CONFIG_SPL_LIBGENERIC_SUPPORT=y\n>   CONFIG_NR_DRAM_BANKS=2\n> +CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y\n> +CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xff0000\n>   CONFIG_TARGET_CLEARFOG=y\n>   CONFIG_MVEBU_SPL_BOOT_DEVICE_SATA=y\n>   CONFIG_DEFAULT_DEVICE_TREE=\"armada-388-clearfog\"\n>   CONFIG_SPL_TEXT_BASE=0x40000030\n>   CONFIG_SPL_SERIAL=y\n> +CONFIG_SPL_STACK=0x4002c000\n>   CONFIG_SPL=y\n>   CONFIG_DEBUG_UART_BASE=0xf1012000\n>   CONFIG_DEBUG_UART_CLOCK=250000000\n> @@ -18,8 +21,6 @@ CONFIG_SYS_LOAD_ADDR=0x800000\n>   CONFIG_DEBUG_UART=y\n>   CONFIG_AHCI=y\n>   CONFIG_DISTRO_DEFAULTS=y\n> -CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y\n> -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xff0000\n>   CONFIG_BOOTDELAY=3\n>   CONFIG_USE_PREBOOT=y\n>   CONFIG_SYS_CONSOLE_INFO_QUIET=y\n> @@ -31,7 +32,6 @@ CONFIG_SPL_BSS_START_ADDR=0x40023000\n>   CONFIG_SPL_BSS_MAX_SIZE=0x4000\n>   CONFIG_SPL_SYS_MALLOC_SIMPLE=y\n>   # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set\n> -CONFIG_SPL_STACK=0x4002c000\n>   CONFIG_SPL_I2C=y\n>   CONFIG_SYS_MAXARGS=32\n>   CONFIG_CMD_TLV_EEPROM=y\n> @@ -46,7 +46,6 @@ CONFIG_CMD_USB=y\n>   CONFIG_CMD_TFTPPUT=y\n>   CONFIG_CMD_CACHE=y\n>   CONFIG_CMD_TIME=y\n> -CONFIG_CMD_MVEBU_BUBT=y\n>   CONFIG_ENV_OVERWRITE=y\n>   CONFIG_ENV_MIN_ENTRIES=128\n>   CONFIG_ARP_TIMEOUT=200\n> @@ -59,6 +58,7 @@ CONFIG_DM_I2C=y\n>   CONFIG_SYS_I2C_MVTWSI=y\n>   CONFIG_I2C_EEPROM=y\n>   CONFIG_SPL_I2C_EEPROM=y\n> +CONFIG_MMC_BROKEN_CD=y\n>   CONFIG_SUPPORT_EMMC_BOOT=y\n>   CONFIG_MMC_SDHCI=y\n>   CONFIG_MMC_SDHCI_SDMA=y\n\nViele Grüße,\nStefan Roese","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=denx.de header.i=@denx.de header.a=rsa-sha256\n header.s=phobos-20191101 header.b=eJJvulnw;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=denx.de","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=denx.de","phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PNYYK6NWhz240f\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Feb 2023 02:22:45 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 97AB385B67;\n\tFri, 24 Feb 2023 16:22:39 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 1512985AFB; Fri, 24 Feb 2023 16:22:38 +0100 (CET)","from mout-u-107.mailbox.org (mout-u-107.mailbox.org\n [IPv6:2001:67c:2050:101:465::107])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7436385AFB\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 16:22:35 +0100 (CET)","from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest\n SHA256) (No client certificate requested)\n by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4PNYY51rf3z9sR8;\n Fri, 24 Feb 2023 16:22:33 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de;\n\ts=phobos-20191101; t=1677252160;\n\tbh=GwRbjDBdkCUkwsNHP4DtiL+t1XaIAn1lbH05W8A/Sw0=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=eJJvulnwpVG8tz+JDkhPOgnzz7ZbBGUNUyNz3Vuz/R/fxflsnLvAsKyiUXBB8piKz\n\t TXfejhovRaOJpwuV1fFk1stE6N9K0J4p41RsneJx9lnn8HgRxxTnyaWMLPhiw+SDvE\n\t s8lb2LVCwr1R6DDl6T1UQr2VZYQyWPWo+MjH4pXY23mQRlIrStDYkn/z1SZ5ncS2/4\n\t 2IKU9G3YGP3GbATQeSn3d19yaRWLdmdgkbl30ytQUcfrxOtPl2HUbqsP6l958vggEy\n\t l5VI19jEUun4qhnIU7cXu9XCn6v/iOv/YKPG7MZu1xIIjGZRFust5R+9BjmoCIEHl6\n\t N6IJoDPCGGAbg==","X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,SPF_HELO_NONE,\n SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2","Message-ID":"<42ef3ce1-485a-63c6-d39b-ad8b4ae08565@denx.de>","Date":"Fri, 24 Feb 2023 16:22:32 +0100","MIME-Version":"1.0","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Content-Language":"en-US","To":"Martin Rowe <martin.p.rowe@gmail.com>,\n =?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Josua Mayer <josua@solid-run.com>","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SVFN6Uf1_gooTRbxUE2znNSP79GgUPJfhGZEnmZATbsg@mail.gmail.com>","From":"Stefan Roese <sr@denx.de>","In-Reply-To":"\n <CAOAjy5SVFN6Uf1_gooTRbxUE2znNSP79GgUPJfhGZEnmZATbsg@mail.gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3065000,"web_url":"http://patchwork.ozlabs.org/comment/3065000/","msgid":"<CAOAjy5SPWVF36iLgNu0B5pH-mUvZt-BF0HPATx12_bMaiWn2Fw@mail.gmail.com>","list_archive_url":null,"date":"2023-02-24T15:41:01","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":85861,"url":"http://patchwork.ozlabs.org/api/people/85861/","name":"Martin Rowe","email":"martin.p.rowe@gmail.com"},"content":"> Please note that this patch is sent to the list a s reply to the\n> RFC patchset from Pali. Something went wrong here, so that the\n> commit subject was not used. Also for the 2nd patch.\n\nAh, sorry, I'm not really set up for this. The first patch branches\nfrom Pali's RFC, though, so maybe it would be best to include my two\nwhen the final mvebu changes are sent in?\n\n> You are removing the bubt cmd here. This is most likely a mistake.\n\nI had to double check this as well, but CONFIG_MMC_BROKEN_CD also\nenables bubt for some reason, so it's definitely still included in the\nconfig but gets removed by savedefconfig.\n\nMartin","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=FHfwQ5h1;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"FHfwQ5h1\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=martin.p.rowe@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PNYyx5mXcz240V\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Feb 2023 02:41:28 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 19AF985B5E;\n\tFri, 24 Feb 2023 16:41:20 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 6BBE085B7A; Fri, 24 Feb 2023 16:41:17 +0100 (CET)","from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com\n [IPv6:2001:4860:4864:20::2f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 52C2A85AF7\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 16:41:14 +0100 (CET)","by mail-oa1-x2f.google.com with SMTP id\n 586e51a60fabf-17264e9b575so10892782fac.9\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 07:41:14 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=eObU/VQp2kuT5yb5n0HxbsU3brbpOJghXrYrJ9Zz0jQ=;\n b=FHfwQ5h1scFuchcB9WY7EPuwvz70PJQ5H0jwyvBt78X/muvj2M2qKQ3tgSAtNDHREn\n tkMFPN4l/MGHsPP3Og+pLt4TUhy4GjYHoyLkmrDGLUObLq4lTMgyAA16VLRQel1SLLrm\n rALLT3KV6xxph7SznL1zeaJZ5tdApVmT4ZOyXjFWWUGKkKSpO0wxO+vuAGfWEFl873Fs\n LV79WvRxKiRabwtHcaVuBbuz+oqyhlK68MtB81YgxqLnQDRZfzSvg7x6AsCufr2Yzxg4\n +e+pcVbIKTP1QretKWb9dmzoC/HBMBhOFihQ+Kb9gkmgbyImkkMy21GuX+CZhZXDKFKG\n XVJw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=eObU/VQp2kuT5yb5n0HxbsU3brbpOJghXrYrJ9Zz0jQ=;\n b=HIyBtqFradabBcHa7f0MaWASvgF90cz/OpwoqW76TZVbxbWgY7cP4wOaXs3tQCo86Y\n CxZlnMplWLpaPAHTNAzGKqoX4HTiB/BEzkdo/noS8FuzjMcoZcjmmtSmng+5PcR4YnND\n Vj15Kp77cW1uZc8m95PbBpyaG8V/NKFYwGNi3guFcXNb4U7mganaZ7VKfhdcuVAmqFUR\n SzMOdFe6iZF9cTcYciZJKwnGc4pbDEWbulphGLZgd9pddo1ONNHETZAp6p9oe4sK39Mb\n UFJMfX/dptMvfZn5PnF7jZToyoXczwAKJE6IRvZEpw00/kAy3PkaoK8VgTFX+BdZaLVJ\n 2PiA==","X-Gm-Message-State":"AO0yUKWNL69DrUbkgxpku6ejZRlUTqYdQl8d3jT+zR3p0Dt3QJAfEzmX\n BpBlz430fryiVWoYyBpb/C4sj9Uf7dfB8b0VAs9jBhFBRgQoUw==","X-Google-Smtp-Source":"\n AK7set/Ex0ffE5FBOVY8QV29hHXwVFQrf7Xk7gZxUA5y8QGhpEsJyWz1NSsJ2f9zaPVSh3mO9SxtCEHtOfSW2p2LhzQ=","X-Received":"by 2002:a05:6870:8c34:b0:172:5195:753 with SMTP id\n ec52-20020a0568708c3400b0017251950753mr1129754oab.3.1677253272942; Fri, 24\n Feb 2023 07:41:12 -0800 (PST)","MIME-Version":"1.0","References":"<20230221201925.9644-1-pali@kernel.org>\n <CAJaLiFykxiU9LL=DTtHVgsh4GcF12R+GNdYd6M70BdvWSv0ALQ@mail.gmail.com>\n <20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SVFN6Uf1_gooTRbxUE2znNSP79GgUPJfhGZEnmZATbsg@mail.gmail.com>\n <42ef3ce1-485a-63c6-d39b-ad8b4ae08565@denx.de>","In-Reply-To":"<42ef3ce1-485a-63c6-d39b-ad8b4ae08565@denx.de>","From":"Martin Rowe <martin.p.rowe@gmail.com>","Date":"Fri, 24 Feb 2023 15:41:01 +0000","Message-ID":"\n <CAOAjy5SPWVF36iLgNu0B5pH-mUvZt-BF0HPATx12_bMaiWn2Fw@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"Stefan Roese <sr@denx.de>","Cc":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>,\n  Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3065148,"web_url":"http://patchwork.ozlabs.org/comment/3065148/","msgid":"<20230224223303.dcr4x2xgs5dnexgc@pali>","list_archive_url":null,"date":"2023-02-24T22:33:03","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Friday 24 February 2023 06:27:49 Martin Rowe wrote:\n> > > boot0 - zeroed\n> > > boot1 - u-boot (with local version 'boot1')\n> > > user - u-boot (with local version 'user')\n> > Can you check if boot_ack argument has some effect on the initial\n> > choice? Or if completely disabling boot partitions (boot_enable to 0)\n> > have some effect?\n> \n> boot_ack doesn't appear to do anything. I can only set 0 or 1 and\n> there's no noticeable change to the boot process.\n\nOk.\n\n> Setting `mmc partconf 0 0 0 0` with the same setup as described above\n> results in the same BootROM fallback from BOOT0 to BOOT1, then SPL in\n> BOOT1 loads u-boot from the user area, which is identical to the `mmc\n> partconf 0 0 7 0` flow.\n\nOk.\n\n> > If really EXT_CSD[179] register is completely ignored we may change SPL\n> > to always boot from BOOT0 (when eMMC with boot partitions is used) and\n> > if it fails then fallback to BootROM booting.\n> \n> Is there a way of knowing where the SPL was loaded from?\n\nI was trying to figure it out but it looks like that bootrom stores this\ninformation into variable on the bootrom stack. So I think that this is\nimpossible.\n\n> Because it\n> would make sense to me that if SPL was loaded from BOOT1 to try and\n> load u-boot from BOOT1 as well, or from BOOT0 if SPL was loaded from\n> BOOT0, etc. Having u-boot loaded from a different location is not what\n> I expected and seems like it would cause a lot of confusion,\n> especially in a failed A/B rollout.\n\nExactly, I want to avoid it.\n\n> BootROM seems to completely ignore\n> the setting, so I agree that SPL should ignore it as well, but\n> hardcoding BOOT0 (or even setting the partition as a compile-time\n> option) is probably not a great outcome.\n\nIt is a solution and nice trick to how to fix it. Reason is that if SPL\nfails to load U-Boot from selected partition then it fallbacks to the\nBootROM, which loads U-Boot from the correct location.\n\nSo if we hardcode partition to BOOT0 then it obviously works correctly\nwhen SPL+U-Boot is on BOOT0. And if it is stored on BOOT1 or USER then\nBootROM already has to fail load it from BOOT0, which means that on\nBOOT0 is not valid U-Boot and when SPL tries to load main U-Boot from\nBOOT0 it fails too, and it returns control to the BootROM which knows\nthat it should load it from BOOT0. And this would work also for DATA.\n\n> Two observations that might help here:\n> 1. After reset, running `mmc partconf 0` always shows PARTITION_ACCESS\n> is set to 0x0, even it it was set to something else prior to reset\n\nOk, so access permissions are reset. I do not know if this is in MMC\nstandard or not.\n\n> 2. With the same setup as described above and `mmc partconf 0 0 1 1`\n> the SPL eventually times out trying to load from the zeroed BOOT0 and\n> returns to BootROM, which results in u-boot being loaded from BOOT1:\n\nAccess permissions can disable access to particular partition. So it\nmakes sense that it timeouts. And BootROM can always load and run main\nu-boot from the correct location. We are using SPL for loading main\nu-boot because this is way how it was first implemented and return to\nbootrom was broken in the past. Anyway, if you completely disable MMC\nsupport in SPL then SPL just returns control to BootROM which loads main\nU-Boot.\n\nReading main u-boot via BootROM is slower as from SPL for SPI-NOR\nbooting because SPL can use faster SPI transfers than BootROM. So this\nis the reason why we want in SPL to use native load method and not just\nBootROM. But maybe for MMC it would make sense?\n\n> =================================================\n> BootROM - 1.73\n> \n> Booting from MMC\n> BootROM: Bad header at offset 00000000\n> BootROM: Bad header at offset 00200000\n> Switching BootPartitions.\n> \n> U-Boot SPL 2023.04-rc2boot1-00098-g93408c61cd-dirty (Feb 23 2023 -\n> 19:43:59 +1000)\n> High speed PHY - Version: 2.0\n> EEPROM TLV detection failed: Using static config for Clearfog Pro.\n> Detected Device ID 6828\n> board SerDes lanes topology details:\n>  | Lane # | Speed |  Type       |\n>  --------------------------------\n>  |   0    |   3   | SATA0       |\n>  |   1    |   0   | SGMII1      |\n>  |   2    |   5   | PCIe1       |\n>  |   3    |   5   | USB3 HOST1  |\n>  |   4    |   5   | PCIe2       |\n>  |   5    |   0   | SGMII2      |\n>  --------------------------------\n> High speed PHY - Ended Successfully\n> mv_ddr: 14.0.0\n> DDR3 Training Sequence - Switching XBAR Window to FastPath Window\n> mv_ddr: completed successfully\n> Trying to boot from MMC1\n> ERROR: Invalid kwbimage v1\n> mmc_load_image_raw_sector: mmc block read error\n> spl: mmc: wrong boot mode\n> Trying to boot from BOOTROM\n> Returning to BootROM (return address 0xffff05c4)...\n> Timeout waiting card ready\n> BootROM: Image checksum verification PASSED\n> \n> \n> U-Boot 2023.04-rc2boot1-00098-g93408c61cd-dirty (Feb 23 2023 - 19:43:59 +1000)\n> \n> SoC:   MV88F6828-A0 at 1600 MHz\n> DRAM:  1 GiB (800 MHz, 32-bit, ECC not enabled)\n> Core:  38 devices, 22 uclasses, devicetree: separate\n> MMC:   mv_sdh: 0\n> Loading Environment from MMC... *** Warning - bad CRC, using default environment\n> \n> Model: SolidRun Clearfog A1\n> Board: SolidRun Clearfog Pro\n> Net:\n> Warning: ethernet@70000 (eth1) using random MAC address - be:13:3f:c3:c2:19\n> eth1: ethernet@70000\n> Warning: ethernet@30000 (eth2) using random MAC address - be:4c:72:3e:eb:bc\n> , eth2: ethernet@30000\n> Warning: ethernet@34000 (eth3) using random MAC address - 86:e7:dd:8d:c5:c1\n> , eth3: ethernet@34000\n> Hit any key to stop autoboot:  0\n> =>\n> =================================================\n> \n> > Seems that something in mmc initialization code is buggy. You can try to\n> > debug it by starting disabling parts of initialization code until you\n> > find the line/function which makes those BootROM messages \"Timeout for\n> > status update!\".\n> \n> > Hm... Yes, \"offset\" string is not in your output, so that function is\n> > not called in SPL. Only in main U-Boot.\n> >\n> > What is in SPL called is board_early_init_f() function or\n> > fdtdec_board_setup() function or also board_late_init() function.\n> > Pointer to blob is in global variable gd->fdt_blob.\n> >\n> > Note that adding new properties/nodes into fdt blob may fail. So always\n> > check for return values of fdt_*() function! You would probably need to\n> > call fdt_increase_size() first to make a place for new properties.\n> \n> > Yes, it has a hook. It is called ft_board_setup() and is called\n> > immediately before booting linux kernel. Basically in this hook you\n> > should check if u-boot's blob was patched for eMMC and if yes then patch\n> > also blob passed as argument in that function, as this blob would be\n> > used for linux. See Turris Omnia hook for inspiration which fixups\n> > ethernet node for linux blob based on what is in u-boot blob:\n> > https://source.denx.de/u-boot/u-boot/-/blob/master/board/CZ.NIC/turris_omnia/turris_omnia.c\n> \n> Lots of great ideas to look into, plus the bubt and defconfig stuff.\n> I'll let you know how I go or if I get stuck again.\n\nOk!","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=CJY1JA4E;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"CJY1JA4E\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PNl6K2bnLz240k\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Feb 2023 09:33:27 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1A8B78572C;\n\tFri, 24 Feb 2023 23:33:15 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 8AF9B856E5; Fri, 24 Feb 2023 23:33:13 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 31D268572C\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 23:33:09 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 343A26197C;\n Fri, 24 Feb 2023 22:33:07 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 46974C433D2;\n Fri, 24 Feb 2023 22:33:06 +0000 (UTC)","by pali.im (Postfix)\n id 225F972C; Fri, 24 Feb 2023 23:33:03 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677277986;\n bh=86Ld3ENoHAWtu9/8Jc+HtkNKmjIHEw6gE6pAVDtXI5o=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=CJY1JA4EbzTEi1N1nchXXIrOx9jlFF0z12NTZIV7VfroXqzgA/Og/Ja2L5lilj7Lv\n UiJOTxcawmJu/ZCVEujjY5UY2EN2ALnE+8f/76QvuLaXYwMP9UnQ1eTRgw2rQZYove\n pxaaOUsmVegzWEAvBEZpM1Raf/d5gVfsi8cCS28laL9A92WS8xR5Y/pKwNGTlDVkTt\n Sa9gEfz03LU/pMUt//7pQUY9+sMH6en/tAMoyh6fo3DYM79bO40lazrR9Usce9y7nQ\n 0eP1czQWJHumnjosE9MZ+MEmuDjaoGhB2NzEmLoVah+9au4s8TwjgkjqbrpUpJdOdW\n iLVxbkKZ/csgA==","Date":"Fri, 24 Feb 2023 23:33:03 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Martin Rowe <martin.p.rowe@gmail.com>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230224223303.dcr4x2xgs5dnexgc@pali>","References":"<20230221231405.ln5fvxuvgzmwmbl5@pali>\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>\n <20230223180223.g6fy72hjttgbhdmb@pali>\n <CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3065149,"web_url":"http://patchwork.ozlabs.org/comment/3065149/","msgid":"<20230224223421.duckxwmax4efcn6g@pali>","list_archive_url":null,"date":"2023-02-24T22:34:21","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Friday 24 February 2023 15:07:43 Martin Rowe wrote:\n> [PATCH 2/2] arm: mvebu: clearfog: Add defconfig for SPI booting\n> \n> This new clearfog_spi_defconfig file is copy of existing\n> clearfog_defconfig file and changed to instruct build system to\n> generate final kwbimage for SPI booting and to store the\n> environment in SPI as well.\n> \n> Signed-off-by: Martin Rowe <martin.p.rowe@gmail.com>\n> ---\n>  configs/clearfog_spi_defconfig | 88 ++++++++++++++++++++++++++++++++++\n>  1 file changed, 88 insertions(+)\n>  create mode 100644 configs/clearfog_spi_defconfig\n> \n> diff --git a/configs/clearfog_spi_defconfig b/configs/clearfog_spi_defconfig\n> new file mode 100644\n> index 0000000000..31b1e9fce8\n> --- /dev/null\n> +++ b/configs/clearfog_spi_defconfig\n\nWhen generating this patch, use git options -M, -C and\n--find-copies-harder. It will detect that you created this file as copy\nfrom other file and generate better diff.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=tA1ALH3E;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"tA1ALH3E\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PNl7Y109Pz240k\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Feb 2023 09:34:33 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id AB58185B68;\n\tFri, 24 Feb 2023 23:34:30 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 4EEC885A28; Fri, 24 Feb 2023 23:34:29 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id EC0B585B68\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 23:34:26 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 799DC6197C;\n Fri, 24 Feb 2023 22:34:25 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id BA5D9C433D2;\n Fri, 24 Feb 2023 22:34:24 +0000 (UTC)","by pali.im (Postfix)\n id 0A9F672C; Fri, 24 Feb 2023 23:34:22 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677278064;\n bh=ZZ7Vps4cK8ifob440qgjySw231R0aaVtrQ71aY4tG50=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=tA1ALH3EekXqfCOu9SI8VybSO2BZtDIGWLTtxESEhqQO2E3JYObb5g/0u3qvkDKMT\n DnGdJD7Cfu7Co8aWuVy+vPIeBHRgKhrCxOFauQp8dGa6m4HxrusToSQHy7x/osXkW1\n +1tW5fZia+O4PWFV3qeDAQf7TbVT+Sb/DdxDXkvNcYklVmwda7XqNVl1j4I4PBNnFV\n Fx7qk2ixm2PVSaraH0gQi3aFSx5bsXoN/tpSHerhYk7s4AszQUVjP4hzAp3OQZhdzf\n TeYX3ZYMbiCHh3dz3LQAZEpXXEPWusQEjvyWgxNVvMGP33NNYtXpZNLofhRZ+RHa16\n gGhqzcyYFjiyQ==","Date":"Fri, 24 Feb 2023 23:34:21 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Martin Rowe <martin.p.rowe@gmail.com>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230224223421.duckxwmax4efcn6g@pali>","References":"\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>\n <20230223180223.g6fy72hjttgbhdmb@pali>\n <CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>\n <CAOAjy5QU-Jao+k3Ada+YAn74HvMbtTNBkh+uanSfqpUT_dMLkg@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <CAOAjy5QU-Jao+k3Ada+YAn74HvMbtTNBkh+uanSfqpUT_dMLkg@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3065170,"web_url":"http://patchwork.ozlabs.org/comment/3065170/","msgid":"<CAOAjy5RHu8XcP978gtGP5mLvVasMHbNvFFDn+U6zP6zLb4RdUg@mail.gmail.com>","list_archive_url":null,"date":"2023-02-25T01:18:26","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":85861,"url":"http://patchwork.ozlabs.org/api/people/85861/","name":"Martin Rowe","email":"martin.p.rowe@gmail.com"},"content":"> When generating this patch, use git options -M, -C and\n> --find-copies-harder. It will detect that you created this file as copy\n> from other file and generate better diff.\n\nWill do.\n\nThis thread has gotten quite long! I've:\n - tested all the boot modes and bubt update types\n - created the SPI defconfig,\n - fixed the eMMC detection by enabling MMC_BROKEN_CD\n - taken a look at the kwbimage documentation, but I don't think I can\nbe of much help there\nI'm also able to help test any new changes for the MMC boot flow. Is\nthere anything else that I've missed that I can help with while I've\ngot it all setup?\n\nMartin","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=pRcXj8It;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"pRcXj8It\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=martin.p.rowe@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PNpn70lnBz245s\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Feb 2023 12:18:49 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 64A1085A28;\n\tSat, 25 Feb 2023 02:18:43 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id AE17B85A28; Sat, 25 Feb 2023 02:18:41 +0100 (CET)","from mail-ot1-x333.google.com (mail-ot1-x333.google.com\n [IPv6:2607:f8b0:4864:20::333])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B42F0857E3\n for <u-boot@lists.denx.de>; Sat, 25 Feb 2023 02:18:38 +0100 (CET)","by mail-ot1-x333.google.com with SMTP id\n v17-20020a0568301bd100b0068dc615ee44so613858ota.10\n for <u-boot@lists.denx.de>; Fri, 24 Feb 2023 17:18:38 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=lOtgZsHQ6ku1carFmUmnuhke9Jzmtl9sO6wkDA9Ua+Y=;\n b=pRcXj8Iti5IumNJ2Tda29UpTc5R+CYGl1qM6oIlLEgKg4g50xbgi18bmD+tZ4P7cB2\n EuTrnYfOFygsHdH4t7xR7WhQ5JZ0ANTeL2VefcBZVfZ5XhRQmEzI80FlMwAfHsPJVyQf\n IpJRvAnRSml5Bm3bs0EpMjTQyXz8P7aktH8eQQceHX88qY3QKPsEAAooOTl7EbyDNPb0\n Y2ZZ2xIt5Dcde8dUpP7wJu2z6Fuqp/68FqzbuoxqVxQM+UnfjOg3cj+3FQVqsxOOGYbc\n aPIXpuI/y5Bd5JLEE9PTSaIOIHiFsV6iAQoLpYk9c2iCiVgiJmaTdKfm84dXUVW+J8WX\n k2wg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=lOtgZsHQ6ku1carFmUmnuhke9Jzmtl9sO6wkDA9Ua+Y=;\n b=g+wWvRYgBu19DOClIiQxTHLA1PbPqB4QRS9hGwCtFjd1ONqgHKQ4E7cL8xaVg/cRVI\n 5vrB34GGR5+dDobeFwHjiih7IStd95Q4ZwnxKXQj6z6anZVpM1GC43NyKQZEVbpHh7sk\n J+H7+56N4g9sn9MYOXT3qx9GLWm39PVfzpPWqT9Mn3G5W7SdnLGqmwZ5fyw9DMfJq1N2\n fKgC+ANr/U7B8yca+ayYMtLp2KLg3BrB+Ac8NyPMDodwxhowUlJPLKBv03EqJHtNFJ3O\n c44gc3klLxButk/LWumLJgkrUFzyYpJUcZRpvPHtIUIg2RLLAyZ0MA0+A+oE+kUThKHb\n 5Xww==","X-Gm-Message-State":"AO0yUKWRILk1qvb/ZTeedDSzj57FJS+HnK76hgCvJvvxNOfUoyg+2K7L\n BQbTJORw4Mf0lqVWK4aC8VWDimnbamXWYBToYYg=","X-Google-Smtp-Source":"\n AK7set/50A6JBOkf2XNfqs2gDd4TRnFNMtP0+ABlze0VLgxlpRhZkvGgADP6CnW/oRdaszIcuraPsJlaT738F29mfUU=","X-Received":"by 2002:a05:6830:2468:b0:690:ef0d:d946 with SMTP id\n x40-20020a056830246800b00690ef0dd946mr2168024otr.3.1677287917359; Fri, 24 Feb\n 2023 17:18:37 -0800 (PST)","MIME-Version":"1.0","References":"\n <CAJaLiFz8VWFKz54ywQ7SY=koH9phaOCWhwaZRHe96CakJo8g2w@mail.gmail.com>\n <20230222075819.6f3vl7nlnpqwpg6e@pali>\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>\n <20230223180223.g6fy72hjttgbhdmb@pali>\n <CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>\n <CAOAjy5QU-Jao+k3Ada+YAn74HvMbtTNBkh+uanSfqpUT_dMLkg@mail.gmail.com>\n <20230224223421.duckxwmax4efcn6g@pali>","In-Reply-To":"<20230224223421.duckxwmax4efcn6g@pali>","From":"Martin Rowe <martin.p.rowe@gmail.com>","Date":"Sat, 25 Feb 2023 01:18:26 +0000","Message-ID":"\n <CAOAjy5RHu8XcP978gtGP5mLvVasMHbNvFFDn+U6zP6zLb4RdUg@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3065361,"web_url":"http://patchwork.ozlabs.org/comment/3065361/","msgid":"<20230225211638.nw73tvclmibzpxqq@pali>","list_archive_url":null,"date":"2023-02-25T21:16:38","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Saturday 25 February 2023 01:18:26 Martin Rowe wrote:\n> > When generating this patch, use git options -M, -C and\n> > --find-copies-harder. It will detect that you created this file as copy\n> > from other file and generate better diff.\n> \n> Will do.\n> \n> This thread has gotten quite long! I've:\n>  - tested all the boot modes and bubt update types\n>  - created the SPI defconfig,\n>  - fixed the eMMC detection by enabling MMC_BROKEN_CD\n\nThanks!\n\n>  - taken a look at the kwbimage documentation, but I don't think I can\n> be of much help there\n> I'm also able to help test any new changes for the MMC boot flow. Is\n> there anything else that I've missed that I can help with while I've\n> got it all setup?\n> \n> Martin\n\nI think that the remaining part is to patch linux DTB file at runtime\nfor emmc support. So if u-boot mmc device is of eMMC type then fixup\nlinux dtb file and others do nothing.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=GlPkpE+0;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"GlPkpE+0\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PPKMS4XL6z240p\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Feb 2023 08:16:52 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 5734585927;\n\tSat, 25 Feb 2023 22:16:47 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id DC2DD85B84; Sat, 25 Feb 2023 22:16:45 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9D19D85843\n for <u-boot@lists.denx.de>; Sat, 25 Feb 2023 22:16:43 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 3554060B83;\n Sat, 25 Feb 2023 21:16:42 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7B1C9C433EF;\n Sat, 25 Feb 2023 21:16:41 +0000 (UTC)","by pali.im (Postfix)\n id C3901709; Sat, 25 Feb 2023 22:16:38 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677359801;\n bh=wSotzasP0vUvHzy9Ip+CRkFe8O6GyooPvkPPQwd9i8A=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=GlPkpE+0zM2GOl2QjE9uTsnu1j8/QuTeLAN3xC6cIDhfMuFgOampnmqmbEwWpLWNy\n k8ETeTPLNDDLDrRcELTl1ri6On2R0VtVo711WilgrBa6WGSbN92HFLMEAYdHi+cneU\n Ee1xdrKa87zdlxNzcoHXH1J2chOLTah0rHCNcnaM2piIjj7n+TtvKQKW/hwD/nWKyw\n mVmJBG01X+Xo7Md+podF8OFH+8dWjfIQCTn0FEeY/2xwp/zBESa++o+kjqBBwIJEM0\n +CTH+EE8NFEHN07GGByp7nrtS+XxUR+RLz9DWhFkFPJiscIrcYrPvC4IZLSSFkw8eK\n 5SV7TLO/b5TyA==","Date":"Sat, 25 Feb 2023 22:16:38 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Martin Rowe <martin.p.rowe@gmail.com>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230225211638.nw73tvclmibzpxqq@pali>","References":"\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>\n <20230223180223.g6fy72hjttgbhdmb@pali>\n <CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>\n <CAOAjy5QU-Jao+k3Ada+YAn74HvMbtTNBkh+uanSfqpUT_dMLkg@mail.gmail.com>\n <20230224223421.duckxwmax4efcn6g@pali>\n <CAOAjy5RHu8XcP978gtGP5mLvVasMHbNvFFDn+U6zP6zLb4RdUg@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <CAOAjy5RHu8XcP978gtGP5mLvVasMHbNvFFDn+U6zP6zLb4RdUg@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3065366,"web_url":"http://patchwork.ozlabs.org/comment/3065366/","msgid":"<20230225220004.v532yhv5ryaiel2x@pali>","list_archive_url":null,"date":"2023-02-25T22:00:04","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Tuesday 21 February 2023 21:18:26 Pali Rohár wrote:\n> This patch series contains various improvements and fixes for existing\n> logical errors. Boot phase was adjusted to match behavior of Armada 385\n> BootROM by inspecting and disassembling of BootROM binary dump itself.\n> Important information are included in documentation patch for kwboot.\n> Most of the changes are untested, hence this patch series is just RFC.\n> So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n> Nevertheless all patches on github passed CI testing in this PR:\n> https://github.com/u-boot/u-boot/pull/275\n\nPatches were tested on more boards and seems there is no reported issue,\nbut other improvements.\n\nSo do you need something to modify in this relatively big patch series?\nIf it is not really needed I would like to not send it again because\ndenx servers are not able to handle it. And it take me lot of time to\nsend patches over emails to denx servers.\n\n> \n> Pali Rohár (59):\n>   tools: kwbimage: Fix generating, verifying and extracting SDIO\n>     kwbimage\n>   tools: kwboot: Fix parsing SDIO kwbimage\n>   arm: mvebu: spl: Fix parsing SDIO kwbimage\n>   cmd: mvebu/bubt: Fix parsing SDIO kwbimage\n>   tools: kwbimage: Fix generating, verifying and extracting SATA\n>     kwbimage\n>   tools: kwboot: Fix parsing SATA kwbimage\n>   arm: mvebu: spl: Fix parsing SATA kwbimage\n>   cmd: mvebu/bubt: Fix parsing SATA kwbimage\n>   arm: mvebu: spl: Remove checks for BOOT_DEVICE_MMC2 and\n>     BOOT_DEVICE_MMC2_2\n>   arm: mvebu: spl: Load proper U-Boot from selected eMMC boot partition\n>   spl: mmc: Allow to disable SYS_MMCSD_FS_BOOT_PARTITION\n>   arm: mvebu: spl: Fix support for loading U-Boot proper from SD card\n>   tools: kwboot: Add more documentation references\n>   tools: kwboot: Add image type documentation\n>   tools: kwboot: Fix parsing UART image without data checksum\n>   tools: kwboot: Validate optional kwbimage v1 headers\n>   tools: kwboot: Add check that kwbimage contains DDR init code\n>   tools: kwboot: Fix patching of SPI/NOR XIP images\n>   tools: kwboot: Show image type and error parsing reasons\n>   cmd: mvebu/bubt: Add support for selecting eMMC HW partition\n>   cmd: mvebu/bubt: Add support for writing image to SATA disk\n>   cmd: mvebu/bubt: Add support for reading image from the SATA disk\n>     partition\n>   cmd: mvebu/bubt: Rename variable image_size to hdr_size\n>   cmd: mvebu/bubt: Mark all local symbols as static\n>   cmd: mvebu/bubt: Do not modify image in A8K check_image_header()\n>   cmd: mvebu/bubt: Check also A8K boot image checksum\n>   cmd: mvebu/bubt: Set correct default image name for 32-bit Armada SoCs\n>   cmd: mvebu/bubt: Better guess default MVEBU_*_BOOT option\n>   cmd: mvebu/bubt: Fix warnings: unused variable 'secure_mode' and\n>     'fuse_read_u64' defined but not used\n>   cmd: mvebu/bubt: Enable command by default\n>   tools: kwbimage: Fix dumping register set / DATA commands\n>   tools: kwbimage: Fix endianity when dumping NAND_PAGE_SIZE\n>   tools: kwbimage: Fix dumping NAND_BADBLK_LOCATION\n>   tools: kwbimage: Fix dumping NAND_BLKSZ\n>   tools: kwbimage: Fix generating of kwbimage v0 header checksum\n>   tools: kwbimage: Fix endianity when printing kwbimage header\n>   tools: kwbimage: Reject mkimage -F option\n>   tools: kwbimage: Add support for dumping NAND_BLKSZ for v0 images\n>   tools: kwbimage: Print binary image offset as size\n>   tools: kwbimage: Print image data offset when printing kwbimage header\n>   tools: kwbimage: Simplify add_secure_header_v1()\n>   tools: kwbimage: Rename imagesz to dataoff\n>   tools: kwbimage: Fix generating secure boot data image signature\n>   tools: kwbimage: Fix invalid secure boot header signature\n>   tools: mkimage: Do not fill legacy_img_hdr for non-legacy XIP images\n>   tools: kwbimage: Add support for XIP SPI/NOR images\n>   tools: mkimage: Print human readable error when -d is not specified\n>   tools: mkimage: Do not try to open datafile when it is skipped\n>   tools: kwbimage: Add support for creating an image with no data\n>   arm: mvebu: Add support for generating NAND kwbimage\n>   arm: mvebu: Add support for generating PEX kwbimage\n>   arm: mvebu: Fix description of MVEBU_SPL_BOOT_DEVICE_(SPI|MMC) options\n>   arm: mvebu: db-88f6820-amc: Add defconfig for NAND booting\n>   arm: mvebu: clearfog: Add defconfig for SATA booting\n>   arm: mvebu: Remove A39x relicts\n>   arm: mvebu: Fix comment about CPU_ATTR_BOOTROM mapping\n>   arm: mvebu: Define env_sf_get_env_addr() also for Proper U-Boot\n>   arm: mvebu: Define SPL memory maps\n>   doc/kwboot.1: Update example description\n> \n>  arch/arm/mach-mvebu/Kconfig                   |  23 +-\n>  arch/arm/mach-mvebu/Makefile                  |  13 +\n>  arch/arm/mach-mvebu/cpu.c                     |  11 +-\n>  arch/arm/mach-mvebu/include/mach/cpu.h        |  21 ++\n>  arch/arm/mach-mvebu/kwbimage.cfg.in           |   5 +\n>  .../serdes/a38x/high_speed_env_spec.c         |   4 +-\n>  .../serdes/a38x/high_speed_env_spec.h         |   4 +-\n>  arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c |  14 +-\n>  arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.h |  30 --\n>  arch/arm/mach-mvebu/spl.c                     |  84 +++--\n>  cmd/mvebu/Kconfig                             |  18 ++\n>  cmd/mvebu/bubt.c                              | 253 ++++++++++++---\n>  common/spl/Kconfig                            |   9 +\n>  common/spl/spl_mmc.c                          |  12 +-\n>  ...rfog_defconfig => clearfog_sata_defconfig} |   2 +-\n>  ...efconfig => db-88f6820-amc_nand_defconfig} |   6 +-\n>  doc/kwboot.1                                  |   3 +-\n>  doc/mvebu/cmd/bubt.txt                        |  25 +-\n>  drivers/mtd/nand/raw/Kconfig                  |   4 +-\n>  tools/kwbimage.c                              | 297 +++++++++++-------\n>  tools/kwboot.c                                | 200 +++++++++++-\n>  tools/mkimage.c                               |  11 +-\n>  22 files changed, 768 insertions(+), 281 deletions(-)\n>  copy configs/{clearfog_defconfig => clearfog_sata_defconfig} (98%)\n>  copy configs/{db-88f6820-amc_defconfig => db-88f6820-amc_nand_defconfig} (92%)\n> \n> -- \n> 2.20.1\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=gAXQ5VHt;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"gAXQ5VHt\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PPLKs0NK4z240p\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Feb 2023 09:00:32 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 5C73C85929;\n\tSat, 25 Feb 2023 23:00:24 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id CB23685929; Sat, 25 Feb 2023 23:00:21 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B19FA85925\n for <u-boot@lists.denx.de>; Sat, 25 Feb 2023 23:00:09 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 4096660B8B;\n Sat, 25 Feb 2023 22:00:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 56590C433D2;\n Sat, 25 Feb 2023 22:00:07 +0000 (UTC)","by pali.im (Postfix)\n id 0BB4B709; Sat, 25 Feb 2023 23:00:05 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677362407;\n bh=fA7RQC9sOkhXzxFqigRT1iJZBcWlU+d5N9wkBR4vRLg=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=gAXQ5VHtwvv2bBqf4RyIHHOUal31xYLoekl+KX6bBNR/xE1d+WO1zW9zDbw0MJNvq\n ywHUQfGef+OARcoVAM6fzRW3nzNPAxg/f+Ms3bc5hNr5LlFY63rGcglpv4c9lcwmqF\n Teo+F58M+02AcjR1DDiRaQxQZMEOukLT5n75GF/sKR/hM/oQZJ8fbcwdAJlbTiL4RS\n rA62zXqTMkT771tnHC10mUTrg9QnNMdN606FYxaS+ZqmfEYoclMBMDu8AA/CazqKNp\n ZLMpRwklHBVSD2CfbXFl3FtzQb31aCdHYFJ/Ye2Jm4tIRBjtRXyjBR/zOdK+TLB8w1\n 3wn1tzFM1nmRA==","Date":"Sat, 25 Feb 2023 23:00:04 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"u-boot@lists.denx.de","Cc":"Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>,\n Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230225220004.v532yhv5ryaiel2x@pali>","References":"<20230221201925.9644-1-pali@kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20230221201925.9644-1-pali@kernel.org>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3065379,"web_url":"http://patchwork.ozlabs.org/comment/3065379/","msgid":"<CAOAjy5S3EoanmjaVzit_YXzJDBhFih0rJof1AmLWOvZLYXdRSQ@mail.gmail.com>","list_archive_url":null,"date":"2023-02-26T01:56:23","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":85861,"url":"http://patchwork.ozlabs.org/api/people/85861/","name":"Martin Rowe","email":"martin.p.rowe@gmail.com"},"content":"On Sat, 25 Feb 2023 at 21:16, Pali Rohár <pali@kernel.org> wrote:\n> I think that the remaining part is to patch linux DTB file at runtime\n> for emmc support. So if u-boot mmc device is of eMMC type then fixup\n> linux dtb file and others do nothing.\n\nOne question I didn't think of when suggesting this: does runtime\npatching the kernel's dtb break signed/verified booting? The reason I\nask is because we now only need to patch the kernel dtb, not the\nu-boot one. If we needed to do both, then it would make sense to\nhandle them in the same way through u-boot. The barrier to creating a\npatched kernel dtb file on its own is very low, so I'm not sure adding\nsome \"magic\" to u-boot to make it work is the best solution,\nespecially if it might break verified boot.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=QyVFM+bM;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"QyVFM+bM\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=martin.p.rowe@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PPRZR0Qjpz246C\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Feb 2023 12:56:46 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DF48A857E4;\n\tSun, 26 Feb 2023 02:56:40 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 3A1FB8537E; Sun, 26 Feb 2023 02:56:39 +0100 (CET)","from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com\n [IPv6:2607:f8b0:4864:20::22f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 5CB918537E\n for <u-boot@lists.denx.de>; Sun, 26 Feb 2023 02:56:36 +0100 (CET)","by mail-oi1-x22f.google.com with SMTP id bh20so2638352oib.9\n for <u-boot@lists.denx.de>; Sat, 25 Feb 2023 17:56:36 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=hqJ1koYj04bh1gS4673ygHNqIhv3bOzCr0bj2ZXFFI0=;\n b=QyVFM+bM2c/hoUkwMzoIw26X3UyOTZUh1xFny4zdCyVQazN7OSeAiBvNACVmgzoy5N\n vJF4ugbBbmTcDIwI4kUsRK7ry4ZApfU3UR1f2JtC6DeRMPKHp+TUkcubIw3uqgjh5TuH\n WAjNAL4ZD8RjSO66RUczvu4VegdhBTeF2ON4YtqaFiFCpo0t3iue3VcsMLiBFizelGwE\n 8T5x1oTwYYaMFcBjSH+8Qzu4asloKozUJZKpfGtcA5NMg5zMEpYp4EmY2evBQREavyku\n 4rhrpj6aOIK5qzrTj0v7hCSlk+IpMIEQJ9DhHFeTA6ZPEXUhnnN2fnCBy31Ru3+K3Ckj\n A5KQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=hqJ1koYj04bh1gS4673ygHNqIhv3bOzCr0bj2ZXFFI0=;\n b=xLt5Y4tYEUeWMhvxkAwrRIRIFc4t2/NbRfHQ1GkDdEzzl+wPXIZ24tKEux925eqVqo\n wVg4e4ilhOBWlkD0MRfij5NGJksDrVGdIaAPacC9xWtc2F0vrZrhy0uhHWvcKMo71P5X\n NhWbb1NoXf9Gif/UFrYPQ5ta9adrggKbc05vu76XxkMt/ijINdxdmgZzvjS4RDOZuDpj\n 5j4JECDx43ZL4FbRrp25dQG444US46/OxDrIkst4tsZFe1m3H+VhIq09ED1TVp41s5Dj\n OMZ5HDHpmci1ypKDG3xZsdaUvN9dNm7gfSOqFgJHAKLXwkGSVubfg7mPEdJ85L2pUCoS\n /qVA==","X-Gm-Message-State":"AO0yUKWDQXzrFMgmHI6CfHhEivslVTrUWPiXi5rscoRDTOOxMH+uaQB3\n o2Yql9tPXRlrKd+6zlnTVDjknHhWsiOoJdnCtpE=","X-Google-Smtp-Source":"\n AK7set86iFuPyyhIWMe8LVp4qIs/X/SdnFp5U8UHQCemo6LR8PfPIsp8K6yIGnL8YNnj6Z9a5wHtY2XCm8BtEYQ6kVI=","X-Received":"by 2002:a05:6808:7c4:b0:384:2615:f63 with SMTP id\n f4-20020a05680807c400b0038426150f63mr52004oij.3.1677376595071; Sat, 25 Feb\n 2023 17:56:35 -0800 (PST)","MIME-Version":"1.0","References":"\n <CAOAjy5SsoHh8rWTXbpHePW3-XY06aw+bVbu50m8_5cV0oMuc2w@mail.gmail.com>\n <20230222180307.7sxot7ivfx3elunx@pali>\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>\n <20230223180223.g6fy72hjttgbhdmb@pali>\n <CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>\n <CAOAjy5QU-Jao+k3Ada+YAn74HvMbtTNBkh+uanSfqpUT_dMLkg@mail.gmail.com>\n <20230224223421.duckxwmax4efcn6g@pali>\n <CAOAjy5RHu8XcP978gtGP5mLvVasMHbNvFFDn+U6zP6zLb4RdUg@mail.gmail.com>\n <20230225211638.nw73tvclmibzpxqq@pali>","In-Reply-To":"<20230225211638.nw73tvclmibzpxqq@pali>","From":"Martin Rowe <martin.p.rowe@gmail.com>","Date":"Sun, 26 Feb 2023 01:56:23 +0000","Message-ID":"\n <CAOAjy5S3EoanmjaVzit_YXzJDBhFih0rJof1AmLWOvZLYXdRSQ@mail.gmail.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3065399,"web_url":"http://patchwork.ozlabs.org/comment/3065399/","msgid":"<20230226081413.lwuvn7wyuv5in34z@pali>","list_archive_url":null,"date":"2023-02-26T08:14:13","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/","name":"Pali Rohár","email":"pali@kernel.org"},"content":"On Sunday 26 February 2023 01:56:23 Martin Rowe wrote:\n> On Sat, 25 Feb 2023 at 21:16, Pali Rohár <pali@kernel.org> wrote:\n> > I think that the remaining part is to patch linux DTB file at runtime\n> > for emmc support. So if u-boot mmc device is of eMMC type then fixup\n> > linux dtb file and others do nothing.\n> \n> One question I didn't think of when suggesting this: does runtime\n> patching the kernel's dtb break signed/verified booting\n\nI do not think so. Signature verification should be done before\npatching.\n\n> The reason I\n> ask is because we now only need to patch the kernel dtb, not the\n> u-boot one. If we needed to do both, then it would make sense to\n> handle them in the same way through u-boot. The barrier to creating a\n> patched kernel dtb file on its own is very low, so I'm not sure adding\n> some \"magic\" to u-boot to make it work is the best solution,\n> especially if it might break verified boot.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=KFUgjZlS;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"KFUgjZlS\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PPbyQ0THdz246C\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Feb 2023 19:14:36 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B50EA85931;\n\tSun, 26 Feb 2023 09:14:22 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 6060B8547B; Sun, 26 Feb 2023 09:14:21 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 3D66785941\n for <u-boot@lists.denx.de>; Sun, 26 Feb 2023 09:14:19 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 6695460BCB;\n Sun, 26 Feb 2023 08:14:17 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 9A6CAC433D2;\n Sun, 26 Feb 2023 08:14:16 +0000 (UTC)","by pali.im (Postfix)\n id D832A8A5; Sun, 26 Feb 2023 09:14:13 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677399256;\n bh=3CxAe/JIl2VxvTpoHxWIkZDa5liwE3kvFQ2druCJUUY=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=KFUgjZlSi77QGQ/9Ky/YhHLrn1NDklNeOheWm0xZps3qrEPFzc+sqLWCVZtqg4idi\n XggU3ZDF1NUt4EnAsPXXtBwcMUgGkblo5cEO0KvsOWpGJuQaNxzd3Cs20cfmD40iV3\n qA73XlOuv4BM+G/ny2N5epHDPDGq5MYAmwnZ2uSuOtkL3cC3tFW0typD0Qjkx9VG/+\n sbE2DOu/NOClyXak6CUwrMVlK93V9OAJPMvWwEOifvgr0qLNnAHg7c1AJMleY0VQ/V\n l7NHZVFyJ3MAJtRkLcgZNARdKxb2aPU7yNLRNPvkEPwGONlrO2kKsmc90UPZWNAZLJ\n NB/9YYZrrKJfw==","Date":"Sun, 26 Feb 2023 09:14:13 +0100","From":"Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>","To":"Martin Rowe <martin.p.rowe@gmail.com>","Cc":"Tony Dinh <mibodhi@gmail.com>, u-boot@lists.denx.de,\n Stefan Roese <sr@denx.de>, Josua Mayer <josua@solid-run.com>","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Message-ID":"<20230226081413.lwuvn7wyuv5in34z@pali>","References":"\n <CAOAjy5Tj-9efA=5=bBsTn1AhrX8oYHHRXLUw0u5jbEJtp9xkdw@mail.gmail.com>\n <20230222212356.abfhl7omg35hwizc@pali>\n <CAOAjy5SYPPzWKok-BSGYwZwcKOQt_aZPgh6FTbrFd3F=8DM5ZQ@mail.gmail.com>\n <20230223180223.g6fy72hjttgbhdmb@pali>\n <CAOAjy5R9XUm_tpvzE9hHYeCBvjKrqJ83t_iGN1JAEuY3GxUEOQ@mail.gmail.com>\n <CAOAjy5QU-Jao+k3Ada+YAn74HvMbtTNBkh+uanSfqpUT_dMLkg@mail.gmail.com>\n <20230224223421.duckxwmax4efcn6g@pali>\n <CAOAjy5RHu8XcP978gtGP5mLvVasMHbNvFFDn+U6zP6zLb4RdUg@mail.gmail.com>\n <20230225211638.nw73tvclmibzpxqq@pali>\n <CAOAjy5S3EoanmjaVzit_YXzJDBhFih0rJof1AmLWOvZLYXdRSQ@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"\n <CAOAjy5S3EoanmjaVzit_YXzJDBhFih0rJof1AmLWOvZLYXdRSQ@mail.gmail.com>","User-Agent":"NeoMutt/20180716","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3065655,"web_url":"http://patchwork.ozlabs.org/comment/3065655/","msgid":"<9edea773-4d93-447e-418b-0a885a741591@denx.de>","list_archive_url":null,"date":"2023-02-27T07:44:30","subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"Hi Pali,\n\nOn 2/25/23 23:00, Pali Rohár wrote:\n> On Tuesday 21 February 2023 21:18:26 Pali Rohár wrote:\n>> This patch series contains various improvements and fixes for existing\n>> logical errors. Boot phase was adjusted to match behavior of Armada 385\n>> BootROM by inspecting and disassembling of BootROM binary dump itself.\n>> Important information are included in documentation patch for kwboot.\n>> Most of the changes are untested, hence this patch series is just RFC.\n>> So please test changes before applying, idealy on SPI, SATA and SD/MMC.\n>> Nevertheless all patches on github passed CI testing in this PR:\n>> https://github.com/u-boot/u-boot/pull/275\n> \n> Patches were tested on more boards and seems there is no reported issue,\n> but other improvements.\n> \n> So do you need something to modify in this relatively big patch series?\n> If it is not really needed I would like to not send it again because\n> denx servers are not able to handle it. And it take me lot of time to\n> send patches over emails to denx servers.\n\nI'm fine with applying the series as-is. I'm a bit hesitant though, if\nit should be applied to master or to next. As Tom clearly noticed, that\nonly fixes should be added after rc2 this time.\n\nWhat is your thinking on this?\n\nThanks,\nStefan\n\n> \n>>\n>> Pali Rohár (59):\n>>    tools: kwbimage: Fix generating, verifying and extracting SDIO\n>>      kwbimage\n>>    tools: kwboot: Fix parsing SDIO kwbimage\n>>    arm: mvebu: spl: Fix parsing SDIO kwbimage\n>>    cmd: mvebu/bubt: Fix parsing SDIO kwbimage\n>>    tools: kwbimage: Fix generating, verifying and extracting SATA\n>>      kwbimage\n>>    tools: kwboot: Fix parsing SATA kwbimage\n>>    arm: mvebu: spl: Fix parsing SATA kwbimage\n>>    cmd: mvebu/bubt: Fix parsing SATA kwbimage\n>>    arm: mvebu: spl: Remove checks for BOOT_DEVICE_MMC2 and\n>>      BOOT_DEVICE_MMC2_2\n>>    arm: mvebu: spl: Load proper U-Boot from selected eMMC boot partition\n>>    spl: mmc: Allow to disable SYS_MMCSD_FS_BOOT_PARTITION\n>>    arm: mvebu: spl: Fix support for loading U-Boot proper from SD card\n>>    tools: kwboot: Add more documentation references\n>>    tools: kwboot: Add image type documentation\n>>    tools: kwboot: Fix parsing UART image without data checksum\n>>    tools: kwboot: Validate optional kwbimage v1 headers\n>>    tools: kwboot: Add check that kwbimage contains DDR init code\n>>    tools: kwboot: Fix patching of SPI/NOR XIP images\n>>    tools: kwboot: Show image type and error parsing reasons\n>>    cmd: mvebu/bubt: Add support for selecting eMMC HW partition\n>>    cmd: mvebu/bubt: Add support for writing image to SATA disk\n>>    cmd: mvebu/bubt: Add support for reading image from the SATA disk\n>>      partition\n>>    cmd: mvebu/bubt: Rename variable image_size to hdr_size\n>>    cmd: mvebu/bubt: Mark all local symbols as static\n>>    cmd: mvebu/bubt: Do not modify image in A8K check_image_header()\n>>    cmd: mvebu/bubt: Check also A8K boot image checksum\n>>    cmd: mvebu/bubt: Set correct default image name for 32-bit Armada SoCs\n>>    cmd: mvebu/bubt: Better guess default MVEBU_*_BOOT option\n>>    cmd: mvebu/bubt: Fix warnings: unused variable 'secure_mode' and\n>>      'fuse_read_u64' defined but not used\n>>    cmd: mvebu/bubt: Enable command by default\n>>    tools: kwbimage: Fix dumping register set / DATA commands\n>>    tools: kwbimage: Fix endianity when dumping NAND_PAGE_SIZE\n>>    tools: kwbimage: Fix dumping NAND_BADBLK_LOCATION\n>>    tools: kwbimage: Fix dumping NAND_BLKSZ\n>>    tools: kwbimage: Fix generating of kwbimage v0 header checksum\n>>    tools: kwbimage: Fix endianity when printing kwbimage header\n>>    tools: kwbimage: Reject mkimage -F option\n>>    tools: kwbimage: Add support for dumping NAND_BLKSZ for v0 images\n>>    tools: kwbimage: Print binary image offset as size\n>>    tools: kwbimage: Print image data offset when printing kwbimage header\n>>    tools: kwbimage: Simplify add_secure_header_v1()\n>>    tools: kwbimage: Rename imagesz to dataoff\n>>    tools: kwbimage: Fix generating secure boot data image signature\n>>    tools: kwbimage: Fix invalid secure boot header signature\n>>    tools: mkimage: Do not fill legacy_img_hdr for non-legacy XIP images\n>>    tools: kwbimage: Add support for XIP SPI/NOR images\n>>    tools: mkimage: Print human readable error when -d is not specified\n>>    tools: mkimage: Do not try to open datafile when it is skipped\n>>    tools: kwbimage: Add support for creating an image with no data\n>>    arm: mvebu: Add support for generating NAND kwbimage\n>>    arm: mvebu: Add support for generating PEX kwbimage\n>>    arm: mvebu: Fix description of MVEBU_SPL_BOOT_DEVICE_(SPI|MMC) options\n>>    arm: mvebu: db-88f6820-amc: Add defconfig for NAND booting\n>>    arm: mvebu: clearfog: Add defconfig for SATA booting\n>>    arm: mvebu: Remove A39x relicts\n>>    arm: mvebu: Fix comment about CPU_ATTR_BOOTROM mapping\n>>    arm: mvebu: Define env_sf_get_env_addr() also for Proper U-Boot\n>>    arm: mvebu: Define SPL memory maps\n>>    doc/kwboot.1: Update example description\n>>\n>>   arch/arm/mach-mvebu/Kconfig                   |  23 +-\n>>   arch/arm/mach-mvebu/Makefile                  |  13 +\n>>   arch/arm/mach-mvebu/cpu.c                     |  11 +-\n>>   arch/arm/mach-mvebu/include/mach/cpu.h        |  21 ++\n>>   arch/arm/mach-mvebu/kwbimage.cfg.in           |   5 +\n>>   .../serdes/a38x/high_speed_env_spec.c         |   4 +-\n>>   .../serdes/a38x/high_speed_env_spec.h         |   4 +-\n>>   arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c |  14 +-\n>>   arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.h |  30 --\n>>   arch/arm/mach-mvebu/spl.c                     |  84 +++--\n>>   cmd/mvebu/Kconfig                             |  18 ++\n>>   cmd/mvebu/bubt.c                              | 253 ++++++++++++---\n>>   common/spl/Kconfig                            |   9 +\n>>   common/spl/spl_mmc.c                          |  12 +-\n>>   ...rfog_defconfig => clearfog_sata_defconfig} |   2 +-\n>>   ...efconfig => db-88f6820-amc_nand_defconfig} |   6 +-\n>>   doc/kwboot.1                                  |   3 +-\n>>   doc/mvebu/cmd/bubt.txt                        |  25 +-\n>>   drivers/mtd/nand/raw/Kconfig                  |   4 +-\n>>   tools/kwbimage.c                              | 297 +++++++++++-------\n>>   tools/kwboot.c                                | 200 +++++++++++-\n>>   tools/mkimage.c                               |  11 +-\n>>   22 files changed, 768 insertions(+), 281 deletions(-)\n>>   copy configs/{clearfog_defconfig => clearfog_sata_defconfig} (98%)\n>>   copy configs/{db-88f6820-amc_defconfig => db-88f6820-amc_nand_defconfig} (92%)\n>>\n>> -- \n>> 2.20.1\n>>\n\nViele Grüße,\nStefan Roese","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=denx.de header.i=@denx.de header.a=rsa-sha256\n header.s=phobos-20191101 header.b=ant6L3AF;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=denx.de","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=denx.de","phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PQCFV4Sz6z1yX0\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Feb 2023 18:44:44 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 41C0685A36;\n\tMon, 27 Feb 2023 08:44:38 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id D566D85A26; Mon, 27 Feb 2023 08:44:36 +0100 (CET)","from mout-u-204.mailbox.org (mout-u-204.mailbox.org [80.241.59.204])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id F084F85A4A\n for <u-boot@lists.denx.de>; Mon, 27 Feb 2023 08:44:33 +0100 (CET)","from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest\n SHA256) (No client certificate requested)\n by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4PQCFC4MRzz9sS1;\n Mon, 27 Feb 2023 08:44:31 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de;\n\ts=phobos-20191101; t=1677483878;\n\tbh=sFXkqdFcH4wKSKswCFJZo3WpKHwmvEaFOI7eg0fptvM=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=ant6L3AFa2j4zT3ZMRYziOOwDCsyGZEYEj2DfD9YXhgrD+ZPHEBIXQKz0vxEZaH3H\n\t MNfZ7XcVDwr3XiLteH6E1BCj0MpAAYFgZM4WXIsnCipvQpBWgT0lb/59jj21yZiwOA\n\t /RKXS+rPtBMLlQJdX59JZ1sdXk6SQmYai4aoq1edWkLhSm8trJikTHZpiQlY5ncOhS\n\t 5PAN0lNRU4t6uF1HX1KjQQ/kcoOrrBPgGFrVkrfmoronjEyW6XUzGckc4RsR/uT+z6\n\t to02YQTFUNYBQ30o/DRMasSkHwfWtqEt6jDCay7t7skOJzaDh15UgEzyZmB+oMQwy6\n\t 0x+DXl3frlM2w==","X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,SPF_HELO_NONE,\n SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2","Message-ID":"<9edea773-4d93-447e-418b-0a885a741591@denx.de>","Date":"Mon, 27 Feb 2023 08:44:30 +0100","MIME-Version":"1.0","Subject":"Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes","Content-Language":"en-US","To":"=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>, u-boot@lists.denx.de","Cc":"Tony Dinh <mibodhi@gmail.com>, Josua Mayer <josua@solid-run.com>","References":"<20230221201925.9644-1-pali@kernel.org>\n <20230225220004.v532yhv5ryaiel2x@pali>","From":"Stefan Roese <sr@denx.de>","In-Reply-To":"<20230225220004.v532yhv5ryaiel2x@pali>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"}}]