[{"id":2591999,"web_url":"http://patchwork.ozlabs.org/comment/2591999/","msgid":"<20201203134117.2fdqiiapcjnlwj66@steredhat>","list_archive_url":null,"date":"2020-12-03T13:41:17","subject":"Re: [PATCH v2 0/4] vhost-user: avoid g_return_val_if() in\n get/set_config()","submitter":{"id":75453,"url":"http://patchwork.ozlabs.org/api/people/75453/","name":"Stefano Garzarella","email":"sgarzare@redhat.com"},"content":"On Wed, Dec 02, 2020 at 03:26:07PM +0000, Stefan Hajnoczi wrote:\n>v2:\n> * Print errors [Marc-André]\n>\n>Markus Armbruster pointed out that g_return_val_if() is meant for programming\n>errors. It must not be used for input validation since it can be compiled out.\n>Use explicit if statements instead.\n>\n>This patch series converts vhost-user device backends that use\n>g_return_val_if() in get/set_config().\n>\n>Stefan Hajnoczi (4):\n> contrib/vhost-user-blk: avoid g_return_val_if() input validation\n> contrib/vhost-user-gpu: avoid g_return_val_if() input validation\n> contrib/vhost-user-input: avoid g_return_val_if() input validation\n> block/export: avoid g_return_val_if() input validation\n>\n> block/export/vhost-user-blk-server.c | 6 +++++-\n> contrib/vhost-user-blk/vhost-user-blk.c | 6 +++++-\n> contrib/vhost-user-gpu/vhost-user-gpu.c | 6 +++++-\n> contrib/vhost-user-input/main.c | 6 +++++-\n> 4 files changed, 20 insertions(+), 4 deletions(-)\n>\n>-- \n>2.28.0\n>\n\nReviewed-by: Stefano Garzarella ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=redhat.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Jn7EPWTU;\n\tdkim-atps=neutral","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4Cmxph3vsdz9sRK\n\tfor ; Fri, 4 Dec 2020 00:42:18 +1100 (AEDT)","from localhost ([::1]:36800 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kkosA-00072O-2c\n\tfor incoming@patchwork.ozlabs.org; Thu, 03 Dec 2020 08:42:14 -0500","from eggs.gnu.org ([2001:470:142:3::10]:57338)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1kkorP-0006xN-9c\n for qemu-devel@nongnu.org; Thu, 03 Dec 2020 08:41:27 -0500","from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:47997)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from )\n id 1kkorN-0008Br-9y\n for qemu-devel@nongnu.org; Thu, 03 Dec 2020 08:41:26 -0500","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-570-i8_aftWGPKuG9e7-OEfFiA-1; Thu, 03 Dec 2020 08:41:23 -0500","by mail-wr1-f70.google.com with SMTP id 91so1210179wrk.17\n for ; Thu, 03 Dec 2020 05:41:22 -0800 (PST)","from steredhat (host-79-17-248-175.retail.telecomitalia.it.\n [79.17.248.175])\n by smtp.gmail.com with ESMTPSA id l3sm1892529wrr.89.2020.12.03.05.41.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 03 Dec 2020 05:41:20 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1607002884;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jprnTLH/+CB2lFk4WQqVggXQmNXoJCYcKVDhmIqXO9w=;\n b=Jn7EPWTUxBaqmJqJvVw+rYFDhqDXDapTblc5iYhS7mh8zmX2GzTe3VpIuDUYK5avj0ZVDy\n 3ZS+FTKGqiZXAFXTt0gZyCSSwXOQn7+LMzwDZcSad4YPcMsrd8q2CObZ1/cmzdmu62NMAR\n q985HQiptqnPAEwvjzJKnVqG85+aA/c=","X-MC-Unique":"i8_aftWGPKuG9e7-OEfFiA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:references\n :mime-version:content-disposition:content-transfer-encoding\n :in-reply-to;\n bh=uStGy8XQjn/UAlfLd7Z4SOzAeaFsdlmalAOJBw94N74=;\n b=COKfV9Z3lyG29HTee9MvnTAEpcBALeZh+fTK0FU8PKNWJ457EUVSEsRuNAd9MyyPPr\n YcZM/+AK91exhpoaudwYHjt8VpbDxvd3eccgnPf9y/0fGwPm4FOOfRCE+1Y98RHCbVd/\n WstTVcMBGtUbNI2z5Sobj3c1btlsEjRFoJAIRx0D6TnMJDXz/5Em3ey6X+cyE8D4nYUO\n swRVpgGJakgEyMx//WhWxtW9Z2SPe4dwEJvNcmIYH81US+M9sOwwI+eqN51jDZa1+PxD\n ww6ySZ7R4ZhnoPC/0FkqT0tnCZPNkyFmyMp9NhfQQ+99OlEl77L6fRxliSS4TE8i0qum\n TgMg==","X-Gm-Message-State":"AOAM531BtWF2rQrsq2b7Oc2wNuz66i+GuBOa73RA6ayGN7t8QQNlIfkY\n rcpiF5MCSzoim2HzGPb3L6qxLxisPUAveNL8Eosih9ZvluljkqtjlqfRQIhVYKfRjzucqWV8IAL\n Ssbsblye4qAjG5ik=","X-Received":["by 2002:adf:f181:: with SMTP id h1mr3743971wro.267.1607002881103;\n Thu, 03 Dec 2020 05:41:21 -0800 (PST)","by 2002:adf:f181:: with SMTP id h1mr3743938wro.267.1607002880842;\n Thu, 03 Dec 2020 05:41:20 -0800 (PST)"],"X-Google-Smtp-Source":"\n ABdhPJyj5ZUFk7ROFfzTxWETZHXOJl3Jw0zGIBdkx0iMRXz3G6G9xk9Bj8+xgpM2ic6Pg9DkkNULbg==","Date":"Thu, 3 Dec 2020 14:41:17 +0100","From":"Stefano Garzarella ","To":"Stefan Hajnoczi ","Subject":"Re: [PATCH v2 0/4] vhost-user: avoid g_return_val_if() in\n get/set_config()","Message-ID":"<20201203134117.2fdqiiapcjnlwj66@steredhat>","References":"<20201202152611.677753-1-stefanha@redhat.com>","MIME-Version":"1.0","In-Reply-To":"<20201202152611.677753-1-stefanha@redhat.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=iso-8859-1; format=flowed","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=63.128.21.124; envelope-from=sgarzare@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-35","X-Spam_score":"-3.6","X-Spam_bar":"---","X-Spam_report":"(-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf , qemu-block@nongnu.org,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n qemu-devel@nongnu.org, Coiby Xu ,\n Raphael Norwitz ,\n =?utf-8?q?Marc-Andr=C3=A9?= Lureau ,\n Gerd Hoffmann ,\n =?utf-8?q?Marc-Andr=C3=A9?= Lureau ,\n Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}},{"id":2597518,"web_url":"http://patchwork.ozlabs.org/comment/2597518/","msgid":"","list_archive_url":null,"date":"2020-12-10T08:29:28","subject":"Re: [PATCH v2 0/4] vhost-user: avoid g_return_val_if() in\n get/set_config()","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"Hi Michael,\n\nOn Thu, Dec 3, 2020 at 5:41 PM Stefano Garzarella \nwrote:\n\n> On Wed, Dec 02, 2020 at 03:26:07PM +0000, Stefan Hajnoczi wrote:\n> >v2:\n> > * Print errors [Marc-André]\n> >\n> >Markus Armbruster pointed out that g_return_val_if() is meant for\n> programming\n> >errors. It must not be used for input validation since it can be compiled\n> out.\n> >Use explicit if statements instead.\n> >\n> >This patch series converts vhost-user device backends that use\n> >g_return_val_if() in get/set_config().\n> >\n> >Stefan Hajnoczi (4):\n> > contrib/vhost-user-blk: avoid g_return_val_if() input validation\n> > contrib/vhost-user-gpu: avoid g_return_val_if() input validation\n> > contrib/vhost-user-input: avoid g_return_val_if() input validation\n> > block/export: avoid g_return_val_if() input validation\n> >\n> > block/export/vhost-user-blk-server.c | 6 +++++-\n> > contrib/vhost-user-blk/vhost-user-blk.c | 6 +++++-\n> > contrib/vhost-user-gpu/vhost-user-gpu.c | 6 +++++-\n> > contrib/vhost-user-input/main.c | 6 +++++-\n> > 4 files changed, 20 insertions(+), 4 deletions(-)\n> >\n> >--\n> >2.28.0\n> >\n>\n> Reviewed-by: Stefano Garzarella \n>\n>\nYou didn't collect the v2 patch series, with the received reviewed-by. Not\na big deal here, but please be more careful.\n\nthanks","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=gmail.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=EAU8RAZW;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4Cs6Yv73vvz9sVn\n\tfor ; Thu, 10 Dec 2020 19:30:42 +1100 (AEDT)","from localhost ([::1]:46398 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1knHLS-0006qg-VB\n\tfor incoming@patchwork.ozlabs.org; Thu, 10 Dec 2020 03:30:38 -0500","from eggs.gnu.org ([2001:470:142:3::10]:34214)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1knHKZ-0006qU-Tf; Thu, 10 Dec 2020 03:29:43 -0500","from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:45408)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1knHKY-0006Ti-B8; Thu, 10 Dec 2020 03:29:43 -0500","by mail-ej1-x641.google.com with SMTP id qw4so6085514ejb.12;\n Thu, 10 Dec 2020 00:29:41 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc; bh=ANmmXfT7nWxlI1V/AiIa/hQzBZWe0tKmBvGaZWeR9Y4=;\n b=EAU8RAZWo/4v7mKj7l/JTP3G+p6BYjE3c6WezWqVhgyx4ghpaoOGXLon4Zs/r7DuMd\n W3FVoLbFgwdzjl2RVLywfa1fb8s3AZeFMD/EcOJHu74G9WZHKRm72a+ppl82Rxkee0Bl\n XrpjnKapGSdTt364o/UVSeLWQ/7Xy4d7Zbrk4CnGftbso3alIxNcxVlumYUKezo2DybK\n j9sNBEt1feD9xStj88A5RHDBwj5uF2Zs43DRALAyaZ//X8Ut+8M4R+swfdlpYwFRDhA1\n +VvTSZK22Z7tmbtLmpR8QMcmJJW5cizytn/wzSr1StjA5CFRQMujoTgrZ6zUGP+R7iv0\n RoGQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=ANmmXfT7nWxlI1V/AiIa/hQzBZWe0tKmBvGaZWeR9Y4=;\n b=lv5sve5t/8f7ZFZz+QtH3Q972yFZrks+NAT43RgELgulte+T6iUxLB+otrSSIsMvSX\n WiI2SaEfEwc+bqmQOm9oeEqVZWnaaWe0A5pcVt7rZRXaOOhRCiA5mE2/ieNmxI0iR4eO\n zLsRvyhoZMs35gJmkmlMcsN70us76Tv+Nuhb49mhm/4h+b5YKaQqyy1JdXCMNAdr3k2v\n lhbM+XAZaocogJ7O/gTiDHMIT6BrExd3UmEDLeiB1IlF7h9qS5vCjv/5KXbAP51por+C\n Elc33D+p45sq93/bPkBsZeDRVN/ZpJuM/ZAqpgmvxlB/VeRONOCk/dXVsVk9h9T9gypl\n Il1g==","X-Gm-Message-State":"AOAM531pH8jWNlHyRiZRDHvtkt+0E9fYpfYFRLcQazVuXqSNmTBh1mGJ\n 9qsqH0RsYFqtHHtiOq3hRE1sN13g6lVLu+Rjj9E=","X-Google-Smtp-Source":"\n ABdhPJzOrvRA1mi3ULKWroWC5SamYF8f1bx7WOP8GBkdjfRFQXnh/oDd8L93+4zApzN9Zpru9dr+B3GUhjTLGPtPbTA=","X-Received":"by 2002:a17:906:30d2:: with SMTP id\n b18mr5383065ejb.109.1607588980241;\n Thu, 10 Dec 2020 00:29:40 -0800 (PST)","MIME-Version":"1.0","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201203134117.2fdqiiapcjnlwj66@steredhat>","In-Reply-To":"<20201203134117.2fdqiiapcjnlwj66@steredhat>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 10 Dec 2020 12:29:28 +0400","Message-ID":"\n ","Subject":"Re: [PATCH v2 0/4] vhost-user: avoid g_return_val_if() in\n get/set_config()","To":"\"Michael S. Tsirkin\" ","Content-Type":"multipart/alternative; boundary=\"0000000000001cba6e05b617fa1d\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::641;\n envelope-from=marcandre.lureau@gmail.com; helo=mail-ej1-x641.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n \"open list:Block layer core\" ,\n Markus Armbruster , QEMU ,\n Coiby Xu , Raphael Norwitz ,\n Gerd Hoffmann , Stefan Hajnoczi ,\n Max Reitz , Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}}]